Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51408 --- mediaelements/mediacontroller/MediaController.qml

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 10:19 a.m.) Review request for Plasma. Changes

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51416 --- The whitespace is still there, if you see diff here on

Re: Review Request 116117: Place new panels to bottom by default

2014-03-01 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116117/ --- (Updated March 1, 2014, 11:47 a.m.) Review request for kde-workspace,

Re: Review Request 116117: Place new panels to bottom by default

2014-03-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116117/#review51421 --- Ship it!

Re: Review Request 116117: Place new panels to bottom by default

2014-03-01 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116117/ --- (Updated March 1, 2014, 12:03 p.m.) Status -- This change has been

Re: Review Request 116117: Place new panels to bottom by default

2014-03-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116117/#review51422 --- This review has been submitted with commit

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51423 --- mediaelements/mediacontroller/MediaController.qml

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 12:42 p.m.) Review request for Plasma. Changes

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51430 --- I've got good news and bad news. The good news is, the wheel

Re: Review Request 114429: use of time data engine - less code

2014-03-01 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114429/#review51432 --- Ship it! This can go in with the date part removed (time

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 3:03 p.m.) Review request for Plasma. Changes

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
On March 1, 2014, 12:57 p.m., Shantanu Tushar wrote: I've got good news and bad news. The good news is, the wheel works perfect! The bad news is that the MouseEventListener eats up clicks and hence the volumeButton never gets clicked which then means that you won't be able to show

Re: Review Request 116085: welcome back the javascript interactive console

2014-03-01 Thread David Faure
On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: src/shell/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/116085/diff/2/?file=246330#file246330line20 This would mean: a) propagate KTextEditor to part of the KF5 releases (that was not the case with TP1 alpha1)

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
On March 1, 2014, 12:57 p.m., Shantanu Tushar wrote: I've got good news and bad news. The good news is, the wheel works perfect! The bad news is that the MouseEventListener eats up clicks and hence the volumeButton never gets clicked which then means that you won't be able to show

[KDE Bugtracking System] REMINDER: current Plasma regressions

2014-03-01 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma. This is a weekly reminder. This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 301424: https://bugs.kde.org/show_bug.cgi?id=301424 Priority: NOR Severity: normal Platform: