Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review52229 --- After going to playlist like this, if you press back you get

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Ashish Madeti
On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote: After going to playlist like this, if you press back you get a blank screen with Loading spinner. Expected is the homescreen to come back. 1.Start PMC 2.Click on empty area (playlist shows) 3.Click back. I am getting homescreen only

Review Request 116627: EGL/X11 backend for WindowThumbnail QQuickItem

2014-03-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116627/ --- Review request for Plasma. Repository: plasma-framework Description

Re: [kde-community] KDE Books

2014-03-06 Thread Mirko Boehm
Hello, I am still figuring out whether or not I can attend. If I can, I am very happy to take part in a book sprint. It is a great idea. Cheers, Mirko. On 05 Mar 2014, at 06:57, Valorie Zimmerman valorie.zimmer...@gmail.com wrote: Hi folks, some months ago Mario Fux spoke to me about

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review52234 --- Sorry but I don't think this is better solution. Not every

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Sebastian Kügler
On March 6, 2014, 2:06 a.m., Hrvoje Senjan wrote: startkde.cmake, line 76 https://git.reviewboard.kde.org/r/116625/diff/1/?file=252390#file252390line76 Why not just change the defaults in frameworkintegration instead of writing directly into users settings? Martin Gräßlin

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 10:29 a.m.) Review request for Plasma and Àlex

Re: Plasma Next alpha release engineering bits

2014-03-06 Thread Sebastian Kügler
On Thursday, March 06, 2014 10:49:21 Jos Poortvliet wrote: On Wednesday 05 March 2014 13:10:12 Sebastian Kügler wrote: As we're planning to release the first alpha of Plasma Next next week, I'd like to go over some details that need discussing. - promo preparations You want the same

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote: After going to playlist like this, if you press back you get a blank screen with Loading spinner. Expected is the homescreen to come back. Ashish Madeti wrote: 1.Start PMC 2.Click on empty area (playlist shows) 3.Click

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52240 --- Is the ttf's the sources of the fonts? We shouldn't

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Sebastian Kügler
On March 6, 2014, 11:34 a.m., Aleix Pol Gonzalez wrote: Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? OTOH, I would say it's fine installing the font from frameworks integration, although it makes little difference since frameworks integration will be

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Martin Gräßlin
On March 6, 2014, 12:34 p.m., Aleix Pol Gonzalez wrote: Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? OTOH, I would say it's fine installing the font from frameworks integration, although it makes little difference since frameworks integration will be

Re: Review Request 116625: Oxygen as default font

2014-03-06 Thread Aleix Pol Gonzalez
On March 6, 2014, 11:34 a.m., Aleix Pol Gonzalez wrote: Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? OTOH, I would say it's fine installing the font from frameworks integration, although it makes little difference since frameworks integration will be

Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- Review request for Plasma and Àlex Fiestas. Repository:

Re: Oxygen as default font

2014-03-06 Thread Rex Dieter
Sebastian Kügler wrote: On Wednesday, March 05, 2014 13:34:36 Jonathan Riddell wrote: it may be easiest to just release oxygen font separately and have it as a build depends of kde-runtime, that way people who install kde-runtime into something other than /usr can just install the package.

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review52255 --- How will this work with other non KDE apps (like Chrome),

Re: Plasma Next alpha release engineering bits

2014-03-06 Thread Sebastian Kügler
On Thursday, March 06, 2014 15:12:32 Jos Poortvliet wrote: On Thursday 06 March 2014 11:32:03 Sebastian Kügler wrote: On Thursday, March 06, 2014 10:49:21 Jos Poortvliet wrote: On Wednesday 05 March 2014 13:10:12 Sebastian Kügler wrote: You want the same as for the Frameworks

Re: Oxygen as default font

2014-03-06 Thread Sebastian Kügler
On Thursday, March 06, 2014 06:23:59 Rex Dieter wrote: On Wednesday, March 05, 2014 13:34:36 Jonathan Riddell wrote: it may be easiest to just release oxygen font separately and have it as a build depends of kde-runtime, that way people who install kde-runtime into something other than

Re: Review Request 116626: Fix for Bug 325012 - Playlist reordering works only in one direction

2014-03-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116626/#review52258 --- This review has been submitted with commit

Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first

2014-03-06 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/ --- (Updated March 6, 2014, 2:22 p.m.) Status -- This change has been

Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first

2014-03-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116596/#review52260 --- This review has been submitted with commit

Re: Review Request 116596: Fix for Bug 329168 - It is impossible to remove a media from playlist without playing it first

2014-03-06 Thread Ashish Madeti
On March 6, 2014, 2:23 p.m., Shantanu Tushar wrote: I have merged this to master. Please note, please fill the bug field in reviewboard from the next time when you're fixing a bug. I will definitely keep that in mind from next time. Thank you very much for helping me in fixing the bug.

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review52266 --- shells/newshell/package/contents/ui/mediacenter.qml

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote: After going to playlist like this, if you press back you get a blank screen with Loading spinner. Expected is the homescreen to come back. Ashish Madeti wrote: 1.Start PMC 2.Click on empty area (playlist shows) 3.Click

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Martin Gräßlin
On March 6, 2014, 2:55 p.m., Mark Gaiser wrote: How will this work with other non KDE apps (like Chrome), will they simply pickup the Oxygen font? I'm asking because fonts are working just fine now. If i open a GTK app in KDE it shows the fonts in the same manner as a KDE app would

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Aleix Pol Gonzalez
On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: How will this work with other non KDE apps (like Chrome), will they simply pickup the Oxygen font? I'm asking because fonts are working just fine now. If i open a GTK app in KDE it shows the fonts in the same manner as a KDE app would

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- (Updated March 6, 2014, 3:40 p.m.) Review request for Plasma and Àlex

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Mark Gaiser
On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: How will this work with other non KDE apps (like Chrome), will they simply pickup the Oxygen font? I'm asking because fonts are working just fine now. If i open a GTK app in KDE it shows the fonts in the same manner as a KDE app would

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- (Updated March 6, 2014, 3:49 p.m.) Review request for Plasma and Àlex

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- (Updated March 6, 2014, 4:17 p.m.) Review request for Plasma, Akshay

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
On March 6, 2014, 4:22 p.m., Martin Gräßlin wrote: will push that once this patch is through review shouldn't it be the other way around? How would anyone be able to compile test your review without those files in the oxygen fonts repo? Right. I've pushed it to oxygen-fonts. -

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- (Updated March 6, 2014, 4:36 p.m.) Review request for Plasma and Àlex

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
On Thursday, March 06, 2014 15:45:23 Mark Gaiser wrote: @Aleix not a strong argument. GUI interfaces almost always use the default font settings. My exact point is that those defaults _won't_ change for GTK apps with this patch. It does for GTK Apps using the Oxygen style, and it also can be

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Àlex Fiestas
On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: How will this work with other non KDE apps (like Chrome), will they simply pickup the Oxygen font? I'm asking because fonts are working just fine now. If i open a GTK app in KDE it shows the fonts in the same manner as a KDE app would

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Àlex Fiestas
On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: How will this work with other non KDE apps (like Chrome), will they simply pickup the Oxygen font? I'm asking because fonts are working just fine now. If i open a GTK app in KDE it shows the fonts in the same manner as a KDE app would

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review52285 --- Ship it! Ship It! - Shantanu Tushar On March 6, 2014,

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- (Updated March 6, 2014, 5:43 p.m.) Status -- This change has been

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review52286 --- This review has been submitted with commit

Review Request 116640: Fix for Bug 331798 - Wrong media shown as current media in playlist after reordering

2014-03-06 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116640/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs:

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: How will this work with other non KDE apps (like Chrome), will they simply pickup the Oxygen font? I'm asking because fonts are working just fine now. If i open a GTK app in KDE it shows the fonts in the same manner as a KDE app would

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Aleix Pol Gonzalez
On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: How will this work with other non KDE apps (like Chrome), will they simply pickup the Oxygen font? I'm asking because fonts are working just fine now. If i open a GTK app in KDE it shows the fonts in the same manner as a KDE app would