Re: Review Request 116824: Implementation of Single time addition on multiple clicks of the Play All button

2014-03-16 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/ --- (Updated March 16, 2014, 6:09 a.m.) Status -- This change has been

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-16 Thread Shantanu Tushar
On March 15, 2014, 7:44 p.m., Shantanu Tushar wrote: browsingbackends/localfiles/localfilesabstractbackend.cpp, line 169 https://git.reviewboard.kde.org/r/116554/diff/2/?file=254194#file254194line169 0 won't work when there are already some itmes in the playlist before

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-16 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 9:30 a.m.) Review request for Plasma, Akshay

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-16 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 10:29 a.m.) Review request for Plasma, Akshay

Alpha delayed

2014-03-16 Thread Sebastian Kügler
Hey, We've looked over what would be needed to tag Plasma Next Alpha1 this week, and found it not feasible due to too much moving code. Please refer to the reasoning in my email subj: Delaying the Alpha1?. The plan is to get missing stuff in right now, and tag Plasma Next Alpha 1 shortly

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-16 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53040 --- browsingbackends/localfiles/localfilesabstractbackend.cpp

Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

2014-03-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/ --- Review request for Plasma and Sebastian Kügler. Repository:

Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

2014-03-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116836/#review53066 --- Overall, good idea. I just noticed this the other day that

Re: Review Request 106118: Plasmate: Add KWin Scripting support to konsolepreviewer.

2014-03-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106118/#review53068 --- Please either commit or discard or mark as committed,

Meta key and Qt (Re: kglobalaccel fixes)

2014-03-16 Thread David Faure
On Tuesday 11 March 2014 13:54:56 Sebastian Kügler wrote: One thing is a bit puzzling, perhaps someone knows how to go about this: The meta key behaves different now, when I edit a shortcut, it's accepted as soon as I press the meta key, so it's not seen as a modifier, but as a key of its

Re: Review Request 116836: Let search results list expand to full height (since tabbar is hidden then)

2014-03-16 Thread Kai Uwe Broulik
On March 16, 2014, 4:11 p.m., Sebastian Kügler wrote: plasma/desktop/applets/kickoff/package/contents/ui/Kickoff.qml, line 185 https://git.reviewboard.kde.org/r/116836/diff/1/?file=254503#file254503line185 This is going to raise a warning b/c you're assigning undefined to an int,

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/ --- (Updated March 16, 2014, 10:20 p.m.) Review request for Plasma and Àlex

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-16 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 16, 2014, 10:08 p.m.) Review request for Plasma, Akshay

Re: Testing a plasmoid with local installation / solved

2014-03-16 Thread Gregor Mi
SOLVED. By issuing this command... export KDEDIRS=$DEVUSR:`kde4-config --prefix` ...the local version of the plasmoid is used. It is the third option given by the tutorial [1], section Testing the Applet. Gregor [1] http://techbase.kde.org/Development/Tutorials/Plasma/GettingStarted On