Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

2014-05-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118214/ --- Review request for Plasma and David Edmundson. Repository:

Re: Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

2014-05-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118214/#review58188 --- Why? - David Edmundson On May 20, 2014, 10:12 a.m., Martin

Re: Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

2014-05-20 Thread Martin Gräßlin
On May 20, 2014, 12:15 p.m., David Edmundson wrote: Why? main reason: I noticed that KSLD and greeter and not in sync. E.g. I was seeing the lock ui but moving the mouse unlocked the screen. - Martin --- This is an automatically

Re: High DPI issues

2014-05-20 Thread Teo Mrnjavac
On Monday, May 19, 2014 15:07:24 David Edmundson wrote: On Mon, May 19, 2014 at 2:48 PM, Teo Mrnjavac t...@kde.org wrote: On Monday, May 19, 2014 14:40:59 David Edmundson wrote: Read this before doing anything: http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-o s-i

Re: Review Request 118094: Sort screens in plasma from left to right

2014-05-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118094/ --- (Updated May 20, 2014, 2:39 p.m.) Status -- This change has been

Re: High DPI issues

2014-05-20 Thread Teo Mrnjavac
On Tuesday, May 20, 2014 14:55:16 David Edmundson wrote: On Tue, May 20, 2014 at 2:28 PM, Teo Mrnjavac t...@kde.org wrote: Hello, I've had a chat with Morten Johan Sørvig, the person behind the high DPI effort in Qt. What follows is a status report. The work on high DPI support

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

2014-05-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118205/#review58196 --- I quite like the idea. Some comments below.

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

2014-05-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118205/ --- (Updated May 20, 2014, 4:17 p.m.) Review request for Plasma. Changes

Re: RFC: Change Krunner's default key shortcut for Next

2014-05-20 Thread Jacopo De Simoi
Currently the secondary shortcut is set to Alt + Shift + F2. I don't think any of us will miss this. Actually this opens krunner with the content of the clipboard as the search term; quite handy sometimes. Is this change going to break this behavior? __J

Re: RFC: Change Krunner's default key shortcut for Next

2014-05-20 Thread Martin Klapetek
On Tue, May 20, 2014 at 4:29 PM, Jacopo De Simoi wilder...@gmail.comwrote: Currently the secondary shortcut is set to Alt + Shift + F2. I don't think any of us will miss this. Actually this opens krunner with the content of the clipboard as the search term; quite handy sometimes. Is

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-20 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/ --- (Updated May 20, 2014, 4:56 p.m.) Review request for Plasma. Changes

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-20 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954/#review58199 --- You probably need to check in CMakeLists.txt that version of

Icons for Paste Bin and Paste

2014-05-20 Thread Jens Reuterberg
One user in conversation with Uri noticed/reminded us that the icons for the plasmoid/widgets Paste and Pastebin are identical (which isn't an issue as much as they do essentially the same thing although it would be nice if they used different icons) but even more problematic, the icon they do

Re: Icons for Paste Bin and Paste

2014-05-20 Thread Ivan Čukić
The issue is a bit broader. 1. There are a few whose icons are overlapping (my favourite is an icon with an analogue clock on the digital clock applet :) ) 2. All applet icons are coloured. Cheerio, Ivan On 20 May 2014 18:42, Jens Reuterberg j...@ohyran.se wrote: One user in conversation

Re: Icons for Paste Bin and Paste

2014-05-20 Thread Marco Martin
On Tuesday 20 May 2014, Jens Reuterberg wrote: One user in conversation with Uri noticed/reminded us that the icons for the plasmoid/widgets Paste and Pastebin are identical (which isn't an issue as much as they do essentially the same thing although it would be nice if they used different

Re: Icons for Paste Bin and Paste

2014-05-20 Thread Marco Martin
On Tuesday 20 May 2014, Ivan Čukić wrote: The issue is a bit broader. 1. There are a few whose icons are overlapping (my favourite is an icon with an analogue clock on the digital clock applet :) ) hmm, if we provide a list of applets that have this problem, could the vdg do icons for them?

Re: Icons for Paste Bin and Paste

2014-05-20 Thread Ivan Čukić
if the vdg thinks that the share applet should be monochrome in the UI, this can be done: * do an icon for it in the png icon theme, colored and all Oh, the applet is coloured in UI... ok, that *is* bad :) -- Those people who think they know everything are a great annoyance to those of us

Re: Icons for Paste Bin and Paste

2014-05-20 Thread Thomas Pfeiffer
On Tuesday 20 May 2014 19:00:08 Marco Martin wrote: 2. All applet icons are coloured. if the vdg thinks that the share applet should be monochrome in the UI, this can be done: * do an icon for it in the png icon theme, colored and all * same name, monochrome and svg version in the plasma

Re: Review Request 116633: Change default font settings to Oxygen font

2014-05-20 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review58203 --- src/platformtheme/kfontsettingsdata.cpp

Re: Icons for Paste Bin and Paste

2014-05-20 Thread Jens Reuterberg
I'm on it will contact Uri, I know he's busy but I have a nasty work day tomorrow so one little icon wont hurt. Also as an aside: as you all got on your own (and I forgot to write, sry everyone) was that since its in the panel and not an application icon the actual icon should be monochrome.

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

2014-05-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118205/#review58212 --- Ship it! Looks good from my POV.

Re: Review Request 112208: KMix qml applet

2014-05-20 Thread Diego Casella
On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: Is there still an intention on getting this in KDE 4.xx? Just wondering since it seems to be much better then the current kmix popup. Christian Esken wrote: I also haven't heard about further development here. Diego as original