Then just leave the bomb? We probably have more important issues than this.
No, we don't. It may seem really silly and tiny (I completely agree, I don't
even understand why the icon is there - but as Martin said, every window has
an icon). But these are the things that add up. If we don't
Hi,
That bomb icon imho doesn't look very well in the titlebar and the app icon
indeed is confusing. What about dialog-warning to emphasis even more that it
will cause your changes do be lost? It's already in the dialog itself, however,
but will make the window stick out in the taskbar.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118361/#review58624
---
Ship it!
not sure if is safe to assume to not close when any
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117954/
---
(Updated May 28, 2014, 8:55 a.m.)
Status
--
This change has been
On May 28, 2014, 12:38 a.m., David Edmundson wrote:
That's frickin' clever!
We can remove a lot of hacks thanks to this.
Do we even need the last clause? Surely any child window shouldn't close
the parent?
You mean the QMenuClassWindow part? It's a bit tricky opening a QMenu from
On May 27, 2014, 8:36 p.m., Kai Uwe Broulik wrote:
src/plasmaquick/dialog.cpp, line 800
https://git.reviewboard.kde.org/r/118361/diff/1/?file=275561#file275561line800
Isn't comparison more efficient using QLatin1String?
Martin Klapetek wrote:
Last time I've heard it's not
On May 27, 2014, 10:36 p.m., Kai Uwe Broulik wrote:
src/plasmaquick/dialog.cpp, line 800
https://git.reviewboard.kde.org/r/118361/diff/1/?file=275561#file275561line800
Isn't comparison more efficient using QLatin1String?
Martin Klapetek wrote:
Last time I've heard it's not
On May 27, 2014, 10:36 p.m., Kai Uwe Broulik wrote:
src/plasmaquick/dialog.cpp, line 800
https://git.reviewboard.kde.org/r/118361/diff/1/?file=275561#file275561line800
Isn't comparison more efficient using QLatin1String?
Martin Klapetek wrote:
Last time I've heard it's not
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118361/
---
(Updated May 28, 2014, 10:04 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118361/#review58636
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118367/#review58638
---
Ship it!
Ship It!
- Marco Martin
On May 28, 2014, 5:31
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118367/
---
(Updated May 28, 2014, 10:32 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118367/#review58641
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118373/
---
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118373/#review58643
---
Ship it!
Yes, it doesn't make much sense to delete it only
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118373/
---
(Updated May 28, 2014, 10:55 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118373/#review58646
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109160/
---
(Updated May 28, 2014, 12:32 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118376/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118376/
---
(Updated May 28, 2014, 1:37 p.m.)
Review request for Plasma.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118376/#review58673
---
Ship it!
Ship It!
- Marco Martin
On May 28, 2014, 1:37
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118376/#review58675
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118376/
---
(Updated May 28, 2014, 2:24 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118381/
---
Review request for Plasma and Johannes Huber.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118382/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118386/
---
Review request for Plasma and Vishesh Handa.
Repository: milou
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118387/
---
Review request for Plasma and Ben Cooksley.
Repository: systemsettings
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118388/
---
Review request for Plasma and Ben Cooksley.
Repository: systemsettings
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118381/#review58688
---
Ship it!
Ship It!
- Johannes Huber
On May 28, 2014, 4:49
On May 28, 2014, 11:16 p.m., Johannes Huber wrote:
Ship It!
Good job. Compiled with and without prison. Quick runtime test: OK.
- Johannes
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/
---
Review request for Plasma, Solid and KDE Usability.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/
---
(Updated May 28, 2014, 11:33 p.m.)
Review request for Plasma, Solid and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/
---
(Updated May 28, 2014, 11:32 p.m.)
Review request for Plasma, Solid and
33 matches
Mail list logo
