Re: Review Request 118388: rename systemsettings binary to systemsettings5

2014-06-03 Thread Ben Cooksley
On May 29, 2014, 7:10 a.m., Ben Cooksley wrote: Code wise, this change looks fine. In terms of renaming the desktop files - i'm fine with changing the filenames, but please don't change the name of the application itself. Ideally the KF5 based system settings will still be able to

Re: Review Request 118388: rename systemsettings binary to systemsettings5

2014-06-03 Thread Martin Gräßlin
On May 29, 2014, 9:10 a.m., Ben Cooksley wrote: Code wise, this change looks fine. In terms of renaming the desktop files - i'm fine with changing the filenames, but please don't change the name of the application itself. Ideally the KF5 based system settings will still be able to

Re: Review Request 118038: Bring back a KCM for the screen locker

2014-06-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118038/ --- (Updated June 3, 2014, 8:53 a.m.) Review request for Plasma and Thomas

Re: Review Request 115870: The plasma-media center displays the time in AM between 12 noon and 1pm.

2014-06-03 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115870/ --- (Updated June 3, 2014, 8:16 a.m.) Status -- This change has been

Re: Review Request 115870: The plasma-media center displays the time in AM between 12 noon and 1pm.

2014-06-03 Thread R.Harish Navnit
Sorry about that. I've reopened it and submitted it as discarded since. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com On Tue, Jun 3, 2014 at 1:46 PM, R.Harish Navnit harishnav...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit:

Re: Review Request 118388: rename systemsettings binary to systemsettings5

2014-06-03 Thread Ben Cooksley
On May 29, 2014, 7:10 a.m., Ben Cooksley wrote: Code wise, this change looks fine. In terms of renaming the desktop files - i'm fine with changing the filenames, but please don't change the name of the application itself. Ideally the KF5 based system settings will still be able to

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-03 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review59054 --- Ship it! Unless I've missed something, it's all fine from my

[plasmashell] [Bug 328593] Dual screen has regressed in plasma-shell

2014-06-03 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=328593 Marco Martin notm...@gmail.com changed: What|Removed |Added Depends on||335710 -- You are receiving

[plasmashell] [Bug 328593] Dual screen has regressed in plasma-shell

2014-06-03 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 335710, which changed state. Bug 335710 Summary: Plasma shell randomly swaps screen panels on login https://bugs.kde.org/show_bug.cgi?id=335710 What|Removed |Added

Re: Review Request 118487: fix type issue with qreal

2014-06-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59065 --- if you want to enforce to use the same type on all, you can

Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralHandlingSpinBox

2014-06-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review59070 --- Ship it! KPluralAwareSpinBox seemed a bit better name to me

Re: Review Request 118487: fix type issue with qreal

2014-06-03 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 12:06 p.m.) Review request for Plasma. Changes

Re: Review Request 118487: fix type issue with qreal

2014-06-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59081 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 3, 2014,

Re: Review Request 118487: fix type issue with qreal

2014-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59084 --- This review has been submitted with commit

Re: Review Request 118487: fix type issue with qreal

2014-06-03 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 12:37 p.m.) Status -- This change has been

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

2014-06-03 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/ --- (Updated June 3, 2014, 3:22 p.m.) Review request for Plasma and Martin

Re: Review Request 118038: Bring back a KCM for the screen locker

2014-06-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118038/#review59091 --- Ship it! Small issue in the Comment of the .desktop file,

Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralHandlingSpinBox

2014-06-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review59092 --- FWIW feature report in Qt just got closed as wontfix

Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralHandlingSpinBox

2014-06-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review59093 --- FWIW feature report in Qt just got closed as wontfix

Jenkins build is back to normal : plasma-workspace_master_qt5 #339

2014-06-03 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/339/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #340

2014-06-03 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/340/ -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review59097 --- This review has been submitted with commit

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated June 3, 2014, 3:32 p.m.) Status -- This change has been

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-03 Thread David Edmundson
On June 2, 2014, 4:26 p.m., Andrew Lake wrote: The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y,

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

2014-06-03 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/ --- (Updated June 3, 2014, 5:05 p.m.) Review request for Plasma, Shantanu

Jenkins build is back to normal : plasma-workspace_master_qt5 #341

2014-06-03 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/341/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118506: Plasma Active: Adjust the image package for the Plasma Active

2014-06-03 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118506/ --- Review request for Plasma. Repository: plasma-workspace Description

[plasmashell] [Bug 328593] Dual screen has regressed in plasma-shell

2014-06-03 Thread Luiz Angelo De Luca
https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 335710, which changed state. Bug 335710 Summary: Plasma shell randomly swaps screen panels on login https://bugs.kde.org/show_bug.cgi?id=335710 What|Removed |Added