Review Request 118583: Fix Comic Strip Installation

2014-06-06 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118583/ --- Review request for Plasma. Bugs: 325028

Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/ --- Review request for Plasma, John Layt and Sebastian Kügler. Repository:

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/ --- (Updated June 6, 2014, 6:45 a.m.) Review request for Plasma, John Layt

Re: Review Request 118573: Some tweaks in the logout screen

2014-06-06 Thread Marco Martin
On June 5, 2014, 10:23 p.m., Aleix Pol Gonzalez wrote: ksmserver/shutdowndlg.cpp, line 85 https://git.reviewboard.kde.org/r/118573/diff/1/?file=279220#file279220line85 I'm unsure what's the issue here. Martin Gräßlin wrote: this might break the logout effect Seems it works

Re: Review Request 118573: Some tweaks in the logout screen

2014-06-06 Thread Martin Gräßlin
On June 6, 2014, 12:23 a.m., Aleix Pol Gonzalez wrote: ksmserver/shutdowndlg.cpp, line 85 https://git.reviewboard.kde.org/r/118573/diff/1/?file=279220#file279220line85 I'm unsure what's the issue here. Martin Gräßlin wrote: this might break the logout effect Marco Martin

Re: Plasma 5 Beta 2 tars

2014-06-06 Thread kde
Zitat von Martin Gräßlin mgraess...@kde.org: can we revert that change in plasma-workspace for the release? I would not want to go back further as plasma-workspace also has quite some changes which would be good to be tested. E.g. the new lockscreen UI. Hi, okay, go ahead and revert till

Re: Plasma 5 Beta 2 tars

2014-06-06 Thread Jonathan Riddell
On Fri, Jun 06, 2014 at 11:11:05AM +0200, Mario Fux wrote: Why appending some packages with -kf5 and some with 5? Seems quite confusing. And baloo and milou are not really (or not yet for baloo) KDE Frameworks. See if it all they should be appended with a 5 and the term kf5 should be kept

Re: Review Request 118573: Some tweaks in the logout screen

2014-06-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118573/ --- (Updated June 6, 2014, 9:37 a.m.) Review request for Plasma. Changes

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59397 --- Ship it! Ship It! - Lukáš Tinkl On June 6, 2014, 8:45

Re: Plasma 5 Beta 2 tars

2014-06-06 Thread Jonathan Riddell
New tars up at http://starsky.19inch.net/~jr/tmp/plasma-4.97.0/ changes: plasma-workspace has changed API commit reverted milou-kf5 tar now milou baloo-kf5 tar now baloo5 oxygen-fonts now using correct branch

Plasma 5 branding

2014-06-06 Thread Jonathan Riddell
A decision needs to be made on Plasma branding because we are now a month away from release. I plan to use Plasma 5 for the generation of Plasma using KDE Frameworks 5. For technical numbers I'm using 4.97.0 for this beta and plan to release 5.0.0 in July. Following releases will be 5.0.90

Re: Review Request 118573: Some tweaks in the logout screen

2014-06-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118573/ --- (Updated June 6, 2014, 10:07 a.m.) Review request for Plasma. Changes

Re: Review Request 118573: Some tweaks in the logout screen

2014-06-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118573/#review59401 --- Ok, +1 from me, I'm not giving a shipit because I see

Re: Plasma 5 branding

2014-06-06 Thread Sebastian Kügler
On Friday, June 06, 2014 11:04:09 Jonathan Riddell wrote: A decision needs to be made on Plasma branding because we are now a month away from release. I plan to use Plasma 5 for the generation of Plasma using KDE Frameworks 5. For technical numbers I'm using 4.97.0 for this beta and plan

Re: Review Request 118583: Fix Comic Strip Installation

2014-06-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118583/#review59404 --- Ship it! Ship It! - Sebastian Kügler On June 6, 2014,

Jenkins build is back to normal : plasma-workspace_master_qt5 #368

2014-06-06 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/368/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 Beta 2 tars

2014-06-06 Thread šumski
On Friday 06 of June 2014 07:33:09 Martin Gräßlin wrote: On Thursday 05 June 2014 20:19:55 šumski wrote: On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: Tars are up for Plasma 5 Beta 2, please try them out and let me know of problems. I'd especially like to know if

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59407 --- I'd like to hear John's take on this. IIRC, bcp47Name() is

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

2014-06-06 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/#review59409 --- I think you'll have to argue this out with vishesh, on

Re: Plasma 5 branding

2014-06-06 Thread Jonathan Riddell
On Fri, Jun 06, 2014 at 12:33:43PM +0200, Sebastian Kügler wrote: That leaves the marketing release names. My best idea is Summer 2014 etc so this release will be the Plasma 5 Summer 2014 release. This may annoy our antipodean and south american users however. Suggestions welcome but we

Re: Plasma 5 branding

2014-06-06 Thread Jens
I'd like to talk a bit about HOW we are to release and brand it. Seriously the discussion has been around version names and very little about promo and branding. I mean we can set it up but I would like to know that it would be used before I start pulling people away. On Friday 06 June 2014

Re: Re: Plasma 5 branding

2014-06-06 Thread Martin Gräßlin
On Friday 06 June 2014 12:07:06 Jonathan Riddell wrote: On Fri, Jun 06, 2014 at 12:33:43PM +0200, Sebastian Kügler wrote: That leaves the marketing release names. My best idea is Summer 2014 etc so this release will be the Plasma 5 Summer 2014 release. This may annoy our antipodean and

Re: Plasma 5 branding

2014-06-06 Thread Jonathan Riddell
On Fri, Jun 06, 2014 at 01:18:09PM +0200, Martin Gräßlin wrote: why would the headline need a version number? We need some way to distinguish this release from the following release for users. We need something to put in the headline. Jonathan ___

Re: Review Request 118573: Some tweaks in the logout screen

2014-06-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118573/ --- (Updated June 6, 2014, 11:31 a.m.) Status -- This change has been

Re: Re: Plasma 5 branding

2014-06-06 Thread Martin Gräßlin
On Friday 06 June 2014 12:25:55 Jonathan Riddell wrote: On Fri, Jun 06, 2014 at 01:18:09PM +0200, Martin Gräßlin wrote: why would the headline need a version number? We need some way to distinguish this release from the following release for users. We need something to put in the headline.

Re: Review Request 118583: Fix Comic Strip Installation

2014-06-06 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118583/ --- (Updated June 6, 2014, 11:50 a.m.) Status -- This change has been

Re: Review Request 118583: Fix Comic Strip Installation

2014-06-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118583/#review59419 --- This review has been submitted with commit

Re: Plasma 5 branding

2014-06-06 Thread Sebastian Kügler
On Friday, June 06, 2014 12:07:06 Jonathan Riddell wrote: On Fri, Jun 06, 2014 at 12:33:43PM +0200, Sebastian Kügler wrote: That leaves the marketing release names. My best idea is Summer 2014 etc so this release will be the Plasma 5 Summer 2014 release. This may annoy our antipodean

Review Request 118591: Restore the freefloating config option in krunner

2014-06-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118591/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Plasma 5 Beta 2 tars

2014-06-06 Thread šumski
On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: Tars are up for Plasma 5 Beta 2, please try them out and let me know of problems. I'd especially like to know if translations successfully install as I noticed some not doing so last time. khotkeys also don't build, they have one

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
On June 6, 2014, 10:53 a.m., Sebastian Kügler wrote: I'd like to hear John's take on this. IIRC, bcp47Name() is the correct one to use here. (Which leaves questions indeed.) Indeed. But for some reason, at least on my system, bcp47Name() returns it only, and that breaks everything. Hence

Re: Icons status

2014-06-06 Thread Jens
Dito! +1 On Thursday 05 June 2014 22.51.57 Ivan Čukić wrote: Oxygen, that as fallback is the most complete. Both themes would be installed, and oxygen would still be the fallback when an icon is not found for the time being +1 for the oxygen + toolbars breeze Cheerio, Ivan

Re: Plasma 5 branding

2014-06-06 Thread Jos Poortvliet
On Friday 06 June 2014 13:58:38 Sebastian Kügler wrote: On Friday, June 06, 2014 12:07:06 Jonathan Riddell wrote: On Fri, Jun 06, 2014 at 12:33:43PM +0200, Sebastian Kügler wrote: That leaves the marketing release names. My best idea is Summer 2014 etc so this release will be the

Re: Plasma 5 branding

2014-06-06 Thread Mario Fux
Am Freitag, 06. Juni 2014, 12.04:09 schrieb Jonathan Riddell: Good morning A decision needs to be made on Plasma branding because we are now a month away from release. I agree absolutely and after a short chat with Jos below is the decision. I plan to use Plasma 5 for the generation of

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread John Layt
On June 6, 2014, 11:53 a.m., Sebastian Kügler wrote: I'd like to hear John's take on this. IIRC, bcp47Name() is the correct one to use here. (Which leaves questions indeed.) Luca Beltrame wrote: Indeed. But for some reason, at least on my system, bcp47Name() returns it only, and

Review Request 118592: Fix Plasma's SNI icons + port away from kdelibs4support

2014-06-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118592/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 118592: Fix Plasma's SNI icons + port away from kdelibs4support

2014-06-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118592/#review59452 --- Ship it! +1 for that - Marco Martin On June 6, 2014, 1:28

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-06 Thread Aleix Pol
On Thu, Jun 5, 2014 at 8:16 PM, Luca Beltrame lbeltr...@kde.org wrote: In data giovedì 05 giugno 2014 00:35:56, Aleix Pol Gonzalez ha scritto: This patch uses the screen geometry to figure out what's the screen and then passes around the screen rect so that we can filter out the screens

[Broken translations] Translation domain names

2014-06-06 Thread Marco Martin
Hi all, unfortunately, when the plugin names of the default plasmoids have ben mass- renamed, some of their messages.sh files were left out. the translations base their default translation domain name (so in the end the name of the .mo file used) from the plugin name. so right now we have some

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-06 Thread Luca Beltrame
In data venerdì 6 giugno 2014 17:22:52, Aleix Pol ha scritto: Just realized that I forgot to submit a patch to plasma-desktop. Without it this had no chance to work. I'll update tonight and check it out. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
In data venerdì 6 giugno 2014 13:14:56, John Layt ha scritto: and script values for Italian and so are unneeded. This compares to name() which will always return the form language_COUNTRY regardless of the locale So do you think it's best to wait, or is this patch an unacceptable /

Re: Review Request 118592: Fix Plasma's SNI icons + port away from kdelibs4support

2014-06-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118592/ --- (Updated June 6, 2014, 4:21 p.m.) Status -- This change has been

Re: Review Request 118592: Fix Plasma's SNI icons + port away from kdelibs4support

2014-06-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118592/#review59462 --- This review has been submitted with commit

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread John Layt
On June 6, 2014, 11:53 a.m., Sebastian Kügler wrote: I'd like to hear John's take on this. IIRC, bcp47Name() is the correct one to use here. (Which leaves questions indeed.) Luca Beltrame wrote: Indeed. But for some reason, at least on my system, bcp47Name() returns it only, and

Icons

2014-06-06 Thread Marco Martin
Hi all, breeze icons have been imported (icons and cursors themes are kept separate, cursors are installed under breeze_cursors for now) As usual, the kconf update script tries to set the breeze icons both on kde4 and kf5, to try to have a coherent look. (there may be a problem for neon, since

Re: Plasma 5 Beta 2 tars

2014-06-06 Thread Eric Hameleers
On Fri, 6 Jun 2014, ?umski wrote: On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: Tars are up for Plasma 5 Beta 2, please try them out and let me know of problems. I'd especially like to know if translations successfully install as I noticed some not doing so last time.

Re: Visual design for logout/login/lockscreen

2014-06-06 Thread Bernd Steinhauser
On 08/04/14 11:58, Jens Reuterberg wrote: Well the issue is that we have to start being careful what gets crammed in and if too much is crammed in how to hide it away. The point is that too many options visible would be problematic since the main point of a login is to have a place to pick user

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-06 Thread Luca Beltrame
In data venerdì 06 giugno 2014 17:22:52, Aleix Pol ha scritto: Can you give it another try? Now works perfectly. Thanks! -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 signature.asc Description: This is a digitally signed message part.

Re: Plasma 5 Beta 2 tars

2014-06-06 Thread šumski
On Friday 06 of June 2014 21:32:48 Eric Hameleers wrote: On Fri, 6 Jun 2014, ?umski wrote: On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: Tars are up for Plasma 5 Beta 2, please try them out and let me know of problems. I'd especially like to know if translations successfully

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59477 --- Ship it! Ship It! - Sebastian Kügler On June 6, 2014,

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59478 --- This review has been submitted with commit

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/ --- (Updated June 6, 2014, 9:43 p.m.) Status -- This change has been