---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118251/#review59743
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118251/
---
(Updated June 11, 2014, 5:59 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118659/
---
Review request for Plasma.
Repository: plasma-workspace
Description
On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote:
Usability review:
Since I lack the skills to picture it from the diff: When exactly is the
notification shown? Is it shown as soon as the media is supposed to be
played? If so, I think it could be done in a more subtle way: Grey out
On June 2, 2014, 5:05 p.m., Shantanu Tushar wrote:
Hmm, looks good to me.
If this is fine, can this change be committed on my behalf ?
Thanks.
- R.Harish
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118661/
---
Review request for Plasma.
Repository: plasma-desktop
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118662/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118661/#review59752
---
If you do this we need checks around building everything that
On June 11, 2014, 11 a.m., David Edmundson wrote:
If you do this we need checks around building everything that tries to link
against it otherwise you get mystery compile fails.
There's 2 applets and 9 KCMs
they should already have these checks otherwise the check for X11 is kind of
On June 11, 2014, 9 a.m., David Edmundson wrote:
If you do this we need checks around building everything that tries to link
against it otherwise you get mystery compile fails.
There's 2 applets and 9 KCMs
Martin Gräßlin wrote:
they should already have these checks otherwise the
On June 11, 2014, 11 a.m., David Edmundson wrote:
If you do this we need checks around building everything that tries to link
against it otherwise you get mystery compile fails.
There's 2 applets and 9 KCMs
Martin Gräßlin wrote:
they should already have these checks otherwise the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118659/#review59764
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 11, 2014,
Hi all!
The review request [1] raised the question whether it makes sense that we have
any support for building without X11 support. Right now the build without X11
is broken, nevertheless there are many checks of the kind
if(NOT WIN32)
or
#if defined(Q_OS_UNIX) !defined(Q_OS_MAC)
Also we
On Wednesday 11 June 2014, Martin Gräßlin wrote:
Hi all!
The review request [1] raised the question whether it makes sense that we
have any support for building without X11 support. Right now the build
without X11 is broken, nevertheless there are many checks of the kind
if(NOT WIN32)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118512/#review59771
---
How about we change the cmake file to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118659/#review59772
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118659/
---
(Updated June 11, 2014, 11:06 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118665/
---
Review request for Plasma.
Repository: oxygen
Description
---
On June 11, 2014, 11 a.m., Vishesh Handa wrote:
How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead?
This way there will be no conflicts, and it will be consistent with the
rest of the frameworks as well?
I agree it's the best way, the only problem being tha it's
Hey guys
As an effort to modularize Baloo and make it more into a framework, I'm
going to be moving certain parts of it into the workspace.
baloo/src/runner - plasma-workspace/runners
baloo/src/kioslaves - plasma-workspace/kioslaves
baloo/src/file/kcm - plasma-desktop/kcm
This will obviously
On Wed, Jun 11, 2014 at 3:28 PM, Vishesh Handa m...@vhanda.in wrote:
Hey guys
As an effort to modularize Baloo and make it more into a framework, I'm
going to be moving certain parts of it into the workspace.
baloo/src/runner - plasma-workspace/runners
baloo/src/kioslaves -
On Wednesday 11 June 2014 15:30:17 Aleix Pol wrote:
On Wed, Jun 11, 2014 at 3:28 PM, Vishesh Handa m...@vhanda.in wrote:
Hey guys
As an effort to modularize Baloo and make it more into a framework, I'm
going to be moving certain parts of it into the workspace.
baloo/src/runner -
On June 11, 2014, 11 a.m., Vishesh Handa wrote:
How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead?
This way there will be no conflicts, and it will be consistent with the
rest of the frameworks as well?
Aleix Pol Gonzalez wrote:
I agree it's the best
On June 11, 2014, 11 a.m., Vishesh Handa wrote:
How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead?
This way there will be no conflicts, and it will be consistent with the
rest of the frameworks as well?
Aleix Pol Gonzalez wrote:
I agree it's the best
On Wednesday 11 June 2014, Aleix Pol wrote:
If anyone has any objections please speak up. I'll do the move on Monday.
--
Vishesh Handa
___
Plasma-devel mailing list
Plasma-devel@kde.org
On Wed, Jun 11, 2014 at 3:30 PM, Aleix Pol aleix...@kde.org wrote:
Doesn't that tie Baloo usage to exclusively Plasma? If you want it to be a
framework, won't framework users need to configure the things in the KCM?
Hmm, you have a point.
I was only thinking about it from a non-kde point of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118512/#review59795
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 4, 2014,
On June 11, 2014, 1:51 p.m., Aleix Pol Gonzalez wrote:
Ship It!
Uhh. Currently the patch renames it to KFileMetaData5 instead of
KF5::FileMetaData. We want the one with the KF5, not this on.
- Vishesh
---
This is an automatically
See http://build.kde.org/job/plasma-workspace_master_qt5/397/changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Wednesday, 2014-06-11, 15:43:34, Vishesh Handa wrote:
On Wed, Jun 11, 2014 at 3:30 PM, Aleix Pol aleix...@kde.org wrote:
Doesn't that tie Baloo usage to exclusively Plasma? If you want it to be a
framework, won't framework users need to configure the things in the KCM?
Hmm, you have a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118468/
---
(Updated June 11, 2014, 2:27 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118468/#review59801
---
This review has been submitted with commit
On June 11, 2014, 1:51 p.m., Aleix Pol Gonzalez wrote:
Ship It!
Vishesh Handa wrote:
Uhh. Currently the patch renames it to KFileMetaData5 instead of
KF5::FileMetaData. We want the one with the KF5, not this on.
Heh true :$.
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118668/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118669/
---
Review request for Plasma.
Repository: plasma-framework
Description
On June 11, 2014, 7 a.m., Vishesh Handa wrote:
How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead?
This way there will be no conflicts, and it will be consistent with the
rest of the frameworks as well?
Aleix Pol Gonzalez wrote:
I agree it's the best way,
[CC:ing frameworks-devel, hoping for additional input]
On Friday, June 06, 2014 23:24:50 šumski wrote:
On Friday 06 of June 2014 21:32:48 Eric Hameleers wrote:
On Fri, 6 Jun 2014, ?umski wrote:
On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote:
Tars are up for Plasma 5 Beta 2,
On June 9, 2014, 1:21 p.m., Eike Hein wrote:
If you rename the .desktop files, please remember to update the default
favorites configurations in Kicker (it's in the main.xml of the package)
and Kickoff (somewhere in C++ model code) since they both reference System
Settings by
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118669/#review59809
---
Ship it!
should be fine
- Marco Martin
On June 11, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118388/#review59811
---
One other thing that conflicts between the two versions is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118669/
---
(Updated June 11, 2014, 3:17 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118669/#review59812
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118148/
---
(Updated June 11, 2014, 4:18 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118148/#review59814
---
This review has been submitted with commit
On June 11, 2014, 5:17 p.m., Matthew Dawson wrote:
One other thing that conflicts between the two versions is the
systemsettings view library. I think just a soname bump is enough to
handle it.
see r118387 =)
- Hrvoje
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118657/#review59816
---
Ship it!
Ship It!
- Shantanu Tushar
On June 11, 2014,
See http://build.kde.org/job/plasma-workspace_master_qt5/398/changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On June 11, 2014, 11 a.m., Vishesh Handa wrote:
How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead?
This way there will be no conflicts, and it will be consistent with the
rest of the frameworks as well?
Aleix Pol Gonzalez wrote:
I agree it's the best
On Wednesday 11 June 2014 15:43:34 Vishesh Handa wrote:
On Wed, Jun 11, 2014 at 3:30 PM, Aleix Pol aleix...@kde.org wrote:
Doesn't that tie Baloo usage to exclusively Plasma? If you want it to be a
framework, won't framework users need to configure the things in the KCM?
Hmm, you have a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115431/#review59821
---
Tested this out a bit today... and it didn't seem to work all
On June 11, 2014, 6:18 p.m., Rex Dieter wrote:
Tested this out a bit today... and it didn't seem to work all that well.
Did seem to result in too much whitespace at times, and was fairly easy to
get plasma into a state where it would endlessly try to resize things to
fit. Helped a
On June 11, 2014, 6:18 p.m., Rex Dieter wrote:
Tested this out a bit today... and it didn't seem to work all that well.
Did seem to result in too much whitespace at times, and was fairly easy to
get plasma into a state where it would endlessly try to resize things to
fit. Helped a
On June 11, 2014, 6:18 p.m., Rex Dieter wrote:
Tested this out a bit today... and it didn't seem to work all that well.
Did seem to result in too much whitespace at times, and was fairly easy to
get plasma into a state where it would endlessly try to resize things to
fit. Helped a
On June 11, 2014, 6:18 p.m., Rex Dieter wrote:
Tested this out a bit today... and it didn't seem to work all that well.
Did seem to result in too much whitespace at times, and was fairly easy to
get plasma into a state where it would endlessly try to resize things to
fit. Helped a
On June 11, 2014, 6:18 p.m., Rex Dieter wrote:
Tested this out a bit today... and it didn't seem to work all that well.
Did seem to result in too much whitespace at times, and was fairly easy to
get plasma into a state where it would endlessly try to resize things to
fit. Helped a
On Wednesday 11 of June 2014 17:07:04 Sebastian Kügler wrote:
[CC:ing frameworks-devel, hoping for additional input]
On Friday, June 06, 2014 23:24:50 šumski wrote:
On Friday 06 of June 2014 21:32:48 Eric Hameleers wrote:
On Fri, 6 Jun 2014, ?umski wrote:
On Thursday 05 of June 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118678/
---
Review request for Plasma, Chusslove Illich and John Layt.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118678/#review59840
---
Can I check I'm understanding the objective.
For the
On June 11, 2014, 11:09 p.m., David Edmundson wrote:
Can I check I'm understanding the objective.
For the language KCM we want to list all possible languages. Potentially
systemsettings isn't translated so won't be listed. In order to get round
this we need to pick a random other
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118678/
---
(Updated June 11, 2014, 11:24 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118657/
---
(Updated June 12, 2014, 10:42 a.m.)
Status
--
This change has been
61 matches
Mail list logo
