Re: Re: Wayland protocols

2014-08-20 Thread Martin Gräßlin
On Tuesday 19 August 2014 17:00:48 you wrote: 2014-08-18 9:37 GMT+02:00 Ivan Čukić ivan.cu...@kde.org: On Monday 18 August 2014 09:22:03 Martin Gräßlin wrote: On Monday 18 August 2014 09:02:07 Pier Luigi wrote: Activities should probably be also exposed to the kf5_window interface?

Re: Wayland protocols

2014-08-20 Thread Ivan Čukić
I'm not familiar with kactivities but a grep for winId reveals that it is used by ResourceInstancePrivate::registerResourceEvent, but I don't understand what does it need to communicate to the compositor. I don't know whether this should be communicated to the compositor or what, just

Re: Wayland protocols

2014-08-20 Thread Marco Martin
On Wednesday 20 August 2014, Ivan Čukić wrote: So, either the window needs to know its id, or it needs to be able to resolve the id through kwin and kwin passes the info to kamd, or something. so, in a nutter-shell, QWindow::winId to be the same as the id that KWin would store internally i

Re: Kioslave repos

2014-08-20 Thread Marco Martin
On Tuesday 19 August 2014, David Faure wrote: Does anyone disagree with my line of thought above? plasma-devel list may also have an opinion on this, sending there. Any news? To me it should be in whatever place it is better for most people, and if there are use cases for it being

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line 33 https://git.reviewboard.kde.org/r/119846/diff/1/?file=306474#file306474line33 Good question. I think it is needed to set background to

Re: Wayland protocols

2014-08-20 Thread Ivan Čukić
so, in a nutter-shell, :) QWindow::winId to be the same as the id that KWin would store internally i guess Yes, that would be perfect. -- Cheerio, Ivan KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6F76, keyserver.pgp.com

Re: Re: Wayland protocols

2014-08-20 Thread Martin Gräßlin
On Wednesday 20 August 2014 10:26:22 Marco Martin wrote: On Wednesday 20 August 2014, Ivan Čukić wrote: So, either the window needs to know its id, or it needs to be able to resolve the id through kwin and kwin passes the info to kamd, or something. so, in a nutter-shell, QWindow::winId

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 9:36 a.m.) Review request for KDE Frameworks and

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line 51 https://git.reviewboard.kde.org/r/119846/diff/1/?file=306474#file306474line51 checked isn't a boolean, it's an enum of the checked, partial,

Re: Kioslave repos

2014-08-20 Thread Aleix Pol
On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at 11:25:11PM +0200, David Faure wrote: On Sunday 27 April 2014 19:35:37 I wrote: * place that repo in kde/ or kde/something in the

Re: Kioslave repos

2014-08-20 Thread Jonathan Riddell
On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at 11:25:11PM +0200, David Faure wrote: On Sunday 27 April 2014

Re: Kioslave repos

2014-08-20 Thread Luigi Toscano
On Wednesday 20 of August 2014 11:38:12 Jonathan Riddell wrote: On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 1:05 p.m.) Review request for KDE Frameworks and

Re: Wayland protocols

2014-08-20 Thread Ivan Čukić
Personally I don't understand why kamd needs to know the internal Id of a window. Is this really needed or could it solved differently (e.g. using additional interface/requests which kwin then forwards to kamd)? If not it's about time that we express the need for a global id in the xdg_shell.

Re: Re: Wayland protocols

2014-08-20 Thread Martin Gräßlin
On Wednesday 20 August 2014 16:41:23 Ivan Čukić wrote: Personally I don't understand why kamd needs to know the internal Id of a window. Is this really needed or could it solved differently (e.g. using additional interface/requests which kwin then forwards to kamd)? If not it's about time

Re: Review Request 119822: QScreen backend for libkscreen

2014-08-20 Thread Sebastian Kügler
On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: autotests/testqscreenbackend.cpp, line 90 https://git.reviewboard.kde.org/r/119822/diff/1/?file=306029#file306029line90 Q_FOREACH Martin Gräßlin wrote: or instead of using Qt macros one could use what the language provides:

Re: Review Request 119822: QScreen backend for libkscreen

2014-08-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/ --- (Updated Aug. 20, 2014, 4:35 p.m.) Review request for Plasma and Solid.

Review Request 119860: hints to disable background in dialogs

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/ --- Review request for Plasma and Pier Luigi Fiorini. Repository:

Re: Review Request 119822: QScreen backend for libkscreen

2014-08-20 Thread Martin Gräßlin
On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: autotests/testqscreenbackend.cpp, line 66 https://git.reviewboard.kde.org/r/119822/diff/1/?file=306029#file306029line66 If we don't have a config even though we correctly configured the backend, should not we fail? a QSKIP might be

Re: Review Request 119860: hints to disable background in dialogs

2014-08-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/#review64918 --- src/plasmaquick/dialog.h

Re: Review Request 119822: QScreen backend for libkscreen

2014-08-20 Thread Sebastian Kügler
On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: autotests/testqscreenbackend.cpp, line 66 https://git.reviewboard.kde.org/r/119822/diff/1/?file=306029#file306029line66 If we don't have a config even though we correctly configured the backend, should not we fail? a QSKIP might

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review64922 --- Ship it! Ship It! - David Edmundson On Aug. 20, 2014,

Review Request 119866: Thumbnails in Klipper

2014-08-20 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 119866: Thumbnails in Klipper

2014-08-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review64924 --- File Attachment: Klipper with thumbnails -

Re: Review Request 119860: hints to disable background in dialogs

2014-08-20 Thread Marco Martin
On Aug. 20, 2014, 4:56 p.m., Sebastian Kügler wrote: src/plasmaquick/dialog.h, line 124 https://git.reviewboard.kde.org/r/119860/diff/1/?file=30#file30line124 Since the background hint is mutually exclusive (semantically, and in the code), wouldn't BackgroundHint

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 6:51 p.m.) Status -- This change has been

Re: Wayland protocols

2014-08-20 Thread Eike Hein
Hi, to start another subtopic: Do we have startup notifications on our radar? http://standards.freedesktop.org/startup-notification-spec/startup-notification-latest.txt http://www.freedesktop.org/wiki/Software/startup-notification/ KDE has an implementation of this that is used by

Re: Review Request 118180: slideshow BUG patch fix

2014-08-20 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated Aug. 20, 2014, 7:13 p.m.) Status -- This change has been

Review Request 119870: Make TabGroup a focus scope

2014-08-20 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119870/ --- Review request for Plasma. Repository: plasma-framework Description

Review Request 119872: AppletInterface::init should set focus not forceActiveFocus

2014-08-20 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119872/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 119872: AppletInterface::init should set focus not forceActiveFocus

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119872/#review64931 --- Ship it! Ship It! - Marco Martin On Aug. 20, 2014, 7:23

Re: Review Request 119870: Make TabGroup a focus scope

2014-08-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119870/#review64932 --- Ship it! Ship It! - Marco Martin On Aug. 20, 2014, 7:20

Review Request 119874: Make Kicker's root item a FocusScope

2014-08-20 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119874/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop

Re: Review Request 119874: Make Kicker's root item a FocusScope

2014-08-20 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119874/ --- (Updated Aug. 20, 2014, 9:27 p.m.) Review request for Plasma and Eike

Re: Review Request 119874: Make Kicker's root item a FocusScope

2014-08-20 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119874/#review64947 --- Ship it! Ship It! - Eike Hein On Aug. 20, 2014, 9:27

Re: Re: Wayland protocols

2014-08-20 Thread Martin Gräßlin
On Wednesday 20 August 2014 21:10:58 Eike Hein wrote: Hi, to start another subtopic: Do we have startup notifications on our radar? http://standards.freedesktop.org/startup-notification-spec/startup-notificat ion-latest.txt http://www.freedesktop.org/wiki/Software/startup-notification/

Re: Review Request 119866: Thumbnails in Klipper

2014-08-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review64951 --- I did not do a proper review for the QML part - there are