Review Request 119984: more plasmashell code cleaning

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119984/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 119984: more plasmashell code cleaning

2014-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119984/#review65466 --- Ship it! Ship It! - David Edmundson On Aug. 29, 2014,

Re: Review Request 119983: Use font metrics to scale icons for high dpi outputs

2014-08-29 Thread Martin Klapetek
On Aug. 29, 2014, 1:11 a.m., David Edmundson wrote: src/declarativeimports/core/units.cpp, lines 197-198 https://git.reviewboard.kde.org/r/119983/diff/1/?file=308044#file308044line197 I'm confused. gridUnit is based on QGuiApplication::font() and we

Re: Review Request 119983: Use font metrics to scale icons for high dpi outputs

2014-08-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119983/#review65472 --- shouldn't be m_gridunit be calculated from fontPixelRatio as

Re: Review Request 119983: Use font metrics to scale icons for high dpi outputs

2014-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119983/#review65473 --- I'm on a standard pleb monitor, I get: $ ./dpitest

Re: Review Request 119984: more plasmashell code cleaning

2014-08-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119984/#review65474 --- Ship it! Ship It! - Marco Martin On Aug. 29, 2014, 7:43

Plasma Schedule

2014-08-29 Thread Jonathan Riddell
I've tidied up the Plasma 5 release schedule https://techbase.kde.org/Schedules/Plasma_5 Frameworks https://techbase.kde.org/Schedules/Frameworks tags on first Sat or month and release on following Thursday. Plasma tags on Frameworks release Thursdays and release on following Tuesday (with Beta

Re: Review Request 119984: more plasmashell code cleaning

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119984/ --- (Updated Aug. 29, 2014, 11:20 a.m.) Status -- This change has been

Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/ --- Review request for KDE Frameworks and Plasma. Repository:

Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119989/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/#review65481 --- src/plasma/packagestructure.h

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/#review65482 --- Ship it! +1 for removing shellpackage. good for

Re: Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119989/#review65479 --- dataengines/share/packagestructure/CMakeLists.txt

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
On Aug. 29, 2014, noon, David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Yes, but I don't think it maters for two reasons: 1) DataEngine also had

Re: Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119989/ --- (Updated Aug. 29, 2014, 12:17 p.m.) Review request for Plasma. Changes

Re: Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119989/ --- (Updated Aug. 29, 2014, 12:19 p.m.) Review request for Plasma. Changes

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Hrvoje Senjan
On Aug. 29, 2014, 2 p.m., David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two

Re: Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119989/#review65486 --- Ship it! rebased version looks good - Marco Martin On

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread David Edmundson
On Aug. 29, 2014, noon, David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Martin Gräßlin
On Aug. 29, 2014, 2 p.m., David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
On Aug. 29, 2014, noon, David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
On Aug. 29, 2014, noon, David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two

Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme

2014-08-29 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119990/ --- Review request for Plasma. Repository: libksysguard Description

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Marco Martin
On Aug. 29, 2014, noon, David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two

Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119992/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/ --- (Updated Aug. 29, 2014, 2:20 p.m.) Status -- This change has been

Re: Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

2014-08-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119992/#review65507 --- Ship it! this having both defines should make old users

Re: Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

2014-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119992/#review65508 --- Ship it! and +1 me. Thanks. - David Edmundson On Aug. 29,

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Marco Martin
On Aug. 29, 2014, noon, David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread David Edmundson
On Aug. 29, 2014, noon, David Edmundson wrote: src/plasma/packagestructure.h, line 99 https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99 would removing a #define count as a SIC? Aaron J. Seigo wrote: Yes, but I don't think it maters for two

Re: Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119992/ --- (Updated Aug. 29, 2014, 3:25 p.m.) Status -- This change has been

Re: Review Request 119989: PackageStructure plugins in plasma-workspaces

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119989/ --- (Updated Aug. 29, 2014, 3:26 p.m.) Status -- This change has been

Build failed in Jenkins: plasma-workspace_master_qt5 #797

2014-08-29 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/797/changes Changes: [aseigo] add the package plugins to the build [aseigo] put the shell package into a plugin [aseigo] fix use of the package plugin [aseigo] package-packagestructure [aseigo] relative paths are supported [aseigo]

Review Request 119993: Port KAuth actions in libksysguard

2014-08-29 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119993/ --- Review request for Plasma. Repository: libksysguard Description

Re: Review Request 119993: Port KAuth actions in libksysguard

2014-08-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119993/#review65524 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 29, 2014,

Re: Review Request 119983: Use font metrics to scale icons for high dpi outputs

2014-08-29 Thread David Edmundson
On Aug. 29, 2014, 10:33 a.m., David Edmundson wrote: I'm on a standard pleb monitor, I get: $ ./dpitest dpitest(8664)/(default) Plasma::DPITest::runMain: DPI test runs: dpitest(8664)/(default) Plasma::DPITest::runMain: font.pixelSize: -1 dpitest(8664)/(default)