Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Aaron J. Seigo
On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: I need some the concept explaining, why would a developer set a fallbackpackage? Is it not always org.kde.breeze.desktop? Marco Martin wrote: It would usually be the packagestructure setting it, in initPackage(), so

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Marco Martin
On Set. 1, 2014, 4:53 p.m., David Edmundson wrote: I need some the concept explaining, why would a developer set a fallbackpackage? Is it not always org.kde.breeze.desktop? Marco Martin wrote: It would usually be the packagestructure setting it, in initPackage(), so

Jenkins build is back to stable : plasma-workspace_master_qt5 #817

2014-09-03 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/817/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Aaron J. Seigo
On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: I need some the concept explaining, why would a developer set a fallbackpackage? Is it not always org.kde.breeze.desktop? Marco Martin wrote: It would usually be the packagestructure setting it, in initPackage(), so

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Marco Martin
On Set. 1, 2014, 4:53 p.m., David Edmundson wrote: I need some the concept explaining, why would a developer set a fallbackpackage? Is it not always org.kde.breeze.desktop? Marco Martin wrote: It would usually be the packagestructure setting it, in initPackage(), so

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Aaron J. Seigo
On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: I need some the concept explaining, why would a developer set a fallbackpackage? Is it not always org.kde.breeze.desktop? Marco Martin wrote: It would usually be the packagestructure setting it, in initPackage(), so

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Marco Martin
On Set. 1, 2014, 4:53 p.m., David Edmundson wrote: I need some the concept explaining, why would a developer set a fallbackpackage? Is it not always org.kde.breeze.desktop? Marco Martin wrote: It would usually be the packagestructure setting it, in initPackage(), so

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Marco Martin
On Set. 1, 2014, 4:53 p.m., David Edmundson wrote: I need some the concept explaining, why would a developer set a fallbackpackage? Is it not always org.kde.breeze.desktop? Marco Martin wrote: It would usually be the packagestructure setting it, in initPackage(), so

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/ --- (Updated Sept. 3, 2014, 6:14 p.m.) Review request for Plasma. Changes

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/ --- (Updated Sept. 3, 2014, 6:16 p.m.) Review request for Plasma.

Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review65772 --- Ship it! yes, the direction sounds sensible to me - Marco

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Marco Martin
On Set. 3, 2014, 5 p.m., Marco Martin wrote: yes, the direction sounds sensible to me (err, shipit just after you finish it, as you note, mis-checked the checkbox) - Marco --- This is an automatically generated e-mail. To reply,

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review65774 --- wallpaperimages/ misses a CMAkeLists.txt (git add forgot?) -

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 3, 2014, 5:49 p.m.) Review request for Plasma. Changes

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review65775 --- Ship it! plasmashell seems to correctly load the wallpaper,

Review Request 120051: Introduce keyboard layout QML plugin

2014-09-03 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120051/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 120051: Introduce keyboard layout QML plugin

2014-09-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120051/#review65778 --- Good stuff. There's a discussion we need to have about where

Re: Review Request 120051: Introduce keyboard layout QML plugin

2014-09-03 Thread Aleix Pol Gonzalez
On Sept. 3, 2014, 10:22 p.m., David Edmundson wrote: components/keyboardlayout/CMakeLists.txt, line 1 https://git.reviewboard.kde.org/r/120051/diff/1/?file=309589#file309589line1 This can't go in components. There was a review comment once with a fear components could become

Re: Review Request 120051: Introduce keyboard layout QML plugin

2014-09-03 Thread David Edmundson
On Sept. 3, 2014, 10:22 p.m., David Edmundson wrote: components/keyboardlayout/CMakeLists.txt, line 1 https://git.reviewboard.kde.org/r/120051/diff/1/?file=309589#file309589line1 This can't go in components. There was a review comment once with a fear components could become