On Oct. 28, 2014, 11:15 p.m., Thomas Lübking wrote:
tabbox/tabboxhandler.cpp, line 235
https://git.reviewboard.kde.org/r/120849/diff/1/?file=322492#file322492line235
why not? (by different name, oc)
yep, I was also considering moving the desktop switchers to lnf.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120847/
---
(Updated Oct. 29, 2014, 7:26 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120850/
---
(Updated Oct. 29, 2014, 7:27 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120849/
---
(Updated Oct. 29, 2014, 7:30 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120880/
---
Review request for kwin and Plasma.
Repository: kdeplasma-addons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120881/
---
Review request for kwin and Plasma.
Repository: kwin
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120880/#review69381
---
related review request for KWin:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120882/
---
Review request for Plasma.
Repository: plasma-desktop
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120883/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120884/
---
Review request for kwin and Plasma.
Repository: kwin
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120877/#review69384
---
No opinion on the patch but please check your coding style.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/#review69387
---
src/plasma/private/applet_p.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/#review69385
---
src/plasma/data/notifications/plasmashell.notifyrc
On Oct. 29, 2014, 9:39 a.m., Kai Uwe Broulik wrote:
src/plasma/private/applet_p.cpp, line 240
https://git.reviewboard.kde.org/r/120885/diff/1/?file=322833#file322833line240
The notification should have the plasmoid icon, no?
indeed. knotification doesn't have api for just icons,
On Oct. 29, 2014, 9:39 a.m., Martin Klapetek wrote:
src/plasma/data/notifications/plasmashell.notifyrc, line 9
https://git.reviewboard.kde.org/r/120885/diff/1/?file=322830#file322830line9
You myyybe also want Sound?
hmm, really?
On Oct. 29, 2014, 9:39 a.m., Martin Klapetek
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/#review69388
---
out of interest: what's the bool transient about?
On Oct. 29, 2014, 10:39 a.m., Martin Klapetek wrote:
src/plasma/data/notifications/plasmashell.notifyrc, line 9
https://git.reviewboard.kde.org/r/120885/diff/1/?file=322830#file322830line9
You myyybe also want Sound?
Marco Martin wrote:
hmm, really?
out of interest:
On Oct. 29, 2014, 10:39 a.m., Martin Klapetek wrote:
src/plasma/data/notifications/plasmashell.notifyrc, line 9
https://git.reviewboard.kde.org/r/120885/diff/1/?file=322830#file322830line9
You myyybe also want Sound?
Marco Martin wrote:
hmm, really?
Martin Gräßlin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120884/#review69397
---
Ship it!
since the branches only differ by a substring which
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/
---
(Updated Oct. 29, 2014, 10:16 a.m.)
Review request for Plasma.
On Oct. 29, 2014, 9:49 a.m., Martin Gräßlin wrote:
src/plasma/private/applet_p.cpp, lines 239-241
https://git.reviewboard.kde.org/r/120885/diff/1/?file=322833#file322833line239
not sure whether it's allowed in frameworks:
const QStringList actions({i18n(Undo)});
not
On Oct. 29, 2014, 10:49 a.m., Martin Gräßlin wrote:
src/plasma/data/notifications/plasmashell.notifyrc, lines 7-8
https://git.reviewboard.kde.org/r/120885/diff/1/?file=322830#file322830line7
Isn't Plasmoid a little bit too techy?
Marco Martin wrote:
changed (even tough that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120884/
---
(Updated Oct. 29, 2014, 11:26 a.m.)
Review request for kwin and Plasma.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109832/
---
(Updated Oct. 29, 2014, 11:38 a.m.)
Review request for kwin, Plasma and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120885/#review69421
---
I tried to do it in a single squashed commit again on gerrit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120884/#review69423
---
+1
- Marco Martin
On Ott. 29, 2014, 10:26 a.m., Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109832/#review69422
---
tabbox/qml/clients/scaling/contents/ui/main.qml
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120876/#review69429
---
The version check is actually on the bugzilla version
On Okt. 29, 2014, 12:41 nachm., Thomas Lübking wrote:
The version check is actually on the bugzilla version (KDE_MAKE_VERSION is
just a bitshifting macro) - it's the important part in the original patch
;-)
To prevent future confusion, one might want to add
#define
On Oct. 29, 2014, 10:39 a.m., Martin Klapetek wrote:
src/plasma/data/notifications/plasmashell.notifyrc, line 9
https://git.reviewboard.kde.org/r/120885/diff/1/?file=322830#file322830line9
You myyybe also want Sound?
Marco Martin wrote:
hmm, really?
Martin Gräßlin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120352/#review69438
---
I don't have much of an opinion when it comes to keyboard
On Oct. 29, 2014, 11:57 a.m., Kai Uwe Broulik wrote:
tabbox/qml/clients/scaling/contents/ui/main.qml, lines 31-32
https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line31
Is this needed? Adds a bit of overhead and you're not using it
consistently everywhere
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120880/#review69457
---
That means that other desktop enviornments cannot really use
On Oct. 29, 2014, 4:06 p.m., Thomas Pfeiffer wrote:
That means that other desktop enviornments cannot really use KWin without
installing at least one lf package anymore, right? Could that be a
problem, or is KWin no fun without any LFs installed, anyway, even without
that change?
I
On Okt. 29, 2014, 3:06 nachm., Thomas Pfeiffer wrote:
That means that other desktop enviornments cannot really use KWin without
installing at least one lf package anymore, right? Could that be a
problem, or is KWin no fun without any LFs installed, anyway, even without
that change?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109832/
---
(Updated Oct. 29, 2014, 3:22 p.m.)
Review request for kwin, Plasma and
On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote:
Martin Gräßlin wrote:
@Kai Uwe: may I ask you to do such a review for all other existing window
switchers? Or just have a look at them and improve as you seem fit.
Okay, once they've all landed in kdeplasma-addons I will take a
On Oct. 29, 2014, 12:57 p.m., Kai Uwe Broulik wrote:
tabbox/qml/clients/scaling/contents/ui/main.qml, line 405
https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line405
i18n this?
Andre Heinecke wrote:
I don't think this is neccessary. The braces are
On Oct. 29, 2014, 12:57 p.m., Kai Uwe Broulik wrote:
tabbox/qml/clients/scaling/contents/ui/main.qml, line 405
https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line405
i18n this?
Andre Heinecke wrote:
I don't think this is neccessary. The braces are
On Oct. 29, 2014, 12:57 p.m., Kai Uwe Broulik wrote:
tabbox/qml/clients/scaling/contents/ui/main.qml, line 405
https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line405
i18n this?
Andre Heinecke wrote:
I don't think this is neccessary. The braces are
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120891/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120891/#review69473
---
Ship it!
+1 that's in the category of world cultural
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120892/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120891/#review69474
---
Ship it!
Ship It!
- Martin Gräßlin
On Oct. 29, 2014, 6:14
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/#review69475
---
Ship it!
Ship It!
- David Edmundson
On Oct. 28, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120806/
---
(Updated Oct. 29, 2014, 6:23 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120894/
---
Review request for Plasma.
Bugs: 340412
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120894/#review69482
---
Ship it!
good apart a small issue.
Also, this should be done
On Oct. 29, 2014, 1:41 p.m., Thomas Lübking wrote:
The version check is actually on the bugzilla version (KDE_MAKE_VERSION is
just a bitshifting macro) - it's the important part in the original patch
;-)
Thomas Lübking wrote:
To prevent future confusion, one might want to add
On Okt. 29, 2014, 12:41 nachm., Thomas Lübking wrote:
The version check is actually on the bugzilla version (KDE_MAKE_VERSION is
just a bitshifting macro) - it's the important part in the original patch
;-)
Thomas Lübking wrote:
To prevent future confusion, one might want to add
On Okt. 29, 2014, 7:55 nachm., Marco Martin wrote:
shell/panelview.cpp, line 688
https://git.reviewboard.kde.org/r/120894/diff/1/?file=323565#file323565line688
would be cleaner to put it in its own case, instead of grouped together
with the mouse events, since is completely
On Ott. 29, 2014, 7:55 p.m., Marco Martin wrote:
shell/panelview.cpp, line 688
https://git.reviewboard.kde.org/r/120894/diff/1/?file=323565#file323565line688
would be cleaner to put it in its own case, instead of grouped together
with the mouse events, since is completely separed
On Oct. 29, 2014, 1:41 p.m., Thomas Lübking wrote:
The version check is actually on the bugzilla version (KDE_MAKE_VERSION is
just a bitshifting macro) - it's the important part in the original patch
;-)
Thomas Lübking wrote:
To prevent future confusion, one might want to add
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120876/
---
(Updated Oct. 29, 2014, 9:25 p.m.)
Review request for Plasma, Ben
On Okt. 29, 2014, 12:41 nachm., Thomas Lübking wrote:
The version check is actually on the bugzilla version (KDE_MAKE_VERSION is
just a bitshifting macro) - it's the important part in the original patch
;-)
Thomas Lübking wrote:
To prevent future confusion, one might want to add
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120876/
---
(Updated Oct. 29, 2014, 9:41 p.m.)
Review request for Plasma, Ben
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120894/
---
(Updated Okt. 29, 2014, 8:56 nachm.)
Review request for Plasma.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120877/
---
(Updated Out. 30, 2014, 1:35 a.m.)
Review request for kdewin and Plasma.
59 matches
Mail list logo
