Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
> On Nov. 17, 2014, 2:45 p.m., Thomas Lübking wrote: > > attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 > > > > > > is > > > > KdePlatformDependent::~KdePlatformDependent() > > { > >if

Re: Review Request 121148: Make WallpaperInterface use the suggested async object loading API

2014-11-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121148/ --- (Updated Nov. 17, 2014, 11:10 p.m.) Review request for Plasma. Changes

Re: Review Request 121154: Add context to i18n call

2014-11-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/ --- (Updated Nov. 17, 2014, 11:06 p.m.) Status -- This change has been m

Re: Review Request 121152: Provide async API for QmlObject

2014-11-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/#review70559 --- I think this makes sense. +1 - David Edmundson On Nov. 17,

Re: Review Request 121154: Add context to i18n call

2014-11-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/#review70557 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 17, 2014, 6

Re: Review Request 121154: Add context to i18n call

2014-11-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/#review70552 --- Ship it! Ship It! - David Edmundson On Nov. 17, 2014, 6:19

Re: Review Request 121155: Enforce StyledText in notifications

2014-11-17 Thread Kai Uwe Broulik
> On Nov. 17, 2014, 8:37 nachm., Martin Klapetek wrote: > > applets/notifications/package/contents/ui/Notifications.qml, line 48 > > > > > > Would this be faster on the c++ side (the dataengine)? We should move >

Re: Review Request 121155: Enforce StyledText in notifications

2014-11-17 Thread Kai Uwe Broulik
> On Nov. 17, 2014, 8:37 nachm., Martin Klapetek wrote: > > applets/notifications/package/contents/ui/Notifications.qml, line 48 > > > > > > Would this be faster on the c++ side (the dataengine)? We should move >

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Thomas Lübking
> On Nov. 17, 2014, 9:45 nachm., Thomas Lübking wrote: > > attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 > > > > > > is > > > > KdePlatformDependent::~KdePlatformDependent() > > { > >

Re: Review Request 121162: Some ideas for the image wallpaper

2014-11-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/#review70546 --- wallpapers/image/imagepackage/contents/ui/main.qml

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Albert Astals Cid
> On nov. 17, 2014, 9:45 p.m., Thomas Lübking wrote: > > attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 > > > > > > is > > > > KdePlatformDependent::~KdePlatformDependent() > > { > >if

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/#review70542 --- attica-kde/kdeplugin/kdeplatformdependent.cpp

Re: Review Request 121162: Some ideas for the image wallpaper

2014-11-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/#review70539 --- wallpapers/image/imagepackage/contents/ui/main.qml

Review Request 121162: Some ideas for the image wallpaper

2014-11-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- (Updated Nov. 17, 2014, 2:11 p.m.) Review request for kdelibs and Plasma.

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- (Updated Nov. 17, 2014, 2:11 p.m.) Review request for Plasma. Changes -

Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- Review request for kdelibs and Plasma. Repository: plasma-desktop Descr

Re: Review Request 121155: Enforce StyledText in notifications

2014-11-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/#review70537 --- Ship it! applets/notifications/package/contents/ui/Notificat

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-11-17 Thread Ivan Čukić
A small update. In order to make the api avaliable to crappy compilers, I've made some small changes to the code in the last mail: // For crappy compilers // Fancy query definition auto fancyQuery = AllResources | Type("text")

Re: Review Request 121155: Enforce StyledText in notifications

2014-11-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/ --- (Updated Nov. 17, 2014, 7:40 nachm.) Review request for Plasma, Bhushan S

Review Request 121155: Enforce StyledText in notifications

2014-11-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121155/ --- Review request for Plasma, Bhushan Shah, Eike Hein, and Martin Klapetek.

Review Request 121154: Add context to i18n call

2014-11-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121154/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 121152: Provide async API for QmlObject

2014-11-17 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/#review70530 --- src/kdeclarative/qmlobject.h

Review Request 121148: Make WallpaperInterface use the suggested async object loading API

2014-11-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121148/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 121152: Provide async API for QmlObject

2014-11-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121152/ --- Review request for Plasma. Repository: kdeclarative Description ---

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-17 Thread Marco Martin
> On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: > > hm, i don't really like it. > > is it working around a problem in particular? > > if i try the patch, the difference during startup (or just duringopening a > > popup on the first time) is pretty noticeable like, the wallpaper appearing >

Re: Review Request 121121: Remove all kdelibs4support from polkit-agent

2014-11-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/ --- (Updated Nov. 17, 2014, 2:37 p.m.) Status -- This change has been ma

Jenkins build is back to stable : plasma-workspace_master_qt5 #1072

2014-11-17 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

No Plasma Meeting Today

2014-11-17 Thread David Edmundson
There wont' be a Plasma hangout today as a lot of people are going to be away. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: plasma-desktop_stable_qt5 #2

2014-11-17 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel