Re: Review Request 121346: Touchpad scroll fix for battery monitor

2014-12-04 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121346/ --- (Updated Dec. 5, 2014, 3:45 a.m.) Review request for Plasma and Kai Uwe B

Re: Review Request 121350: 5 Krazy2 issues fix for plasma-mediacenter

2014-12-04 Thread Popov Sergey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121350/ --- (Updated Dec. 5, 2014, 3:14 a.m.) Status -- This change has been mar

Re: Review Request 121350: 5 Krazy2 issues fix for plasma-mediacenter

2014-12-04 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121350/#review71399 --- Ship it! Perfect thanks! I will commit this on behalf of you

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

2014-12-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121219/#review71397 --- src/declarativeimports/core/iconitem.cpp

Re: Review Request 121357: Don't allow changing the volume when playing a notification

2014-12-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121357/#review71396 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Dec. 4

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

2014-12-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121219/#review71395 --- src/declarativeimports/core/iconitem.h

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71394 --- +1 I don't really understand dataengines enough to say it's a

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Kai Uwe Broulik
> On Dez. 4, 2014, 9:20 nachm., Emmanuel Pescosta wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 170 > > > > > > You can remove the "this" receiver here and in other connect calls. > > Ka

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Emmanuel Pescosta
> On Dec. 4, 2014, 10:20 p.m., Emmanuel Pescosta wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 170 > > > > > > You can remove the "this" receiver here and in other connect calls. > > Kai

Re: Review Request 121357: Don't allow changing the volume when playing a notification

2014-12-04 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121357/#review71371 --- Ship it! I agree. - Jeremy Whiting On Dec. 4, 2014, 2:23 p

Re: Review Request 121346: Some fixes on battery monitor

2014-12-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121346/#review71370 --- applets/batterymonitor/package/contents/ui/batterymonitor.qml

Review Request 121357: Don't allow changing the volume when playing a notification

2014-12-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121357/ --- Review request for Plasma and David Edmundson. Repository: plasma-desktop

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Kai Uwe Broulik
> On Dez. 4, 2014, 9:20 nachm., Emmanuel Pescosta wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 170 > > > > > > You can remove the "this" receiver here and in other connect calls. Are yo

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71367 --- dataengines/powermanagement/powermanagementengine.cpp

Re: Review Request 121294: Improve wallpaper sourceSize handling

2014-12-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121294/ --- (Updated Dez. 4, 2014, 9:16 nachm.) Review request for Plasma. Changes

Re: Review Request 121346: Some fixes on battery monitor

2014-12-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121346/#review71363 --- Ship it! Please commit your mousewheel fixes. Regarding the

Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/ --- Review request for Plasma and Solid. Repository: plasma-workspace Descr

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

2014-12-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121219/ --- (Updated Dez. 4, 2014, 8:27 nachm.) Review request for Plasma. Summary

Review Request 121350: 5 Krazy2 issues fix for plasma-mediacenter

2014-12-04 Thread Popov Sergey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121350/ --- Review request for Plasma and Bhushan Shah. Repository: plasma-mediacente

Re: Review Request 121346: Some fixes on battery monitor

2014-12-04 Thread Xuetian Weng
> On Dec. 4, 2014, 9:26 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > I will borrow that angleDelta trick for the Plasma calendar where I used a > > similar, yet different and worse, approach [1]. > > > > The brightness percent value was there for a reason. Powerdevil only > > allowed bright

Re: Review Request 121348: Adaptive ui for Active settings

2014-12-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121348/#review71346 --- applications/settings/package/contents/ui/ActiveSettings.qml

Review Request 121348: Adaptive ui for Active settings

2014-12-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121348/ --- Review request for Plasma and Sebastian Kügler. Repository: plasma-mobile

Re: virtual desktop pager

2014-12-04 Thread Martin Gräßlin
On Wednesday 03 December 2014 23:28:35 Junfei Geng wrote: > Hello, Hi, > However, from this picture, it seems that I won't be able to tell which > desktop I'm currently working in. -- I'm in fact in the Desktop 4.In > previous version of virtual desktop manager, the currently active desktop > is

Jenkins build became unstable: plasma-workspace_stable_qt5 #13

2014-12-04 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121346: Some fixes on battery monitor

2014-12-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121346/#review71328 --- Nice! I will borrow that angleDelta trick for the Plasma cale

virtual desktop pager

2014-12-04 Thread Junfei Geng
Hello, I've been using KDE for quite a long time. Recently I have installed CentOS 6.6 at home with KDE window manager: CentOS 6Theme: Air Pager version 1.0, KDE4.3.4 One issue I found is as follows (I don't recall I had this in earlier version of KDE). For the Multiple Desktop Pager, e.g, as in

Review Request 121346: Some fixes on battery monitor

2014-12-04 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121346/ --- Review request for Plasma and Kai Uwe Broulik. Repository: plasma-workspa