Re: Review Request 122411: Prevent notifications from accessing the network

2015-02-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122411/#review75351 --- Just wondering: I assume the problem is also because the data

Re: Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Gräßlin
On Tuesday 03 February 2015 14:13:11 Marco Martin wrote: On Tuesday 03 February 2015, Martin Gräßlin wrote: On Feb. 3, 2015, 1:48 p.m., Kai Uwe Broulik wrote: I suggest you use PlasmaComponents PageStack for the navigation between the barcode and list view. That way you can just

Re: Re: Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Gräßlin
On Tuesday 03 February 2015 15:24:19 David Edmundson wrote: On Tue, Feb 3, 2015 at 2:42 PM, Martin Gräßlin mgraess...@kde.org wrote: On Tuesday 03 February 2015 14:13:11 Marco Martin wrote: On Tuesday 03 February 2015, Martin Gräßlin wrote: On Feb. 3, 2015, 1:48 p.m., Kai Uwe Broulik

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

2015-02-03 Thread Phil Schaf
https://bugs.kde.org/show_bug.cgi?id=343555 --- Comment #8 from Phil Schaf flying-sh...@web.de --- Before the removal of gtktheming engine, oxygen-gtk2 and oxygen-gtk3 shared ~90% wow, consider my comment null and void then. i thought hooking into the respective drawing mechanisms would have

Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Proposal regarding plasmate's release

2015-02-03 Thread Philipp A.
i had problems using plasmoidviewer with a native plugin. if someone could get the test script to work here without temporary installing, i’d be stoked! https://github.com/flying-sheep/steam-plasmoid Aleix Pol aleix...@kde.org schrieb am Sun Feb 01 2015 at 10:13:06: On Thu, Jan 29, 2015 at

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

2015-02-03 Thread Phil Schaf
https://bugs.kde.org/show_bug.cgi?id=343555 --- Comment #9 from Phil Schaf flying-sh...@web.de --- i read it and it sucks even more: https://bugzilla.gnome.org/show_bug.cgi?id=735211 just… wow. -- You are receiving this mail because: You are the assignee for the bug.

Re: Review Request 121738: Let kcmkded also handle kded modules that use JSON metadata

2015-02-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121738/ --- (Updated Feb. 3, 2015, 11:32 a.m.) Status -- This change has been

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/#review75292 --- Looks good, a small nitpick in the style... The Plasma QML

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 3, 2015, 11:43 a.m.) Review request for Plasma.

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 3, 2015, 11:44 a.m.) Review request for Plasma.

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Marco Martin
On Feb. 3, 2015, 8:43 p.m., David Edmundson wrote: Next set of bugs: - what about if the paintedWidth is requested before the item's source has first been set? - or if the item is currently invisible? (what should that return? I'm not sure what Image does) Other thought:

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
On Feb. 3, 2015, 8:43 p.m., David Edmundson wrote: Next set of bugs: - what about if the paintedWidth is requested before the item's source has first been set? - or if the item is currently invisible? (what should that return? I'm not sure what Image does) Other thought:

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 10:22 p.m.) Review request for KDE Frameworks and

Review Request 122409: Remove shortcuts to switch activities from plasmashell

2015-02-03 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122409/ --- Review request for Plasma, Ivan Čukić and Marco Martin. Bugs: 342186

Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/ --- Review request for KDE Frameworks, Plasma and Ivan Čukić. Bugs: 342186

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/#review75303 --- I suggest you use PlasmaComponents PageStack for the

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Marco Martin
On Tuesday 03 February 2015, Martin Gräßlin wrote: On Feb. 3, 2015, 1:48 p.m., Kai Uwe Broulik wrote: I suggest you use PlasmaComponents PageStack for the navigation between the barcode and list view. That way you can just push and pop the view and don't needlessly create it when it's

Re: Proposal regarding plasmate's release

2015-02-03 Thread Sebastian Kügler
On Sunday, February 01, 2015 10:12:27 Aleix Pol wrote: So the plan is to be able to release Plasmate without Plasmate? The repo name is I think a bit confusing. I think plasma-sdk would fit it better. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

Re: Proposal regarding plasmate's release

2015-02-03 Thread Philipp A.
Sebastian Kügler se...@kde.org schrieb am Tue Feb 03 2015 at 12:59:22: If you're using imports, you have to install them first, no way around that. no way, that’s silly. how can we fix that? ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Proposal regarding plasmate's release

2015-02-03 Thread Giorgos Tsiapaliokas
On 2/3/15 1:59 PM, Sebastian Kügler wrote: The repo name is I think a bit confusing. I think plasma-sdk would fit it better. +1 On 1/30/15 11:57 AM, Marco Martin wrote: maybe a quiet last kde4 release? so would be called the version, then 4 and 5 released more or less at the same time I

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Gräßlin
On Feb. 3, 2015, 1:48 p.m., Kai Uwe Broulik wrote: I suggest you use PlasmaComponents PageStack for the navigation between the barcode and list view. That way you can just push and pop the view and don't needlessly create it when it's not used. where do I find documentation for

Re: Proposal regarding plasmate's release

2015-02-03 Thread Sebastian Kügler
On Tuesday, February 03, 2015 08:51:53 Philipp A. wrote: i had problems using plasmoidviewer with a native plugin. if someone could get the test script to work here without temporary installing, i’d be stoked! If you're using imports, you have to install them first, no way around that.

Re: Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread David Edmundson
On Tue, Feb 3, 2015 at 2:42 PM, Martin Gräßlin mgraess...@kde.org wrote: On Tuesday 03 February 2015 14:13:11 Marco Martin wrote: On Tuesday 03 February 2015, Martin Gräßlin wrote: On Feb. 3, 2015, 1:48 p.m., Kai Uwe Broulik wrote: I suggest you use PlasmaComponents PageStack for the

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/ --- (Updated Feb. 3, 2015, 1:09 p.m.) Review request for Plasma and Sune

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/#review75322 --- to me is fine to have it either done by the plasmashell or

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/#review75324 --- This does fix the switching, but I don't agree it is the

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Ivan Čukić
On Feb. 3, 2015, 5:40 p.m., Ivan Čukić wrote: This does fix the switching, but I don't agree it is the right place for it (I don't like that this plugin exists at all tbh). When switching the activities, there needs to be a (UI) feedback - the switcher needs to show up. That means

Review Request 122411: Prevent notifications from accessing the network

2015-02-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122411/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 11:41 p.m.) Review request for KDE Frameworks and

Re: Review Request 122411: Prevent notifications from accessing the network

2015-02-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122411/#review75344 --- Ship it! Ship It! - Martin Klapetek On Feb. 3, 2015, 7:44

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75334 --- Next set of bugs: - what about if the paintedWidth is

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75332 --- src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 8:33 p.m.) Review request for KDE Frameworks and

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review75273 --- Looks good kcms/dateandtime/dtime.cpp

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-03 Thread David Edmundson
On Feb. 3, 2015, 9:31 a.m., Martin Klapetek wrote: kcms/dateandtime/dtime.cpp, line 203 https://git.reviewboard.kde.org/r/122400/diff/1/?file=346550#file346550line203 I guess this meant irrelevant? yes, I accidentally a word. - David

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

2015-02-03 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=343555 --- Comment #10 from Martin Klapetek mklape...@kde.org --- Please let's not turn this into Gnome bashing report. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/ --- (Updated Feb. 3, 2015, 12:03 p.m.) Review request for Plasma and Sune

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-03 Thread Martin Gräßlin
On Feb. 3, 2015, 8:36 a.m., Martin Gräßlin wrote: David E. just pointed out that this could become quite heavy for the system as the history size can be large (up to 2048 items). Martin Gräßlin wrote: Unfortunately I couldn't find out why we support up to 2048 items. Commit

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/#review75281 --- File Attachment: QR Code - missing-tasks-applet1.png

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-03 Thread Martin Gräßlin
On Feb. 3, 2015, 8:36 a.m., Martin Gräßlin wrote: David E. just pointed out that this could become quite heavy for the system as the history size can be large (up to 2048 items). Martin Gräßlin wrote: Unfortunately I couldn't find out why we support up to 2048 items. Commit

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

2015-02-03 Thread Phil Schaf
https://bugs.kde.org/show_bug.cgi?id=343555 --- Comment #11 from Phil Schaf flying-sh...@web.de --- of course not! i initially defended GNOME, as you can see from my first comments. but judging from that 90% figure hugo gave above, i think that there should be low level theming support in GTK.

Re: Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/ --- (Updated Feb. 3, 2015, 11:40 a.m.) Review request for Plasma and Sune

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-03 Thread Martin Klapetek
On Feb. 3, 2015, 8:36 a.m., Martin Gräßlin wrote: David E. just pointed out that this could become quite heavy for the system as the history size can be large (up to 2048 items). Martin Gräßlin wrote: Unfortunately I couldn't find out why we support up to 2048 items. Commit

Review Request 122402: [clipboard] Show barcodes directly in view

2015-02-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/ --- Review request for Plasma and Sune Vuorela. Repository: plasma-workspace