---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122430/
---
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
On Feb. 4, 2015, 2:31 p.m., David Edmundson wrote:
Code is all fine.
By default each of these shows nothing; showing everything would be a
better default
The disk usage one doesn't seem to work at all. It's not even remembering
the options I select
It's auto scaling the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122430/
---
(Updated Feb. 4, 2015, 5:46 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122430/#review75430
---
src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
On Feb. 4, 2015, 5:18 p.m., David Edmundson wrote:
src/qmlcontrols/kquickcontrolsaddons/plotter.cpp, line 363
https://git.reviewboard.kde.org/r/122430/diff/1/?file=347017#file347017line363
to match the docs this possibly wants a || autoRange
otherwise it is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122430/#review75432
---
Ship it!
Ship It!
- David Edmundson
On Feb. 4, 2015, 5:46
On Feb. 4, 2015, 7:16 vorm., Martin Gräßlin wrote:
Just wondering: I assume the problem is also because the data is
interpreted. Is that intended, that applications can send markup which gets
interpreted?
Yes, the specification explicitly allows (and we enforce) a subset of HTML in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122318/#review75356
---
Ship it!
Ship It!
- David Edmundson
On Jan. 29, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122318/#review75357
---
applets/kickoff/core/applicationmodel.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122318/
---
(Updated Feb. 4, 2015, 9:37 vorm.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122419/
---
Review request for Plasma.
Bugs: 198097
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122432/#review75439
---
Ship it!
Ship It!
- David Edmundson
On Feb. 4, 2015, 7:52
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122432/#review75438
---
src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122432/
---
(Updated Feb. 4, 2015, 7:52 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122413/
---
(Updated Feb. 4, 2015, 7:18 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122432/
---
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122432/
---
(Updated Feb. 4, 2015, 8:19 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/#review75410
---
Code is all fine.
By default each of these shows nothing;
On Feb. 4, 2015, 2:31 p.m., David Edmundson wrote:
Code is all fine.
By default each of these shows nothing; showing everything would be a
better default
The disk usage one doesn't seem to work at all. It's not even remembering
the options I select
It's auto scaling the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122425/#review75413
---
Ship it!
Ship It!
- Martin Klapetek
On Feb. 4, 2015, 3:54
On Feb. 4, 2015, 3:13 p.m., Martin Gräßlin wrote:
could the implementation be split in two files: one for legacy, one for
systemd? I think this could make reading the file easier.
Is it possible to determine at compile time whether the systemd component
is available? E.g. check
On Feb. 4, 2015, 4:13 p.m., Martin Gräßlin wrote:
could the implementation be split in two files: one for legacy, one for
systemd? I think this could make reading the file easier.
Is it possible to determine at compile time whether the systemd component
is available? E.g. check
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122419/
---
(Updated Feb. 5, 2015, 8:58 a.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122402/#review75384
---
Ship it!
Nice simplification ^_-
- Martin Klapetek
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122413/#review75386
---
Ship it!
looks better, tough i think the setPaintRect() can
On Feb. 4, 2015, 12:59 p.m., Marco Martin wrote:
src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 115
https://git.reviewboard.kde.org/r/122413/diff/4/?file=346726#file346726line115
i'm not sure setting the panted rect in paint changes anything.
since it's done
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122402/#review75374
---
Ship it!
applets/clipboard/contents/ui/BarcodePage.qml
On Feb. 4, 2015, 12:05 p.m., Martin Klapetek wrote:
applets/clipboard/contents/ui/BarcodePage.qml, lines 103-106
https://git.reviewboard.kde.org/r/122402/diff/5/?file=346784#file346784line103
Why not switch the logic and put the show() inside the if? I mean the
return in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122419/#review75369
---
ksmserver/screenlocker/globalaccel.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122411/
---
(Updated Feb. 4, 2015, 11:01 a.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-desktop_master_qt5/979/changes
Changes:
[notmart] allow free resize on desktop
[me] Baloo KCM: Show proper icons (porting bug)
[kde] Sort apps by name if configured
--
[...truncated 851 lines...]
[ 21%] Built target
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122402/
---
(Updated Feb. 4, 2015, 1:21 p.m.)
Review request for Plasma and Sune
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/
---
(Updated Feb. 4, 2015, 12:26 p.m.)
Review request for Plasma.
Changes
On Fri, Jan 30, 2015 at 6:02 PM, Christoph Feck cf...@kde.org wrote:
On Friday 30 January 2015 11:41:42 Vasily Khoruzhick wrote:
I've read [1] and [2] and as far as I understand, dropping xembed
support was more political decision than technical difficulty.
Hi Christoph,
I am sorry to say
On Fri, Jan 30, 2015 at 8:04 PM, Martin Graesslin mgraess...@kde.org wrote:
Hi Martin,
Patches welcome. If you think it's important and that trivial you should be
able to do it, right?
Well, my area of expertise is embedded, kernel drivers and
bootloaders. But OK, I'll try to implement
a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/#review75383
---
applets/systemmonitor/common/contents/ui/Applet.qml
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/
---
(Updated Feb. 4, 2015, 1:59 p.m.)
Review request for Plasma.
On Feb. 4, 2015, 1:49 p.m., David Edmundson wrote:
applets/systemmonitor/common/contents/ui/Applet.qml, line 164
https://git.reviewboard.kde.org/r/122420/diff/2/?file=346883#file346883line164
what colour does the Plotter background default to?
There's potential for a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/#review75405
---
applets/systemmonitor/common/contents/ui/Applet.qml
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/
---
(Updated Feb. 4, 2015, 2:10 p.m.)
Review request for Plasma.
On Feb. 4, 2015, 2:06 p.m., David Edmundson wrote:
applets/systemmonitor/common/contents/ui/Applet.qml, line 121
https://git.reviewboard.kde.org/r/122420/diff/3/?file=346930#file346930line121
is this needed?
a cycle function is declared twice and seems to only used in
See http://build.kde.org/job/plasma-desktop_master_qt5/980/changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Feb. 4, 2015, 12:59 p.m., Marco Martin wrote:
src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 115
https://git.reviewboard.kde.org/r/122413/diff/4/?file=346726#file346726line115
i'm not sure setting the panted rect in paint changes anything.
since it's done
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122314/#review75400
---
Ship it!
Ship It!
- David Edmundson
On Jan. 30, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122312/#review75402
---
Ship it!
Seems sensible.
- Vishesh Handa
On Jan. 29,
On Feb. 4, 2015, 2:16 p.m., Kai Uwe Broulik wrote:
applets/clipboard/contents/ui/BarcodePage.qml, line 104
https://git.reviewboard.kde.org/r/122402/diff/6/?file=346839#file346839line104
running: visible ?
This is already done in the style
RotationAnimator on rotation {
On Feb. 4, 2015, 1:49 p.m., David Edmundson wrote:
applets/systemmonitor/common/contents/ui/Applet.qml, line 153
https://git.reviewboard.kde.org/r/122420/diff/2/?file=346883#file346883line153
I'm lost on something.
Why do we have a component singleValuePlotter and also
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122402/#review75407
---
Nice! +1
applets/clipboard/contents/ui/BarcodePage.qml
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122400/#review75415
---
could the implementation be split in two files: one for
On Feb. 4, 2015, 2:31 p.m., David Edmundson wrote:
Code is all fine.
By default each of these shows nothing; showing everything would be a
better default
The disk usage one doesn't seem to work at all. It's not even remembering
the options I select
It's auto scaling the
On Feb. 2, 2015, 6:26 p.m., David Edmundson wrote:
So you're basically wiping the source whenever we set it to invisible?
We could do that from in IconItem, and save duplicating this.
yeah, i agree it's a thing that looks like it's wanted in general, therefore
should go in IconItem
-
On Feb. 4, 2015, 11:28 a.m., David Edmundson wrote:
ksmserver/screenlocker/globalaccel.cpp, line 273
https://git.reviewboard.kde.org/r/122419/diff/1/?file=346752#file346752line273
you're not handling emacs style shortcuts here.
AFAIK emacs style shortcuts are not supported as
See http://build.kde.org/job/plasma-desktop_stable_qt5/63/changes
Changes:
[kde] Sort apps by name if configured
--
[...truncated 998 lines...]
[ 28%] Generating recentadaptor.moc
[ 28%] Generating screensaver_interface.moc
[ 28%] Generating
On Feb. 4, 2015, 8:43 p.m., Martin Gräßlin wrote:
could the implementation be split in two files: one for legacy, one for
systemd? I think this could make reading the file easier.
Is it possible to determine at compile time whether the systemd component
is available? E.g. check
On Feb. 4, 2015, 8:43 p.m., Martin Gräßlin wrote:
could the implementation be split in two files: one for legacy, one for
systemd? I think this could make reading the file easier.
Is it possible to determine at compile time whether the systemd component
is available? E.g. check
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122425/
---
Review request for Plasma and Martin Klapetek.
Bugs: 276196
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122318/#review75367
---
Ship it!
Ship It!
- David Edmundson
On Feb. 4, 2015, 9:37
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122402/
---
(Updated Feb. 4, 2015, 11:21 a.m.)
Review request for Plasma and Sune
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122318/
---
(Updated Feb. 4, 2015, 10:58 a.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-desktop_stable_qt5/64/changes
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On Feb. 4, 2015, 3:16 p.m., Kai Uwe Broulik wrote:
applets/clipboard/contents/ui/BarcodePage.qml, line 54
https://git.reviewboard.kde.org/r/122402/diff/6/?file=346839#file346839line54
Redundant tooltip
(I think somewhere there was a guideline saying that when a tooltip
On Feb. 4, 2015, 3:13 p.m., Martin Gräßlin wrote:
could the implementation be split in two files: one for legacy, one for
systemd? I think this could make reading the file easier.
Is it possible to determine at compile time whether the systemd component
is available? E.g. check
63 matches
Mail list logo
