Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-19 Thread Martin Gräßlin
On Feb. 19, 2015, 8:13 a.m., Martin Gräßlin wrote: src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp, line 152 https://git.reviewboard.kde.org/r/121856/diff/1/?file=338403#file338403line152 why is a method needed which wraps QWindow::fromWinId? Kai Uwe Broulik wrote:

Re: Review Request 122617: Require Qt 5.4

2015-02-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122617/ --- (Updated Feb. 19, 2015, 9:57 a.m.) Status -- This change has been

Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-19 Thread Kai Uwe Broulik
On Feb. 19, 2015, 7:13 vorm., Martin Gräßlin wrote: src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp, line 152 https://git.reviewboard.kde.org/r/121856/diff/1/?file=338403#file338403line152 why is a method needed which wraps QWindow::fromWinId? So the import is just using

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

2015-02-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122628/#review76280 --- Ship it! Others have pointed out some code issues, I haven't

Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-19 Thread Kai Uwe Broulik
On Feb. 19, 2015, 7:13 vorm., Martin Gräßlin wrote: src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp, line 152 https://git.reviewboard.kde.org/r/121856/diff/1/?file=338403#file338403line152 why is a method needed which wraps QWindow::fromWinId? Kai Uwe Broulik wrote:

Re: Review Request 122558: [screenlocker] Also grab XInput2 devices

2015-02-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122558/ --- (Updated Feb. 19, 2015, 1:10 p.m.) Status -- This change has been

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122382/ --- (Updated Feb. 19, 2015, 1:09 p.m.) Status -- This change has been

Re: Review Request 122512: [screenlocker] Add a KKeySequenceWidget to configuration interface

2015-02-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122512/ --- (Updated Feb. 19, 2015, 1:15 p.m.) Status -- This change has been

Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-19 Thread Martin Gräßlin
On Feb. 19, 2015, 8:13 a.m., Martin Gräßlin wrote: src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp, line 152 https://git.reviewboard.kde.org/r/121856/diff/1/?file=338403#file338403line152 why is a method needed which wraps QWindow::fromWinId? Kai Uwe Broulik wrote:

Re: Review Request 122619: [KPluginMetaData] Add support for Hidden key

2015-02-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122619/#review76291 --- +1 from here - Marco Martin On Feb. 18, 2015, 9:44 a.m.,

Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-19 Thread Kai Uwe Broulik
On Feb. 19, 2015, 2:11 nachm., Thomas Lübking wrote: I'd say that the window related functions that are not already supported (raise, lower, desktop, ...) should be added to the QML Window type (oo-style + declarative) and only the actual WindowSystem / WindowManager related stuff

Re: plasma-mediacenter in kdereview from extragear

2015-02-19 Thread Bhushan Shah
On Thu, Feb 19, 2015 at 8:22 PM, Bhushan Shah bhus...@gmail.com wrote: Looking forward to review from community Just for record : This mail is sent to both plasma-devel and kde-core-devel, reply to kde-core-devel -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

plasma-mediacenter in kdereview from extragear

2015-02-19 Thread Bhushan Shah
Hello, We want to move plasma-mediacenter to kde/workspace for releasing it with Plasma 5.x release cycle, Plasma media center is living room solution of plasma workspaces, it is integrated as shell package for PMC. Current code depends upon KDE Frameworks 5 (free of kdelibs4support),

Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121856/#review76323 --- Could you please add some documentation including example

Build failed in Jenkins: plasma-workspace_stable_qt5 #71

2015-02-19 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_stable_qt5/71/changes Changes: [jr] use ecm_optional_add_subdirectory instead of add_subdirectory for docs, the translations may be incomplete -- [...truncated 39 lines...] == Build Dependencies:

Build failed in Jenkins: khotkeys_stable_qt5 #10

2015-02-19 Thread KDE CI System
See http://build.kde.org/job/khotkeys_stable_qt5/10/changes Changes: [jr] use ecm_optional_add_subdirectory instead of add_subdirectory for docs, the translations may be incomplete -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by

Jenkins build is back to normal : khotkeys_master_qt5 #63

2015-02-19 Thread KDE CI System
See http://build.kde.org/job/khotkeys_master_qt5/63/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : khotkeys_stable_qt5 #11

2015-02-19 Thread KDE CI System
See http://build.kde.org/job/khotkeys_stable_qt5/11/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #1347

2015-02-19 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1347/changes Changes: [jr] use ecm_optional_add_subdirectory instead of add_subdirectory for docs, the translations may be incomplete -- [...truncated 43 lines...] kwallet - Branch master

Build failed in Jenkins: khotkeys_master_qt5 #62

2015-02-19 Thread KDE CI System
See http://build.kde.org/job/khotkeys_master_qt5/62/changes Changes: [jr] use ecm_optional_add_subdirectory instead of add_subdirectory for docs, the translations may be incomplete -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by

Jenkins build is back to normal : plasma-workspace_master_qt5 #1348

2015-02-19 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1348/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-workspace_stable_qt5 #72

2015-02-19 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_stable_qt5/72/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121807: Call forceActiveWindow on the sidePanel

2015-02-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121807/ --- (Updated Feb. 19, 2015, 5:21 nachm.) Status -- This change has been

Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121856/ --- (Updated Feb. 19, 2015, 5:25 nachm.) Review request for kwin and Plasma.

Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-19 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121856/#review76295 --- I'd say that the window related functions that are not

[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

2015-02-19 Thread Eugene Shalygin
https://bugs.kde.org/show_bug.cgi?id=344355 Eugene Shalygin eugene.shalygin+bugzilla@gmail.com changed: What|Removed |Added Platform|Other |Gentoo

[kio-extras] [Bug 344355] New: Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

2015-02-19 Thread Eugene Shalygin
https://bugs.kde.org/show_bug.cgi?id=344355 Bug ID: 344355 Summary: Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation Product: kio-extras Version: unspecified Platform: Other OS:

[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

2015-02-19 Thread Lukáš Tinkl
https://bugs.kde.org/show_bug.cgi?id=344355 Lukáš Tinkl lu...@kde.org changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

5.2.1 tars for packagers

2015-02-19 Thread Jonathan Riddell
5.2.1 tars are up on depot for packagers http://starsky.19inch.net/~jr/tmp/5.2.1-release-data Harald has been lovely and done a lot of work on releaseme which makes the tars, please check over for regressions. Release is due on Tuesday Jonathan ___

Re: Review Request 122619: [KPluginMetaData] Add support for Hidden key

2015-02-19 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122619/#review76322 --- Ship it! Now that there is a use case for it, it makes sense