Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff

2015-04-28 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated April 28, 2015, 1:36 p.m.) Status -- This change has been

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/ --- (Updated April 28, 2015, 1:16 p.m.) Review request for Plasma and KDE

Re: Review Request 123529: update kmenuedit docbook and screenshots to plasma 5.3

2015-04-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123529/#review79623 --- doc/index.docbook (line 182)

Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff

2015-04-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79622 --- Ship it! Ship It! - David Edmundson On April 27, 2015,

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-28 Thread Mark Gaiser
On apr 28, 2015, 7:11 p.m., Aleix Pol Gonzalez wrote: Can you add add_definitions(-DQT_NO_URL_CAST_FROM_STRING)? That will help spotting these issues. Ok, will add that and commit later tonight or tomorrow. - Mark --- This is

Re: Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/#review79645 --- Ship it! Can you add

Re: Review Request 123529: update kmenuedit docbook and screenshots to plasma 5.3

2015-04-28 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123529/ --- (Updated April 28, 2015, 7:26 nachm.) Review request for Documentation

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-28 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 --- People frequently request either new instance or close

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79647 --- applets/taskmanager/package/contents/ui/Task.qml (line 108)

Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff

2015-04-28 Thread Sebastian Kügler
On April 27, 2015, 2:56 p.m., David Edmundson wrote: Personally I don't think anyone needs to open the accounts KCM so often we need to link to it. I suspect it'll get more accidental opens than legit ones. The other changes seems good though. Lukáš Tinkl wrote: I for one

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-28 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79620 --- We get many crashes since porting KCM modules to QML, see bug

Plasma 5.3 is out

2015-04-28 Thread Jonathan Riddell
https://www.kde.org/announcements/plasma-5.3.0.php party time ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123539/#review79626 --- Ship it! Ship It! - Marco Martin On April 27, 2015, 9:35

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread Heiko Tietze
On April 27, 2015, 10:02 nachm., andreas kainz wrote: colors maybe green and white as used in the mount symbol Graphics should be theme aware. Please make sure badges are readable with Breeze Dark or Wonton Soup. - Heiko --- This

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-28 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 28, 2015, 2:38 p.m.) Review request for KDE Frameworks,

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123539/#review79628 --- Ship it! Ship It! - Andrew Lake On April 27, 2015, 9:35

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79631 --- src/core/global.cpp (line 396)

Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-28 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

2015-04-28 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/ --- (Updated avr. 28, 2015, 8:45 après-midi) Review request for Plasma.

Review Request 123540: Don't trigger updates when no actual updates happened + never modify the KNotification object from the popup plugin

2015-04-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123540/ --- Review request for KDE Frameworks and Plasma. Bugs: 345973

Review Request 123544: kioclient ls: properly construct QUrl.

2015-04-28 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123544/ --- Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools

Re: Review Request 123540: Don't trigger updates when no actual updates happened + never modify the KNotification object from the popup plugin

2015-04-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123540/#review79619 --- Ship it! Ship It! - David Edmundson On April 28, 2015,

Re: Review Request 123540: Don't trigger updates when no actual updates happened + never modify the KNotification object from the popup plugin

2015-04-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123540/ --- (Updated April 28, 2015, 9:48 a.m.) Status -- This change has been

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123539/ --- (Updated April 28, 2015, 6:34 nachm.) Review request for Plasma, KDE

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123539/#review79642 --- code looks good.

Re: Review Request 123535: Visible error messagebox on fatal loading errors

2015-04-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123535/ --- (Updated April 28, 2015, 7:56 a.m.) Status -- This change has been

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79629 --- src/core/global.cpp (line 396)