Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:12 p.m.) Review request for KDE Frameworks and

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
On May 12, 2015, 3:52 p.m., David Edmundson wrote: src/kdeclarative/qmlobjectsharedengine.cpp, line 62 https://git.reviewboard.kde.org/r/123735/diff/2/?file=368373#file368373line62 this needs to be initialised. line 65 QQmlEngine *QmlObjectSharedEnginePrivate::s_engine = 0; On

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80252 --- src/kdeclarative/qmlobjectsharedengine.h (line 57)

Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-12 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop

Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80256 --- applets/taskmanager/package/contents/ui/main.qml (line 237)

Re: Review Request 123740: Add timezone filtering by region too

2015-05-12 Thread Martin Klapetek
On May 12, 2015, 10:23 p.m., David Edmundson wrote: applets/digital-clock/plugin/timezonemodel.h, line 34 https://git.reviewboard.kde.org/r/123740/diff/1/?file=368406#file368406line34 it's worth always having a NOTIFY, otherwise if in the future anything binds to filterString

Re: Review Request 123740: Add timezone filtering by region too

2015-05-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123740/ --- (Updated May 12, 2015, 8:53 p.m.) Status -- This change has been

Re: Review Request 123746: Workaround DBusMenuQt's design

2015-05-12 Thread Aleix Pol Gonzalez
On May 13, 2015, 4:49 a.m., Aleix Pol Gonzalez wrote: Has DBusMenuQt been fixed? Or is it beyond our reach for a weird reason? PS: I don't mind the workaround as long as we fix upstream too. - Aleix --- This is an automatically

Re: Review Request 123727: [klipper] Ensure global shortcut actions work

2015-05-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123727/ --- (Updated May 12, 2015, 9:39 a.m.) Status -- This change has been

Re: Review Request 123426: Kickoff is not mounting removable devices and shows Invalid URL

2015-05-12 Thread Konrad Materka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123426/ --- (Updated May 12, 2015, 9:32 a.m.) Status -- This change has been

Re: testing the single QQmlEngine plasmashell

2015-05-12 Thread Marco Martin
On Tuesday 12 May 2015, Aleix Pol wrote: Hi, I wanted to give it a go as well, and so I did. :D http://proli.net/meu/kde/massif.out.3278-beforeBranchChange http://proli.net/meu/kde/massif.out.5283-afterBranchChange http://proli.net/meu/kde/massif.out.5759-afterBranchChange this is after

Re: testing the single QQmlEngine plasmashell

2015-05-12 Thread Aleix Pol
On Mon, May 11, 2015 at 6:20 PM, Marco Martin notm...@gmail.com wrote: On Monday 11 May 2015, Marco Martin wrote: please test it to see if there are obvious regressions, if it's faster or slower, more or less crashy, if it takes more or less memory (dere it slims by about 25 MB on a 32bit

Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Review Request 123736: single QQmlEngine for all applets

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123736/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80241 --- Can you make the diff against the branch root instead of

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 3:35 p.m.) Review request for KDE Frameworks and

Re: Review Request 123736: single QQmlEngine for all applets

2015-05-12 Thread Marco Martin
On May 12, 2015, 3:44 p.m., Kai Uwe Broulik wrote: For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp will still have own engine You mean SharedEngine? :) that :) - Marco --- This is an automatically

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80249 --- src/kdeclarative/qmlobject.h (line 81)