Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Monday 18 May 2015, Ivan Čukić wrote: While I'm usually more conservative, I do think that something more decisive should be done in this case (and cases like these). While we do not want to break everything with each new release (wink wink ghm ghm nudge nudge), I don't think we want to

Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Tuesday 19 May 2015, Marco Martin wrote: On Monday 18 May 2015, Ivan Čukić wrote: While I'm usually more conservative, I do think that something more decisive should be done in this case (and cases like these). While we do not want to break everything with each new release (wink wink ghm

Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Monday 18 May 2015, David Edmundson wrote: Now to make you hate me. I have a crash, https://paste.kde.org/ppeqjl1c1 That's running: kdeclarative - your branch plasma-framework - your branch plsama-workspace - master (which is pretty close to running latest frameworks with Plasma 5.3)

Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Monday 18 May 2015, Ivan Čukić wrote: - make it opt-in (as Marco says) - deprecate it - report notifications to the user 'this applet might make your desktop unstable' for all used applets that haven't opted-in - this would serve as a notification both to the users and the developers of

Re: Planning merging the single qqml engine

2015-05-19 Thread David Edmundson
On Mon, May 18, 2015 at 8:28 PM, Marco Martin notm...@gmail.com wrote: Hi all, I think the branches for the single shared qqmlengine are pretty much ready (few cleanups upcoming days), seems pretty stable here.. did someone ran the branch for a while as well? In the end i managed to get a

Re: Plasma 5 is awesome...and some help required with build instructions

2015-05-19 Thread David Edmundson
On Tue, May 19, 2015 at 2:10 AM, Siddhartha sh.siddhar...@gmail.com wrote: On 18 May 2015 at 22:58, David Edmundson da...@davidedmundson.co.uk wrote: Just setting up on a new machine and thought I'd try following these instructions exactly, the way a new developer would. I got stuck on

Re: Plasma 5 is awesome...and some help required with build instructions

2015-05-19 Thread Martin Klapetek
On Tue, May 19, 2015 at 12:30 PM, David Edmundson da...@davidedmundson.co.uk wrote: But someone who wrote this must have been a Kubuntu user, there is a list of dependencies. That was added by me about 2 weeks ago when I tried to follow that setup as well on a clean system where I had to

Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Tuesday 19 May 2015, David Edmundson wrote: I would like to have all set before frameworks 5.11 One thing you and I talked about once was having the shell have a hook in p-f to call a static method setting what version of plasma-framework it was expecting. Would that be a suitable

Re: Review Request 123846: Enable translations for devicenotifications dataengine

2015-05-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123846/#review80617 --- +1 on the plasma side, for backporting too - David Edmundson

Review Request 123854: Add missing TRANSLATION_DOMAIN for dataengines keystae, network, rss, weather

2015-05-19 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123854/ --- Review request for Localization and Translation (l10n) and Plasma.

Re: Review Request 123854: Add missing TRANSLATION_DOMAIN for dataengines keystae, network, rss, weather

2015-05-19 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123854/ --- (Updated Mai 19, 2015, 12:02 nachm.) Review request for Localization and

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-19 Thread Vishesh Handa
On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: src/kdeclarative/qmlobjectsharedengine.cpp, line 60 https://git.reviewboard.kde.org/r/123735/diff/8/?file=370102#file370102line60 I'm probably missing some parts of the picture. Could you please explain why this needs to be static?

Re: Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.

2015-05-19 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123682/ --- (Updated May 19, 2015, 2:47 p.m.) Review request for Plasma. Changes

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-19 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80630 --- src/kdeclarative/qmlobjectsharedengine.cpp (line 41)

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-19 Thread Marco Martin
On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: src/kdeclarative/qmlobjectsharedengine.cpp, line 60 https://git.reviewboard.kde.org/r/123735/diff/8/?file=370102#file370102line60 I'm probably missing some parts of the picture. Could you please explain why this needs to be static?

Review Request 123855: Split obsolete language docbook into translations + format docbook

2015-05-19 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123855/ --- Review request for Documentation, Plasma, John Layt, and Sebastian Kügler.

Re: Review Request 123854: Add missing TRANSLATION_DOMAIN for dataengines keystae, network, rss, weather

2015-05-19 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123854/ --- (Updated May 19, 2015, 6:26 p.m.) Status -- This change has been

[Breeze] [Bug 347547] Qt4 applications use wrong palette and icons w/ Breeze

2015-05-19 Thread Matthias Dahl
https://bugs.kde.org/show_bug.cgi?id=347547 --- Comment #8 from Matthias Dahl ua_bugz_...@binary-island.eu --- Further investigation revealed the following: 1) If KDE_SESSION_VERSION=5, kdeglobals is first searched for in ~/.kde/ while with KDE_SESSION_VERSION=4 it is ~/.kde4/. This comes as a

[Breeze] [Bug 347547] Qt4 applications use wrong palette and icons w/ Breeze

2015-05-19 Thread Matthias Dahl
https://bugs.kde.org/show_bug.cgi?id=347547 --- Comment #9 from Matthias Dahl ua_bugz_...@binary-island.eu --- I forgot to mention in (1): Setting KDE_SESSION_VERSION to either 4 or 5 only influences whether .kde4 or .kde is first searched, but after that, .kde4 is always searched as well. So

Re: Review Request 123854: Add missing TRANSLATION_DOMAIN for dataengines keystae, network, rss, weather

2015-05-19 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123854/#review80637 --- Ship it! Yes, please backport as well - Lukáš Tinkl On

Re: Review Request 123854: Add missing TRANSLATION_DOMAIN for dataengines keystae, network, rss, weather

2015-05-19 Thread Luigi Toscano
On May 19, 2015, 7:21 p.m., Lukáš Tinkl wrote: Yes, please backport as well Burkhard, please commit to Plasma/5.3; I will do the same, then merge into master. - Luigi --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 123846: Enable translations for devicenotifications dataengine

2015-05-19 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123846/ --- (Updated May 19, 2015, 8:39 p.m.) Status -- This change has been

Re: Review Request 123783: Adjust showing desktop behavior

2015-05-19 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123783/ --- (Updated May 19, 2015, 9:13 p.m.) Status -- This change has been

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-19 Thread Marco Martin
On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: src/kdeclarative/qmlobjectsharedengine.cpp, line 60 https://git.reviewboard.kde.org/r/123735/diff/8/?file=370102#file370102line60 I'm probably missing some parts of the picture. Could you please explain why this needs to be static?

Re: Plasma 5 is awesome...and some help required with build instructions

2015-05-19 Thread Siddhartha
On 19 May 2015 at 16:00, David Edmundson da...@davidedmundson.co.uk wrote: Yes, it's only a problem on Kubuntu. It's also solvable by compiling Qt, but I don't really want to have to force new devs to do that unless I have to. We should talk to the Kubuntu devs to see why its hardcoded that