Re: Review Request 123888: [krunner] Bring back history

2015-05-24 Thread Kai Uwe Broulik
On Mai 24, 2015, 8:44 vorm., Heiko Tietze wrote: It's not intuitive to type 'pla' and get a list (with radio buttons!) that contains 'dolphin'. Expanding the dropdown without content should show previous search items and 'pla' could prioritize stuff from the history. And I'm

Re: Review Request 123888: [krunner] Bring back history

2015-05-24 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/#review80764 --- It's not intuitive to type 'pla' and get a list (with radio

Jenkins-kde-ci: plasma-desktop master kf5-qt5 ยป Linux,gcc - Build # 7 - Fixed!

2015-05-24 Thread no-reply
We thank you for fixing your build!___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

2015-05-24 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123884/ --- (Updated mai 24, 2015, 9:44 matin) Review request for Plasma. Changes

Re: Review Request 123877: [digital-clock] Bring back font family and color options

2015-05-24 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review80767 --- In addition to the comments, just one nitpick: The first

Re: Review Request 123877: [digital-clock] Bring back font family and color options

2015-05-24 Thread Thomas Pfeiffer
On May 22, 2015, 2:14 a.m., Andrew Lake wrote: Just a couple observations: 1. I think it might be helpful to have a way to restore using the default font specified in the fonts kcm without having to explicitly know/set the font to match the default. A checkbox to enable/disable

Re: Review Request 123877: [digital-clock] Bring back font family and color options

2015-05-24 Thread Thomas Pfeiffer
On May 22, 2015, 8:58 a.m., Martin Klapetek wrote: +1 to the font, but color...? Do we really want/need that option? Agreed. We should not add options if we're unsure of whether people actually want/need them. Simple by default, powerful _when needed_. Let's keep it out for now and wait

Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

2015-05-24 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123884/#review80783 --- This is a regression; the handling got lost when the Desktop

Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

2015-05-24 Thread Eike Hein
On May 24, 2015, 8:12 p.m., Eike Hein wrote: Please adapt this to match up with http://quickgit.kde.org/?p=plasma-desktop.gita=blobh=e15933a3d6310cf053d299d32a9c0179d1332074hb=bc4656c9f0405afd1eb0a09ced32d1f2b44f0b52f=containments%2Ffolder%2Fpackage%2Fcontents%2Fui%2Fmain.qml#l61, in

Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

2015-05-24 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123884/#review80784 --- Please adapt this to match up with