Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Xen
/ On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: // I actually really like it, perhaps we should make KDialog passive popup not set an icon by default now // // Philipp A. wrote: // i also like the no-icon no-space version. why add something that just takes up unnecessary

Re: Plasma-devel Digest, Vol 84, Issue 78

2015-06-23 Thread Xen
plasma-devel-requ...@kde.org schreef op 23-6-2015 om 14:00: Today's Topics: 1. Re: Review Request 124151: Add a default icon to notifications popup (Kai Uwe Broulik) 2. Re: Review Request 124151: Add a default icon to notifications popup (Philipp A.) Screenshot

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Eike Hein
On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: I actually really like it, perhaps we should make KDialog passive popup not set an icon by default now Philipp A. wrote: i also like the no-icon no-space version. why add something that just takes up unnecessary space and has

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Xen
/ On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: // I actually really like it, perhaps we should make KDialog passive popup not set an icon by default now // // Philipp A. wrote: // i also like the no-icon no-space version. why add something that just takes up unnecessary

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Martin Klapetek
On Tue, Jun 23, 2015 at 5:46 PM, Xen l...@xenhideout.nl wrote: * On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: ** I actually really like it, perhaps we should make KDialog passive popup not set an icon by default now * * Philipp A. wrote: ** i also like the no-icon no-space

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/#review81712 --- Ship it! Looks cleaner indeed, thanks. - Sebastian Kügler

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/ --- (Updated June 23, 2015, 11:42 a.m.) Review request for Plasma. Changes

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/#review81698 --- I actually really like it, perhaps we should make KDialog

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Philipp A.
On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: I actually really like it, perhaps we should make KDialog passive popup not set an icon by default now i also like the no-icon no-space version. why add something that just takes up unnecessary space and has no informational value? -