Re: Review Request 124668: Re-render 5.4 wallpapers with 4x antialiasing and a split noise, compress them.

2015-08-09 Thread Nikita Skovoroda
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124668/ --- (Updated Авг. 9, 2015, 7:23 д.п.) Review request for Plasma, David

Re: Review Request 124668: Re-render 5.4 wallpapers with 4x antialiasing and a split noise, compress them.

2015-08-09 Thread Nikita Skovoroda
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124668/#review83592 --- Highlighted pixelated lines in the «before» version. File

Re: Review Request 124668: Re-render 5.4 wallpapers with 4x antialiasing and a split noise, compress them.

2015-08-09 Thread Nikita Skovoroda
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124668/#review83593 --- File Attachment: 3200x2000 before (top-left part) -

Re: Review Request 124668: Re-render 5.4 wallpapers with 4x antialiasing and a split noise, compress them.

2015-08-09 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124668/#review83594 --- I've now corrected the issue with Reviewboard - for some

Re: Review Request 124665: Remove unused dependencies.

2015-08-09 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124665/ --- (Updated Aug. 9, 2015, 3:35 p.m.) Status -- This change has been

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-08-09 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124675/ --- (Updated Aug. 9, 2015, 7:06 p.m.) Status -- This change has been

Re: Review Request 124668: Re-render 5.4 wallpapers with 4x antialiasing and a split noise, compress them.

2015-08-09 Thread Ken Vermette
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124668/#review83608 --- Looks good to me; if we can get these in as a bug fix for 5.4

Re: Review Request 124589: Add Disk Quota Plasmoid

2015-08-09 Thread Kai Uwe Broulik
On Aug. 6, 2015, 2:12 nachm., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-08-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124675/#review83621 --- We are not shipping commented out code. The obvious side

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-08-09 Thread Gregor Mi
On Aug. 9, 2015, 6:18 p.m., David Edmundson wrote: We are not shipping commented out code. The obvious side effect is that people can't see which apps are disabled, which is why this code exists. I will re-poke the VDG for comments, as they don't seem to have responded on the

Re: Review Request 124589: Add Disk Quota Plasmoid

2015-08-09 Thread Dominik Haumann
On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: applets/diskquota/plugin/DiskQuota.cpp, line 158 https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158 You should search for quota and filelight programs during startup only. You can send a notification if

Re: Review Request 124548: Proofread kgamma kcm docbook to kf5

2015-08-09 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124548/#review83607 --- Ship it! Quite obvious replacement, I think we don't need

Re: Review Request 124495: Proofread ksysguard docbook for kf5

2015-08-09 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124495/#review83606 --- Review on terminology fine by me; waiting a bit on the

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-08-09 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124675/ --- (Updated Aug. 9, 2015, 5:46 p.m.) Review request for Plasma. Bugs:

Re: Review Request 124668: Re-render 5.4 wallpapers with 4x antialiasing and a split noise, compress them.

2015-08-09 Thread Nikita Skovoroda
On Авг. 9, 2015, 2:51 п.п., Ken Vermette wrote: Looks good to me; if we can get these in as a bug fix for 5.4 I'd like to see that. Should I treat this as a «Ship it»? - Nikita --- This is an automatically generated e-mail. To

Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-08-09 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124675/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 124668: Re-render 5.4 wallpapers with 4x antialiasing and a split noise, compress them.

2015-08-09 Thread Nikita Skovoroda
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124668/ --- (Updated Aug. 9, 2015, 5:55 p.m.) Status -- This change has been