Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/ --- (Updated Oct. 28, 2015, 4:37 p.m.) Review request for Plasma and Martin

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/#review87575 --- ksmserver/screenlocker/CMakeLists.txt (line 41)

Re: Review Request 125836: Support request resizing on ShellSurface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125836/#review87580 --- Looks good to me. - Sebastian Kügler On Oct. 28, 2015,

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/#review87570 --- Looks good to me, +1 - Martin Gräßlin On Oct. 28, 2015,

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 28, 2015, 10:15 a.m., Marco Martin wrote: > > not much a fan of adding a public library there, but i guess there aren't > > many other ways. Could it be put into plasma-workspace instead? > > Daniel Vrátil wrote: > Please don't, unless you want to have Akonadi dependency in >

Re: Review Request 125839: Quicklaunch: Show default icon when launcher icon is empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125839/ --- (Updated Oct. 28, 2015, 1:08 p.m.) Status -- This change has been

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/ --- (Updated Oct. 28, 2015, 7:25 p.m.) Review request for Plasma and Martin

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

> On Oct. 28, 2015, 6:18 p.m., Hrvoje Senjan wrote: > > ksmserver/screenlocker/CMakeLists.txt, line 41 > > > > > > if this will be shared lib, please extract private vs. public deps. I am not sure how to extract

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 28, 2015, 10:15 a.m., Marco Martin wrote: > > not much a fan of adding a public library there, but i guess there aren't > > many other ways. Could it be put into plasma-workspace instead? > > Daniel Vrátil wrote: > Please don't, unless you want to have Akonadi dependency in >

Re: Review Request 125839: Quicklaunch: Show default icon when launcher icon is empty

> On Oct. 28, 2015, 12:24 p.m., David Edmundson wrote: > > applets/quicklaunch/package/contents/ui/IconItem.qml, line 35 > > > > > > sexy QML tip for future > > > > you can also write this as > > >

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 28, 2015, 10:15 a.m., Marco Martin wrote: > > not much a fan of adding a public library there, but i guess there aren't > > many other ways. Could it be put into plasma-workspace instead? > > Daniel Vrátil wrote: > Please don't, unless you want to have Akonadi dependency in >

Review Request 125839: Quicklaunch: Show default icon when launcher icon is empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125839/ --- Review request for Plasma. Repository: kdeplasma-addons Description

Re: Review Request 125828: Support request moving on ShellSurface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125828/#review87572 --- Looks good to me. - Sebastian Kügler On Oct. 27, 2015,

Re: Review Request 125839: Quicklaunch: Show default icon when launcher icon is empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125839/#review87574 --- Ship it!

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

> On Oct. 28, 2015, 3:45 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/CMakeLists.txt, line 46 > > > > > > I thought we got rid of that one in the other review request... > > Bhushan Shah wrote: >

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/#review87588 --- ksmserver/screenlocker/CMakeLists.txt (line 46)

Review Request 125841: toggle minimize api for plasma windowmanagement in kwayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125841/ --- Review request for Plasma and Eike Hein. Repository: kwayland

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

> On Oct. 28, 2015, 8:15 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/CMakeLists.txt, line 46 > > > > > > I thought we got rid of that one in the other review request... Yes but that is another review

Re: Review Request 125817: Add plugin system for Calendar events

> On Ott. 28, 2015, 10:15 a.m., Marco Martin wrote: > > not much a fan of adding a public library there, but i guess there aren't > > many other ways. Could it be put into plasma-workspace instead? > > Daniel Vrátil wrote: > Please don't, unless you want to have Akonadi dependency in >

Review Request 125837: [screenlocker] Remove libkworkspace dep

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125837/ --- Review request for Plasma, David Edmundson and Martin Gräßlin.

Re: Review Request 125837: [screenlocker] Remove libkworkspace dep

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125837/#review87567 --- +1 from my side. - Martin Gräßlin On Oct. 28, 2015, 11:13

Re: Review Request 125743: Keep aspect ratio in default KSplash background

> On Oct. 21, 2015, 9:05 p.m., David Edmundson wrote: > > Makes sense for the default behaviours to match > > Martin Klapetek wrote: > Match what? Do we have similar code elsewhere? Btw Hrvoje reported that > this is less than ideal as it "letterboxes" the background, which I was a bit >

Re: Review Request 125743: Keep aspect ratio in default KSplash background

> On Oct. 21, 2015, 11:05 p.m., David Edmundson wrote: > > Makes sense for the default behaviours to match Match what? Do we have similar code elsewhere? Btw Hrvoje reported that this is less than ideal as it "letterboxes" the background, which I was a bit worried about. So, I'm thinking

Re: Review Request 125837: [screenlocker] Remove libkworkspace dep

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125837/ --- (Updated Oct. 28, 2015, 4:41 p.m.) Status -- This change has been

Re: Review Request 125743: Keep aspect ratio in default KSplash background

> On Oct. 21, 2015, 11:05 p.m., David Edmundson wrote: > > Makes sense for the default behaviours to match > > Martin Klapetek wrote: > Match what? Do we have similar code elsewhere? Btw Hrvoje reported that > this is less than ideal as it "letterboxes" the background, which I was a bit >

Re: Review Request 125837: [screenlocker] Remove libkworkspace dep

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125837/#review87599 --- Ship it! Ship It! - David Edmundson On Oct. 28, 2015,

Re: Review Request 125841: toggle minimize api for plasma windowmanagement in kwayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125841/#review87598 --- src/client/plasmawindowmanagement.h (line 229)

Re: Review Request 125841: toggle minimize api for plasma windowmanagement in kwayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125841/ --- (Updated Oct. 28, 2015, 4:43 p.m.) Status -- This change has been

Review Request 125842: make most windows minimizable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125842/ --- Review request for kwin and Plasma. Repository: kwin Description

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87606 --- Looks good to me now, thanks Martin!!

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 23, 2015, 6:57 a.m., Martin Gräßlin wrote: > > xembedsniproxy/fdoselectionmanager.cpp, line 49 > > > > > > my search for selectionAtom only find's this usage. Given that I > > recommend to skip using

Review Request 125845: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125845/ --- Review request for Plasma. Repository: khotkeys Description ---

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 28, 2015, 9:15 a.m., Marco Martin wrote: > > not much a fan of adding a public library there, but i guess there aren't > > many other ways. Could it be put into plasma-workspace instead? > > Daniel Vrátil wrote: > Please don't, unless you want to have Akonadi dependency in >

Review Request 125843: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125843/ --- Review request for Plasma and Martin Gräßlin. Repository: kwin

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- (Updated Oct. 28, 2015, 5:36 p.m.) Review request for Plasma. Changes

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- (Updated Oct. 28, 2015, 6:18 p.m.) Review request for Plasma and Daniel

Review Request 125844: Use PATH_VARS feature of ecm_configure_package_config_file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125844/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125770: Emit correct signal for notifications expiring

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125770/#review87610 --- Ship it! Ship It! - Martin Klapetek On Oct. 25, 2015,

Re: Review Request 125770: Emit correct signal for notifications expiring

> On Oct. 28, 2015, 7:09 p.m., Martin Klapetek wrote: > > Ship It! ...though don't put that gnome link in the commit please. - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125618: Fixes to KameraConfigDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125618/#review87613 --- Ship it! tested it and it works for me - Marcus Meissner

Re: Review Request 125849: [kscreenlocker_greet] Port fallback theme to SessionsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125849/#review87638 --- It shows it blocks https://git.reviewboard.kde.org/r/125850/

Review Request 125848: [kscreenlocker_greet] Fix QML fallback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125848/ --- Review request for Plasma and Martin Gräßlin. Repository:

Review Request 125851: [kscreenlocker] Remove KWorkspace dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125851/ --- Review request for Plasma and Martin Gräßlin. Repository:

Re: Review Request 125844: Use PATH_VARS feature of ecm_configure_package_config_file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125844/ --- (Updated Oct. 28, 2015, 8:33 p.m.) Status -- This change has been

Re: Review Request 125705: Use LANG for month names in calendar applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87617 --- So...any word on this? - Martin Klapetek On Oct. 20, 2015,

Re: Review Request 125843: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125843/#review87614 --- Ship it! Ship It! - Alex Merry On Oct. 28, 2015, 5:31

Re: Review Request 125844: Use PATH_VARS feature of ecm_configure_package_config_file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125844/#review87615 --- Ship it! Ship It! - Alex Merry On Oct. 28, 2015, 5:40

Re: Review Request 125845: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125845/#review87616 --- Ship it! Ship It! - Alex Merry On Oct. 28, 2015, 5:44

Review Request 125849: [kscreenlocker_greet] Port fallback theme to SessionsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125849/ --- Review request for Plasma and Martin Gräßlin. Repository:

Re: Review Request 125845: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125845/ --- (Updated Oct. 28, 2015, 8:33 p.m.) Status -- This change has been

Re: Review Request 125843: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125843/ --- (Updated Oct. 28, 2015, 8:33 p.m.) Status -- This change has been

Re: Review Request 125849: [kscreenlocker_greet] Port fallback theme to SessionsModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125849/ --- (Updated Okt. 28, 2015, 8:52 nachm.) Review request for Plasma and

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote: > > As always: If you want design or usability input, please provide a > > screenshot. We cannot read the code. Thanks. > > Eike Hein wrote: > Thomas, all this does is not grey out the text in Task Manager button > labels when a

[Plasma Workspace Wallpapers] [Bug 354526] New: Background and panel disappears from virtual desktop

https://bugs.kde.org/show_bug.cgi?id=354526 Bug ID: 354526 Summary: Background and panel disappears from virtual desktop Product: Plasma Workspace Wallpapers Version: 5.4.2 Platform: Fedora RPMs OS: Linux Status:

Re: Review Request 125705: Use LANG for month names in calendar applet

> On oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote: > > So...any word on this? Re-reading your comment, if i understand it correctly, you claim it is a bug in Qt that it does obey LC_DATE for month names when according to you LC_DATE is only for the formatting and should be using LANG,

Re: Review Request 125705: Use LANG for month names in calendar applet

> On Oct. 28, 2015, 9:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the

Re: Review Request 125705: Use LANG for month names in calendar applet

> On Oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87563 ---

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87564 --- not much a fan of adding a public library there, but i guess

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 28, 2015, 10:15 a.m., Marco Martin wrote: > > not much a fan of adding a public library there, but i guess there aren't > > many other ways. Could it be put into plasma-workspace instead? Please don't, unless you want to have Akonadi dependency in plasma-workspace. This way we in

Review Request 125836: Support request resizing on ShellSurface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125836/ --- Review request for Plasma. Repository: kwayland Description ---

Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125838/ --- Review request for Plasma and Martin Gräßlin. Repository:

Re: Review Request 125817: Add plugin system for Calendar events

> On Oct. 28, 2015, 9:15 a.m., Marco Martin wrote: > > not much a fan of adding a public library there, but i guess there aren't > > many other ways. Could it be put into plasma-workspace instead? > > Daniel Vrátil wrote: > Please don't, unless you want to have Akonadi dependency in >