[Powerdevil] [Bug 354623] Full charge not trigger notification

2015-10-31 Thread Anthony via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354623 --- Comment #4 from Anthony --- (In reply to Kai Uwe Broulik from comment #3) > Also, please check the output of upower -d to ensure the driver actually > reports "fully charged" state Yes, 'upower -d' reports "fully charged". -- You are receiving th

Re: Review Request 125888: systemmonitor: Don't link to unused libraries

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125888/ --- (Updated Oct. 31, 2015, 9:46 p.m.) Status -- This change has been ma

Re: Review Request 125894: calendar: Don't use current day number in goToMonth

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125894/ --- (Updated Oct. 31, 2015, 9:28 p.m.) Status -- This change has been ma

Re: Review Request 125899: calendar: Make the entire header area clickable

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125899/ --- (Updated Oct. 31, 2015, 9:28 p.m.) Status -- This change has been ma

Re: Review Request 125893: calendar: Fix updating decade overview

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125893/ --- (Updated Oct. 31, 2015, 9:28 p.m.) Status -- This change has been ma

Re: Review Request 125896: [desktopcontainment] Clip applet container while resizing it

2015-10-31 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125896/#review87789 --- Ship it! Ship It! - Eike Hein On Oct. 31, 2015, 4:05 p.m.,

Re: Review Request 125899: calendar: Make the entire header area clickable

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125899/#review87788 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 31, 2015, 8:11

Review Request 125899: calendar: Make the entire header area clickable

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125899/ --- Review request for Plasma and KDE Usability. Repository: plasma-framework

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

2015-10-31 Thread David Rosca
> On Oct. 31, 2015, 5:33 p.m., Thomas Pfeiffer wrote: > > Thanks for adding usability! > > I agree with Kai that the whole header area should be scrollable instead of > > just the label. > > One thing to make sure (if that is even affected by this change at all) is > > that when we have events

Re: Review Request 125897: [Clipboard plasmoid] Fix line breaks

2015-10-31 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125897/#review87786 --- Showing the whitespaces only for the first line does not make

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

2015-10-31 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125891/#review87784 --- Thanks for adding usability! I agree with Kai that the whole h

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-10-31 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125898/#review87783 --- All fine from the usability side, looks much better now! - Th

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125898/ --- (Updated Okt. 31, 2015, 5:21 nachm.) Review request for Plasma, KDE Usabi

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

2015-10-31 Thread Kai Uwe Broulik
> On Okt. 31, 2015, 3:39 nachm., Kai Uwe Broulik wrote: > > I'm not sure, perhaps add Usability. > > One thing I would like, though, is the entire header area being scrollable > > rather than the width-changing label. > > Also please make sure it doesn't break the MultiPointTouchArea. > > David

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125898/ --- (Updated Okt. 31, 2015, 4:51 nachm.) Review request for Plasma, KDE Usabi

Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125898/ --- Review request for Plasma, KDE Usability and Martin Gräßlin. Bugs: 354602

Review Request 125897: [Clipboard plasmoid] Fix line breaks

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125897/ --- Review request for Plasma, KDE Usability and Martin Gräßlin. Repository:

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

2015-10-31 Thread David Rosca
> On Oct. 31, 2015, 3:39 p.m., Kai Uwe Broulik wrote: > > I'm not sure, perhaps add Usability. > > One thing I would like, though, is the entire header area being scrollable > > rather than the width-changing label. > > Also please make sure it doesn't break the MultiPointTouchArea. I got used

Review Request 125896: [desktopcontainment] Clip applet container while resizing it

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125896/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 125894: calendar: Don't use current day number in goToMonth

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125894/#review87779 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 31, 2015, 2:59

Re: Review Request 125893: calendar: Fix updating decade overview

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125893/#review87778 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 31, 2015, 2:59

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125891/#review8 --- I'm not sure, perhaps add Usability. One thing I would like, t

Re: Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125895/ --- (Updated Oct. 31, 2015, 3:29 p.m.) Status -- This change has been ma

Re: Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

2015-10-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125895/#review87776 --- Ship it! - David Edmundson On Oct. 31, 2015, 3:25 p.m., Kai

Re: Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125895/ --- (Updated Okt. 31, 2015, 3:25 nachm.) Review request for Plasma. Changes

Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125895/ --- Review request for Plasma. Repository: plasma-sdk Description ---

Review Request 125893: calendar: Fix updating decade overview

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125893/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125891/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 125894: calendar: Don't use current day number in goToMonth

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125894/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Powerdevil] [Bug 354623] Full charge not trigger notification

2015-10-31 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354623 --- Comment #3 from Kai Uwe Broulik --- Also, please check the output of upower -d to ensure the driver actually reports "fully charged" state -- You are receiving this mail because: You are the assignee for the bug. __

[Powerdevil] [Bug 354623] Full charge not trigger notification

2015-10-31 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354623 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #2 from Ka

[Powerdevil] [Bug 354623] Full charge not trigger notification

2015-10-31 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354623 Martin Klapetek changed: What|Removed |Added Ever confirmed|0 |1 CC|

Re: Review Request 125849: [kscreenlocker_greet] Port fallback theme to SessionsModel

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125849/ --- (Updated Oct. 31, 2015, 2:18 p.m.) Status -- This change has been ma

Re: Review Request 125678: Introduce User Switcher plasmoid

2015-10-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125678/ --- (Updated Oct. 31, 2015, 1:36 p.m.) Status -- This change has been ma

Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

2015-10-31 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125892/ --- (Updated Oct. 31, 2015, 6:11 p.m.) Review request for Plasma, David Edmun

Re: Review Request 125888: systemmonitor: Don't link to unused libraries

2015-10-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125888/#review87775 --- Ship it! Ship It! - David Edmundson On Oct. 31, 2015, 10:5

Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

2015-10-31 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125892/ --- Review request for Plasma, David Edmundson and Martin Gräßlin. Repository

Re: Review Request 125817: Add plugin system for Calendar events

2015-10-31 Thread David Edmundson
> On Oct. 31, 2015, 1:08 a.m., David Edmundson wrote: > > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h, > > line 173 > > > > > > Unless needed otherwise, I'd put the UID in th

Review Request 125889: Take QApplication::wheelScrollLines into account from ScrollView

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125889/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125887/ --- Review request for Plasma. Repository: libksysguard Description ---

Review Request 125888: systemmonitor: Don't link to unused libraries

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125888/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 125886: drkonqi: Drop KF5::WebKit dependency

2015-10-31 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125886/ --- Review request for Plasma. Repository: plasma-workspace Description ---