Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 349 - Unstable!

2015-12-27 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/349/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 02:47:35 + Build duration: 5 min 30 sec CHANGE SET Revision 4c16c5d533a919232d90d496ffce

Re: Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

2015-12-27 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126539/ --- (Updated Dec. 28, 2015, 1:34 a.m.) Status -- This change has been ma

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review90189 --- src/declarativeimports/core/iconitem.cpp (line 405)

Re: Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126539/#review90188 --- Ship it! Ship It! - David Edmundson On Dec. 28, 2015, 12:1

Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

2015-12-27 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126539/ --- Review request for KDE Frameworks and Plasma. Repository: kwallet-pam D

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2015-12-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated Dez. 28, 2015, 12:17 vorm.) Review request for Plasma. Changes

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 27 - Still Failing!

2015-12-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 27 Dec 2015 22:13:28 + Build duration: 2 min 5 sec CHANGE SET Revision c692bc53a8c5cf580208

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Ken Vermette
> On Dec. 26, 2015, 11:51 p.m., Ivan Čukić wrote: > > I have mixed feelings about this one. (to oppose those that are against it, > > and those that are for it) > > > > I like the picture. It would be awesome as a background for some > > kde-plasma-related brochures, videos etc. > > > > I'm n

Re: Review Request 126491: Set root context properties on the right context

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126491/ --- (Updated Dec. 27, 2015, 10:13 p.m.) Status -- This change has been m

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Ivan Čukić
> On Dec. 26, 2015, 11:51 p.m., Ivan Čukić wrote: > > I have mixed feelings about this one. (to oppose those that are against it, > > and those that are for it) > > > > I like the picture. It would be awesome as a background for some > > kde-plasma-related brochures, videos etc. > > > > I'm n

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/#review90184 --- shell/main.cpp

Review Request 126538: Don't duplicate a tonne of KCrash code

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Kai Uwe Broulik
> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correc

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread David Edmundson
> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correct:

Re: Review Request 126491: Set root context properties on the right context

2015-12-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126491/#review90181 --- Ship it! Ship It! - Kai Uwe Broulik On Dez. 23, 2015, 5:08

Re: Review Request 126472: Don't always load the timetracker

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/ --- (Updated Dec. 27, 2015, 7:38 p.m.) Status -- This change has been ma

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Kai Uwe Broulik
> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correc

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread David Edmundson
> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correct:

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Kai Uwe Broulik
> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. The and is correct: - I never want to show the di

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90166 --- Ship it! drkonqi/main.cpp (line 159)

Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126517/#review90165 --- Ship it! Ship It! - David Edmundson On Dec. 25, 2015, 4:24

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Ken Vermette
> On Dec. 26, 2015, 11:51 p.m., Ivan Čukić wrote: > > I have mixed feelings about this one. (to oppose those that are against it, > > and those that are for it) > > > > I like the picture. It would be awesome as a background for some > > kde-plasma-related brochures, videos etc. > > > > I'm n

Jenkins-kde-ci: oxygen Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 6 - Failure!

2015-12-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 27 Dec 2015 16:35:45 + Build duration: 9.8 sec CHANGE SET No changes _

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 43 - Failure!

2015-12-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 27 Dec 2015 16:35:45 + Build duration: 11 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 348 - Failure!

2015-12-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/348/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 27 Dec 2015 09:18:58 + Build duration: 4 min 31 sec CHANGE SET Revision 66f97694fcdb18e22ee9ddc9ebeb6

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

2015-12-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126499/#review90157 --- desktoppackage/contents/configuration/ConfigurationContainmen

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

2015-12-27 Thread Kai Uwe Broulik
> On Dez. 24, 2015, 3:22 vorm., Martin Klapetek wrote: > > Screenshot? Also looks like a good candidate for QML-KMessageWidget (do we > > have a component for that already?) > > David Edmundson wrote: > You wrote one in the clock applet, you have not made it a component. > If you do so,

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

2015-12-27 Thread David Edmundson
> On Dec. 24, 2015, 3:22 a.m., Martin Klapetek wrote: > > Screenshot? Also looks like a good candidate for QML-KMessageWidget (do we > > have a component for that already?) > > David Edmundson wrote: > You wrote one in the clock applet, you have not made it a component. > If you do so,

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

2015-12-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126524/#review90132 --- sddmauthhelper.cpp (line 71)

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 27, 2015, 4:11 nachm.) Review request for KDE Frameworks, P

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Ivan Čukić
> On Dec. 26, 2015, 11:51 p.m., Ivan Čukić wrote: > > I have mixed feelings about this one. (to oppose those that are against it, > > and those that are for it) > > > > I like the picture. It would be awesome as a background for some > > kde-plasma-related brochures, videos etc. > > > > I'm n

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126319/#review90143 --- I love the final iteration (3.3). In fact I've started using i

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Kai Uwe Broulik
> On Dez. 25, 2015, 4:37 nachm., Kai Uwe Broulik wrote: > > Usability: I envisioned this to be used for auto-restarting shell services > > and not to be used by applications. > > Another interesting thought could be enabling this by default for all > > applications but for regular applications

Re: robots.txt in quickgit.kde.org

2015-12-27 Thread Ben Cooksley
On Mon, Dec 28, 2015 at 12:15 AM, Lydia Pintscher wrote: > On Sun, Dec 27, 2015 at 12:08 PM, Ben Cooksley wrote: >> On Sun, Dec 27, 2015 at 11:53 PM, Ashish Bansal >> wrote: >>> Hi everyone, >> >> Hi Ashish, >> >>> >>> "quickgit.kde.org" contains robots.txt[0] which is disallowing search >>> eng

Re: robots.txt in quickgit.kde.org

2015-12-27 Thread Lydia Pintscher
On Sun, Dec 27, 2015 at 12:08 PM, Ben Cooksley wrote: > On Sun, Dec 27, 2015 at 11:53 PM, Ashish Bansal > wrote: >> Hi everyone, > > Hi Ashish, > >> >> "quickgit.kde.org" contains robots.txt[0] which is disallowing search >> engines to fetch the project repos. I just wanted to know if this is >>

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review90139 --- Sorry for the delay; Christmas happened :-) Just two more sma

Re: robots.txt in quickgit.kde.org

2015-12-27 Thread Ben Cooksley
On Sun, Dec 27, 2015 at 11:53 PM, Ashish Bansal wrote: > Hi everyone, Hi Ashish, > > "quickgit.kde.org" contains robots.txt[0] which is disallowing search > engines to fetch the project repos. I just wanted to know if this is > intentional or not? > > If I recall correctly, mirror of kde reposit

robots.txt in quickgit.kde.org

2015-12-27 Thread Ashish Bansal
Hi everyone, "quickgit.kde.org" contains robots.txt[0] which is disallowing search engines to fetch the project repos. I just wanted to know if this is intentional or not? If I recall correctly, mirror of kde repositories on github was created just because it wasn't being indexed by the search en

[Breeze] [Bug 357135] org.kde.breeze window specific overrides get lost everytime I click apply and ok

2015-12-27 Thread Hugo Pereira Da Costa via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357135 Hugo Pereira Da Costa changed: What|Removed |Added Component|general |window decoration CC|

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-27 Thread Heiko Tietze
> On Dec. 25, 2015, 4:37 p.m., Kai Uwe Broulik wrote: > > Usability: I envisioned this to be used for auto-restarting shell services > > and not to be used by applications. > > Another interesting thought could be enabling this by default for all > > applications but for regular applications tr