Sunsetting khotkeys?

2016-03-28 Thread Martin Graesslin
Hi, I want to propose to not release KHotKeys with Plasma 5.7 anymore. The reasons are: * it's unmaintained (e.g. Ben sent us a mail about failing build) * it never got properly ported to Qt5 (xcb port partially missing) * many features need to be moved to KWin in order to support it in Wayland *

[Differential] [Requested Changes To] D1216: Disallow ptrace on greeter and kcheckpass process on FreeBSD

2016-03-28 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I agree with rakuco: the two variables need to be merged into one add_feature_info. Otherwise: thanks a lot for implementing it! REPOSITORY rKSCREENLOCKER KScreenLock

[Differential] [Abandoned] D1236: kcm_activities: Remove form titles that should not be translatable

2016-03-28 Thread aspotashev (Alexander Potashev)
aspotashev abandoned this revision. aspotashev added a comment. Pushed because it's trivial. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1236 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: aspotashev, ivan C

[Differential] [Closed] D1235: kcms/activities: Fix wrong usage of CMake macro ki18n_wrap_ui()

2016-03-28 Thread aspotashev (Alexander Potashev)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP67c078bea2fe: kcms/activities: Fix wrong usage of CMake macro ki18n_wrap_ui() (authored by aspotashev). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabrica

Re: Plasma Workspace - Improperly exporting targets

2016-03-28 Thread Martin Graesslin
On Tuesday, March 29, 2016 10:13:02 AM CEST Ben Cooksley wrote: > Hi Plasma Devs, > > It would appear Plasma Workspace is improperly exporting it's targets, > leading to build failures. This particularly affects Apper, which is > unable to build on the CI system as a result. Please ensure when > e

[Differential] [Accepted] D1237: Fix compilation with gcc 4.8

2016-03-28 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1237 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: shumski, graesslin Cc: plasma-devel ___

[Differential] [Accepted] D1223: [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut

2016-03-28 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. We will need the same in KWin/Wayland (and actually also the code to enable/disable touchpad) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISI

[Differential] [Request, 4 lines] D1242: Guard round this delegate getting deleted during menu exec

2016-03-28 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY BUG: 360711 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH crash_fix2 REVISION DETAIL https://phabricator.kde.org/D12

[Differential] [Request, 5 lines] D1241: Fix crash in relativeActivity

2016-03-28 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY If we were on activity 0 and tried to load the previous activity we would crash. -1 % rowCount == -1 in C++ we then

KHotKeys: Plugin metadata missing?

2016-03-28 Thread Ben Cooksley
Hi Plasma Devs, It would seem that KHotkeys now fails to build, due to either: a) Missing plugin metadata b) Missing CMake target dependencies between the automoc task and the task that generates the plugin metadata. Could someone correct this please? https://build.kde.org/view/branchGroup%20kf5-

Re: Plasma Workspace - Improperly exporting targets

2016-03-28 Thread Ben Cooksley
On Tue, Mar 29, 2016 at 10:59 AM, Stephen Kelly wrote: > Ben Cooksley wrote: > >> Hi Plasma Devs, >> >> It would appear Plasma Workspace is improperly exporting it's targets, >> leading to build failures. This particularly affects Apper, which is >> unable to build on the CI system as a result. Pl

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

2016-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 20:50:39 + Build duration: 23 min CHANGE SET Revision 93daaf4c504ee2da91b5bbfc9502d0244105

Plasma Workspace - Improperly exporting targets

2016-03-28 Thread Ben Cooksley
Hi Plasma Devs, It would appear Plasma Workspace is improperly exporting it's targets, leading to build failures. This particularly affects Apper, which is unable to build on the CI system as a result. Please ensure when exporting targets / finding libraries that the full path to the library is gi

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 2 - Failure!

2016-03-28 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 20:54:46 + Build duration: 7 min 45 sec CHANGE SET Revision 62d8b334e7953bc9acded55d9f770b89703b217

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-28 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/ --- (Updated March 28, 2016, 8:33 p.m.) Status -- This change has been m

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-28 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review94085 --- Ship it! Ship It! - David Rosca On March 28, 2016, 4:31

[Differential] [Request, 6 lines] D1240: TaskManager: Force grouping for Icons-Only Task Manager

2016-03-28 Thread drosca (David Rosca)
drosca created this revision. drosca added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Always group tasks, even when new task demands attention. TEST PLAN When a demand attention task is ungrouped, it won't be grouped ba

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2016-03-28 Thread Martin Klapetek
> On Feb. 23, 2016, 2:09 p.m., David Edmundson wrote: > > Martin, what is the state of this? > > > > You're in danger of missing Plasma 5.6. > > Martin Klapetek wrote: > I very likely won't be able to finish it in this cycle. > > David Edmundson wrote: > well, what's missing? > I d

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2016-03-28 Thread David Edmundson
> On Feb. 23, 2016, 1:09 p.m., David Edmundson wrote: > > Martin, what is the state of this? > > > > You're in danger of missing Plasma 5.6. > > Martin Klapetek wrote: > I very likely won't be able to finish it in this cycle. well, what's missing? I don't want to miss 5.7 too. - David

[Differential] [Closed] D1238: PanelView: Skip invalid screen geometries in updateStruts

2016-03-28 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd2f3147fd27d: PanelView: Skip invalid screen geometries in updateStruts (authored by drosca). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Accepted] D1238: PanelView: Skip invalid screen geometries in updateStruts

2016-03-28 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.6 REVISION DETAIL https://phabricator.kde.org/D1238 EMAIL PREFERENCES https://phabricator

[Differential] [Request, 3 lines] D1238: PanelView: Skip invalid screen geometries in updateStruts

2016-03-28 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY My second (internal) screen is disabled and has 0x0 size. This fixes setting the struts for panel and correctly calculating the available d

[Differential] [Request, 2 lines] D1237: Fix compilation with gcc 4.8

2016-03-28 Thread shumski (Hrvoje Senjan)
shumski created this revision. shumski added a reviewer: graesslin. shumski set the repository for this revision to rKWAYLAND KWayland. shumski added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1237 AF

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-28 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/ --- (Updated Март 28, 2016, 7:31 след обяд) Review request for Plasma, David

[Differential] [Commented On] D1216: Disallow ptrace on greeter and kcheckpass process on FreeBSD

2016-03-28 Thread rakuco (Raphael Kubo da Costa)
rakuco added inline comments. INLINE COMMENTS CMakeLists.txt:25-30 I think you need to merge these two `add_feature_info()` calls: as-is, either one or the other will always be shown in the "disabled features" list, and I guess you only want this to happen if neither call/header is found. Per

Re: Review Request 127259: Immediately close submenus when mouse overing the parent menu

2016-03-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127259/ --- (Updated March 28, 2016, 1:56 p.m.) Status -- This change has been d

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-28 Thread David Rosca
> On March 25, 2016, 10 a.m., David Rosca wrote: > > If pulse rejects the volume change when dragging the slider, the slider > > handle will jump from the cursor to the old value. > > Also, external volume changes (eg. with global shortcut) are now delayed by > > the timer. > > Anthony Fieroni

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

2016-03-28 Thread Anthony Fieroni
> On Март 25, 2016, обяд, David Rosca wrote: > > If pulse rejects the volume change when dragging the slider, the slider > > handle will jump from the cursor to the old value. > > Also, external volume changes (eg. with global shortcut) are now delayed by > > the timer. > > Anthony Fieroni wro

5.7 Kickoff meeting 11:00GMT Thursday 31st March #plasma-devel

2016-03-28 Thread Jonathan Riddell
5.7 Kickoff meeting 11:00GMT Thursday 31st March #plasma-devel I make that 12:00BST, 13:00CEST, 16:30India We'll set a schedule (pre-meeting suggestions welcome) and go over the todo list (please do any pre-meeting triage you feel is useful) https://todo.kde.org/?controller=board&action=show&pro

Re: Review Request 127512: Fix memory leak in Kicker

2016-03-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127512/ --- (Updated March 28, 2016, 9:46 a.m.) Status -- This change has been m

Re: Review Request 127512: Fix memory leak in Kicker

2016-03-28 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127512/#review94059 --- Ship it! Ship It! - Eike Hein On March 28, 2016, 12:11