[Differential] [Closed] D1396: Add PROJECT_VERSION to CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATION1feb62b2521a: Add PROJECT_VERSION to CMakeLists.txt (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

> On April 11, 2016, 7:45 a.m., Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote: >

[Differential] [Closed] D1383: Fix crash on repainting an invalid sizes decoration

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN0df4406c2cf8: Fix crash on repainting an invalid sizes decoration (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1383?vs=3273&id=3326 REVISI

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

> On Април 11, 2016, 8:45 преди обяд, Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote

[Powerdevil] [Bug 361708] System stuck in ac-plugged in mode ignoring Power management rules

https://bugs.kde.org/show_bug.cgi?id=361708 --- Comment #1 from Sudhir Khanger --- Created attachment 98390 --> https://bugs.kde.org/attachment.cgi?id=98390&action=edit screenshot of the problem -- You are receiving this mail because: You are the assignee for the bug.

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 13, 2016, 10:28 a.m., Marco Martin wrote: > > what's the status of this? > > Martin Klapetek wrote: > Working on it. Ok so I'm unable to render that svg, it is properly installed and everything, but this doesn't show anything (not even error): ``` PlasmaCore.Svg { id

Re: Review Request 127646: Add a placement property to Menu and make use of it in a new openRelative() invokable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127646/ --- (Updated April 13, 2016, 9:23 p.m.) Review request for Plasma. Changes

Re: Review Request 127618: Applet : Display icons and device selection for streams

> On avr. 9, 2016, 1:18 après-midi, David Rosca wrote: > > The device combobox for streams was there (in my older review and also in > > much older version of sound applet), but it was decided to not show it in > > applet to keep it simple. > > For the icons I have review (https://git.reviewboa

Re: Review Request 127646: Add parameter to request collision detection against supplied menu coordinates

> On April 13, 2016, 6:43 p.m., Marco Martin wrote: > > I don't like the api... > > If I understand correctly you need the menu aligned with the task item not > > going over the taskbar also in cases of windows can cover? > > I would prefer in this case another open method, something along the l

Re: Review Request 127646: Add parameter to request collision detection against supplied menu coordinates

> On April 13, 2016, 6:43 p.m., Marco Martin wrote: > > I don't like the api... > > If I understand correctly you need the menu aligned with the task item not > > going over the taskbar also in cases of windows can cover? > > I would prefer in this case another open method, something along the l

Re: Review Request 127646: Add parameter to request collision detection against supplied menu coordinates

> On April 13, 2016, 6:43 p.m., Marco Martin wrote: > > I don't like the api... > > If I understand correctly you need the menu aligned with the task item not > > going over the taskbar also in cases of windows can cover? > > I would prefer in this case another open method, something along the l

Re: Review Request 127646: Add parameter to request collision detection against supplied menu coordinates

> On April 13, 2016, 6:43 p.m., Marco Martin wrote: > > I don't like the api... > > If I understand correctly you need the menu aligned with the task item not > > going over the taskbar also in cases of windows can cover? > > I would prefer in this case another open method, something along the l

Re: Review Request 127646: Add parameter to request collision detection against supplied menu coordinates

> On April 13, 2016, 6:43 p.m., Marco Martin wrote: > > I don't like the api... > > If I understand correctly you need the menu aligned with the task item not > > going over the taskbar also in cases of windows can cover? > > I would prefer in this case another open method, something along the l

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

https://bugs.kde.org/show_bug.cgi?id=357288 --- Comment #3 from Jake Cobb --- For some further information, allowing the screen to lock from the power management settings will wake it back up when the screen locks. Specifically, Desktop Behavior > Screen Locking is off. Power Management > Energ

Re: Review Request 127646: Add parameter to request collision detection against supplied menu coordinates

> On April 13, 2016, 6:43 p.m., Marco Martin wrote: > > I don't like the api... > > If I understand correctly you need the menu aligned with the task item not > > going over the taskbar also in cases of windows can cover? > > I would prefer in this case another open method, something along the l

Re: Review Request 127648: Allow setting a minimum width on the menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127648/ --- (Updated April 13, 2016, 7:22 p.m.) Status -- This change has been m

Re: Review Request 127646: Add parameter to request collision detection against supplied menu coordinates

> On April 13, 2016, 6:43 p.m., Marco Martin wrote: > > I don't like the api... > > If I understand correctly you need the menu aligned with the task item not > > going over the taskbar also in cases of windows can cover? > > I would prefer in this case another open method, something along the l

Re: Review Request 127646: Add parameter to request collision detection against supplied menu coordinates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127646/#review94585 --- I don't like the api... If I understand correctly you need th

Re: Review Request 127648: Allow setting a minimum width on the menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127648/#review94584 --- Ship it! Ship It! - Marco Martin On April 13, 2016, 5:3

Re: Review Request 123653: New Minimize Windows Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review94583 --- This applet is *must have* for many users, let's make'm happy

Review Request 127648: Allow setting a minimum width on the menu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127648/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 127646: Add parameter to request collision detection against supplied menu coordinates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127646/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 127640: Update desktopthemedetails docbook to 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127640/ --- (Updated April 13, 2016, 9:57 a.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 22 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Apr 2016 16:39:43 + Build duration: 7 min 25 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 22 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Apr 2016 16:39:43 + Build duration: 7 min 25 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 127645: Add overload for adding a MenuItem at a specific position

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127645/ --- (Updated April 13, 2016, 9:17 a.m.) Status -- This change has been m

Re: Review Request 127645: Add overload for adding a MenuItem at a specific position

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127645/#review94582 --- Ship it! Ship It! - Marco Martin On April 13, 2016, 4:1

Re: Review Request 127645: Add overload for adding a MenuItem at a specific position

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127645/ --- (Updated April 13, 2016, 4:15 p.m.) Review request for Plasma. Changes

Re: Review Request 127645: Add overload for adding a MenuItem at a specific position

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127645/ --- (Updated April 13, 2016, 4:13 p.m.) Review request for Plasma. Changes

Re: Review Request 127645: Add overload for adding a MenuItem at a specific position

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127645/#review94581 --- Fix it, then Ship it! src/declarativeimports/plasmacompon

Review Request 127645: Add overload for adding a MenuItem at a specific position

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127645/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 127575: Plasma 5.7 "Skylight" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127575/ --- (Updated April 13, 2016, 3:51 p.m.) Status -- This change has been m

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

https://bugs.kde.org/show_bug.cgi?id=357288 Jake Cobb changed: What|Removed |Added CC||jake.c...@gmail.com --- Comment #2 from Jake Cobb

Re: Review Request 127640: Update desktopthemedetails docbook to 5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127640/#review94580 --- Ship it! Ship It! - Yuri Chornoivan On Квітень 12, 2016

[Differential] [Request, 95 lines] D1403: [autotest] Extend test to verify the code which handles buffer deletions

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Surface/SubSurface and Shadow handle the case that an attached buffer gets destroyed by the client. So

[Differential] [Updated, 115 lines] D1402: add X11Integration for xcb qpa workarounds

mart updated this revision to Diff 3321. mart added a comment. an attempt of autotest REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1402?vs=3320&id=3321 REVISION DETAIL https://phabricator.kde.org/D1402 A

[Differential] [Requested Changes To] D1402: add X11Integration for xcb qpa workarounds

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I highly suggest to add a test case for that to verify that the window has the correct NetWm window type. INLINE COMMENTS src/platformtheme/kdeplatformtheme.cpp:52 QX11Inf

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/ --- (Updated April 13, 2016, 1:45 p.m.) Status -- This change has been m

[Differential] [Request, 98 lines] D1402: add X11Integration for xcb qpa workarounds

mart created this revision. mart added a reviewer: graesslin. mart set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. mart added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this class will collec

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 13, 2016, 10:28 a.m., Marco Martin wrote: > > what's the status of this? Working on it. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94567 --

[Differential] [Closed] D1388: [autotest] Add a test case for QtSurfaceExtensionInterface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND978e053d0069: [autotest] Add a test case for QtSurfaceExtensionInterface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1388?vs=3

[Differential] [Accepted] D1383: Fix crash on repainting an invalid sizes decoration

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good to me (as far as I understand). REPOSITORY rKWIN KWin BRANCH dont-crash-empty-deco-5.6 REVISION DETAIL https://phabricator.kde.org/D1383 EMAI

[Differential] [Accepted] D1388: [autotest] Add a test case for QtSurfaceExtensionInterface

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKWAYLAND KWayland BRANCH test-case-qtsurface-extension REVISION DETAIL https://phabricator.kde.org/D1388 EMAIL PREFERENCES

[Differential] [Closed] D1400: [autotests] Add test case for FakeInputInterface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND468d9e265bcb: [autotests] Add test case for FakeInputInterface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1400?vs=3314&id=331

[Differential] [Closed] D1401: [client] Fix FakeInput::requestPointerAxis

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND05ab9e49a2a3: [client] Fix FakeInput::requestPointerAxis (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1401?vs=3315&id=3316 REV

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

> On April 13, 2016, 10:34 a.m., Kai Uwe Broulik wrote: > > Shouldn't QFormLayout do that? Yes, but it requires a more invasive patch (the layout of spacers/buttons is messed up if we just change QGridLayout to QFormLayout) - Elvis ---

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/#review94574 --- Shouldn't QFormLayout do that? - Kai Uwe Broulik On April

Re: Review Request 127637: bind highlightedText color in Plasma::Theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127637/ --- (Updated April 13, 2016, 10:29 a.m.) Status -- This change has been

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

> On Dub. 13, 2016, 10:24 dop., Jan Grulich wrote: > > Perfect, looks good. Ship it!! > > Elvis Angelaccio wrote: > Maybe we could even consider this as a bugfix? And commit it to 5.6 > branch? I agree, it doesn't change any string or something like that so you can push it to Plasma/5.6 b

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

> On April 13, 2016, 10:24 a.m., Jan Grulich wrote: > > Perfect, looks good. Ship it!! Maybe we could even consider this as a bugfix? And commit it to 5.6 branch? - Elvis --- This is an automatically generated e-mail. To reply, visit: h

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/#review94571 --- Ship it! Perfect, looks good. Ship it!! - Jan Grulich O

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/ --- (Updated April 13, 2016, 10:18 a.m.) Review request for Plasma and Jan Gr

[Differential] [Accepted] D1400: [autotests] Add test case for FakeInputInterface

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH fake-input-test REVISION DETAIL https://phabricator.kde.org/D1400 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Accepted] D1401: [client] Fix FakeInput::requestPointerAxis

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH fix-fake-input-axis-5.6 REVISION DETAIL https://phabricator.kde.org/D1401 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

Re: Review Request 127637: bind highlightedText color in Plasma::Theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127637/#review94570 --- Ship it! Ship It! - David Edmundson On April 13, 2016,

[Differential] [Request, 2 lines] D1401: [client] Fix FakeInput::requestPointerAxis

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It simulated a button press instead of an axis event. TEST PLAN see https://phabricator.kde.org/D1400

[Differential] [Request, 332 lines] D1400: [autotests] Add test case for FakeInputInterface

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKWAYLAND KWayland BRANCH fake-input-test REVISION DETAIL https://phabricator.kde.org/D1400 AFFECTED FIL

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/#review94569 --- Could you please provide screenshot for comparison? libs/ed

Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/ --- Review request for Plasma and Jan Grulich. Repository: plasma-nm Descri

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 21 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Apr 2016 09:21:03 + Build duration: 5 min 12 sec CHANGE SET Revision ddcf590f968f9b11c39

[Differential] [Closed] D1398: [autotest] Add a test case for the shadow interface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND462a5c580d09: [autotest] Add a test case for the shadow interface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1398?vs=3311&id=

Re: Review Request 127637: bind highlightedText color in Plasma::Theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127637/ --- (Updated April 13, 2016, 8:47 a.m.) Review request for Plasma. Changes

Re: Review Request 127637: bind highlightedText color in Plasma::Theme

> On April 12, 2016, 11:38 p.m., David Edmundson wrote: > > src/plasma/private/theme_p.cpp, line 505 > > > > > > This still has the same bug I pointed out in the first review. > > > > This should be com

[Differential] [Accepted] D1398: [autotest] Add a test case for the shadow interface

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH shadow-test REVISION DETAIL https://phabricator.kde.org/D1398 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Powerdevil] [Bug 361708] New: System stuck in ac-plugged in mode ignoring Power management rules

https://bugs.kde.org/show_bug.cgi?id=361708 Bug ID: 361708 Summary: System stuck in ac-plugged in mode ignoring Power management rules Product: Powerdevil Version: 5.5.5 Platform: Fedora RPMs OS: Linux

Re: Review Request 127586: [calendar] Add a mark to days containing events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94567 --- what's the status of this? - Marco Martin On April 6, 2016

[Differential] [Request, 1 line] D1399: [shell] Commit surface after removing it's shadow

graesslin created this revision. graesslin added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Removing the shadow only affects the pending state, we also need to explicitly commit the Surface

[Differential] [Request, 260 lines] D1398: [autotest] Add a test case for the shadow interface

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Basic functionality is covered. Changing of shadow elements not covered, there seems to be lacking serv

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

> On April 11, 2016, 5:45 vorm., Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote: >

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

> On Април 11, 2016, 8:45 преди обяд, Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

https://bugs.kde.org/show_bug.cgi?id=344456 Anton Filimonov changed: What|Removed |Added CC||anton.filimo...@gmail.com --- Comment #38 fro

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

> On April 11, 2016, 5:45 vorm., Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote: >

[Differential] [Closed] D1072: Make sure desktop toolbox has integer and even size

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPe2d5d00f0469: Make sure desktop toolbox has integer and even size (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D107