graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rKWIN KWin
BRANCH
sebas/scene-qpainter-add-missing-override
REVISION DETAIL
https://phabricator.kde.org/D1499
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
sebas created this revision.
sebas added a reviewer: graesslin.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This seems to just have been forgotten here.
TEST PLAN
Builds
REPOSITORY
rKWIN KWin
BRANCH
dfaure added a comment.
I'm pretty sure it should work. What changed in QUrl is that setPath used to
normalize the path and doesn't do that anymore.
(qtbase commit 2e1de7f3c4ca). So in 5.5 the double slash got simplified to a
single slash, while in 5.6 it stays and breaks the test.
Not
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1222
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/59/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 16:13:15 +
Build duration: 17 min
CHANGE SET
Revision
On Friday 22 April 2016, Dirk Hohndel wrote:
> > tried on the laptop so far, after a few fixes on the branch it seems to
> > work fine (not super familiar on all aspects of the app tough)
> > the only thing, i would then push the little change on the header api
> > that caused problems, for which
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEd5494afe48a6: Fix memory leak in system tray
(authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D1498?vs=3530=3531#toc
REPOSITORY
rPLASMAWORKSPACE Plasma
apol accepted this revision.
apol added a reviewer: apol.
apol added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1498
EMAIL PREFERENCES
graesslin added inline comments.
INLINE COMMENTS
kioslave/desktop/kio_desktop.cpp:161 > So it seems to me that just removing
the '/' would be enough in practice.
hmm, does that work also with older Qt (e.g. Qt 5.5)? Given that the test
passes on Qt 5.5, but not on Qt 5.6, I fear that
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Currently we leak an IconLoader for each icon for the time the system
tray is in memory.
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 14:58:49 +
Build duration: 9 min 17 sec
CHANGE SET
Revision
dfaure added inline comments.
INLINE COMMENTS
kioslave/desktop/kio_desktop.cpp:161 Can the path really *not* start with a
'/' in this code ?
From a QUrl point of view, it can happen with relative URLs
("desktop:foo.txt"), but we very rarely use that in KDE code, if at all (it's
unusable
graesslin added a comment.
@dfaure I saw that you modified QUrl::setPath lately. Is this the correct
approach here?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
fix-kioslave-desktop
REVISION DETAIL
https://phabricator.kde.org/D1497
EMAIL PREFERENCES
graesslin added a reviewer: dfaure.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
fix-kioslave-desktop
REVISION DETAIL
https://phabricator.kde.org/D1497
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, Plasma, hein, dfaure
Cc:
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
fix-kioslave-desktop
REVISION DETAIL
https://phabricator.kde.org/D1497
EMAIL PREFERENCES
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127744/#review94861
---
Stripping the reverse domain name is a no-no. The way this
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Fixes failing test.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
fix-kioslave-desktop
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 26 Apr 2016 14:11:42 +
Build duration: 9 min 26 sec
CHANGE SET
No changes
JUNIT RESULTS
attendees: eike, jensreu, bshah, einar77, colomar, kbroulik
chair: eike
a) ISO status
- Luca Beltrame (einar77) says stable base + latest KDE bits openSUSE
ISOs should be available on the 19th
-- [19:07] Sho_:
Git commit 8bdb20f0189da74e9875be45822e7f9aa872543e by Ben Cooksley.
Committed on 26/04/2016 at 06:41.
Pushed by bcooksley into branch 'master'.
Disable new_delete_type_mismatch ASAN checks, due to defective Qt code.
We've little choice but to disable this for the next few weeks, until the
20 matches
Mail list logo
