xuetianweng added inline comments.
INLINE COMMENTS
> main_wayland.cpp:449
> qunsetenv("QT_DEVICE_PIXEL_RATIO");
> -qunsetenv("QT_IM_MODULE");
> +qputenv("QT_IM_MODULE", "qtvirtualkeyboard");
> qputenv("QSG_RENDER_LOOP", "basic");
Don't do this. Otherwise qtvirtualkeyboard will
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128021/
---
Review request for Plasma and Eike Hein.
Repository: plasma-desktop
apol accepted this revision.
apol added a reviewer: apol.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> FontFilter.cpp:169
> +QStringList mimes;
> +foreach (QString pattern, mime.globPatterns())
> +
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1688
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov,
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1687
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov,
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1686
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov,
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1685
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov,
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 May 2016 18:15:02 +
Build duration: 10 min
CHANGE SET
Revision
davidedmundson updated this revision to Diff 4008.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.
Fix most of Kai's comments
- only missing changing the user selection screen, as I dont' know what icon
to
use
REPOSITORY
rPLASMAWORKSPACE Plasma
volkov created this revision.
volkov added a reviewer: Plasma.
volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
volkov created this revision.
volkov added a reviewer: Plasma.
volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
volkov created this revision.
volkov added a reviewer: Plasma.
volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
volkov created this revision.
volkov added a reviewer: Plasma.
volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
volkov created this revision.
volkov added a reviewer: Plasma.
volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
Hi,
> http://test.xapient.net/STUFF/dolphin.jpg
The menu on the left is fixed by the last patch that I mentioned. On the right
looks like yet another oversight, I just uploaded a patch for review [1] to fix
that.
Cheers,
Kai Uwe
[1] https://git.reviewboard.kde.org/r/128014/
graesslin added a comment.
In https://phabricator.kde.org/D1672#31140, @bdhruve wrote:
> In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
>
> > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp
for id 1 doesn't make sense if we never got a
hello everybody..
first of all... wow! this list of fixes is awesome.. thank you!
i have a question about this "hide toolbars" restriction..
as you can see in the following screenshot (testing with dolphin 16.04.0)
http://test.xapient.net/STUFF/dolphin.jpg
i tried to restrict unocking
bdhruve added a comment.
In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
> I'm wondering: should we ensure that the ids are correct. E.g. a touchUp
for id 1 doesn't make sense if we never got a touchDown for id 1. This would
require tracking the used ids in
graesslin added a comment.
Ups, sorry for the late review. Somehow it got into my backlog and I forgot
about it.
The protocol looks good to me. I only have a minor change request there. On
Server side I would rethink how the buffers are tracked. I think with the
struct GbmBuffer we are
bdhruve updated this revision to Diff 4000.
bdhruve added a comment.
Improved autotest
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1672?vs=3992=4000
BRANCH
fake-input-touch
REVISION DETAIL
https://phabricator.kde.org/D1672
AFFECTED FILES
graesslin marked an inline comment as done.
graesslin added inline comments.
INLINE COMMENTS
> sebas wrote in integration.cpp:46
> cross fingers?
sorry, but I don't get this comment
> sebas wrote in inputmethodstest.qml:82
> DateTime and Terminal missing?
Good catch, but no. Those two are not
graesslin added a comment.
In https://phabricator.kde.org/D1672#31094, @bshah wrote:
> In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
>
> > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp
for id 1 doesn't make sense if we never got a touchDown
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
looks good to me
INLINE COMMENTS
> integration.cpp:46
> +#include
> +#include
> +#include
cross fingers?
> inputmethodstest.qml:82
> +TextField {
> +
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND905e699677ed: Implement wl_text_input and
zwp_text_input_v2 interfaces (authored by graesslin).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
sebas added a comment.
ship it!
REPOSITORY
rKWAYLAND KWayland
BRANCH
graesslin/text-input
REVISION DETAIL
https://phabricator.kde.org/D1631
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, sebas, Plasma
Cc: sebas, broulik, plasma-devel
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 May 2016 12:25:09 +
Build duration: 12 min
CHANGE SET
Revision
graesslin updated this revision to Diff 3997.
graesslin added a comment.
Addresses sebas review comments:
- fixed documentation in Registry
- Reordered documentation in TextInput
- Changed enum values to CamelCase
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
graesslin marked 3 inline comments as done.
REPOSITORY
rKWAYLAND KWayland
BRANCH
graesslin/text-input
REVISION DETAIL
https://phabricator.kde.org/D1631
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, sebas, Plasma
Cc: sebas, broulik,
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1676
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov,
bshah added a comment.
In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
> I'm wondering: should we ensure that the ids are correct. E.g. a touchUp
for id 1 doesn't make sense if we never got a touchDown for id 1. This would
require tracking the used ids in
graesslin marked an inline comment as done.
graesslin added inline comments.
INLINE COMMENTS
> sebas wrote in text-input-unstable-v2.xml:153
> "a URL"
this is an XML file I imported from 3rd party (QtWayland). Not going to touch
it.
> sebas wrote in registry.h:451
> A small note about the
volkov updated this revision to Diff 3996.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1676?vs=3971=3996
REVISION DETAIL
https://phabricator.kde.org/D1676
AFFECTED FILES
kcms/kfontinst/apps/CMakeLists.txt
volkov marked an inline comment as done.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1676
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov, Plasma
Cc: apol, plasma-devel, sebas
graesslin updated this revision to Diff 3995.
graesslin added a comment.
Upload new version against master
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1631?vs=3990=3995
BRANCH
graesslin/text-input
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEe1ae057fef29: [PanelView] Fix auto hide
(authored by broulik).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1683?vs=3993=3994
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
good catch!
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1683
EMAIL PREFERENCES
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
a few niggles, but generally, look good to me.
INLINE COMMENTS
> outputmanagement.cpp:94
> {
> +Q_UNUSED(parent);
> OutputConfiguration *config = new
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1675
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov,
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The newly introduced
graesslin added a comment.
I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for
id 1 doesn't make sense if we never got a touchDown for id 1. This would
require tracking the used ids in FakeInputInterface. But it must be done
somewhere - either in the library or by
bdhruve updated this revision to Diff 3992.
bdhruve added a comment.
Use position instead of delta in touch motion, and added docs.
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1672?vs=3982=3992
BRANCH
fake-input-touch
REVISION DETAIL
broulik updated this revision to Diff 3991.
broulik added a comment.
Parse config strict:
- Property is required (either ClassClass or ClassName)
- Identifier is required (eg. DesktopEntryName)
- only use named regexp match "match"
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
volkov added a comment.
Add QTemporaryDir::filePath(): https://codereview.qt-project.org/#/c/160366/
"/" are placed before macros that expand to string literals
it's a string literal concatenation, there is no need to change them to
QLatin1Char('/')
REPOSITORY
rPLASMADESKTOP Plasma
graesslin updated this revision to Diff 3990.
graesslin added a comment.
include QVector in one header to make it compile with Qt 5.6
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1631?vs=3903=3990
BRANCH
graesslin/text-input
REVISION DETAIL
hein added a comment.
I'd prefer a stricter approach that rejects incomplete rules, e.g. instead of
falling back to classClass if Property is not set, skip the rule. Reasoning:
The behavior of the heuristic is already magic and obtuse enough, and debugging
what happens is not made any
broulik retitled this revision from "[Libtaskmanager] Add launcher mapping for
Google Chrome apps" to "WIP: [Libtaskmanager] Add support for regular
expression mapping".
broulik updated the summary for this revision.
broulik updated the test plan for this revision.
broulik updated this revision
apol added a comment.
Ugh, I was convinced it would exist! My apologies for not checking.
For now, can you at least just change from "/" -> QLatin1Char('/')?
Also if you can look into adding the API to Qt that would be great as well.
Other than that, +1
REPOSITORY
rPLASMADESKTOP
graesslin updated this revision to Diff 3988.
graesslin added a comment.
Bind enabled to SeatInterface::hasKeyboard instead of going through libinput
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1638?vs=3964=3988
BRANCH
virtual-keyboard
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINb5b2adc5a26e: [platforms/drm] Only show cursor if a
pointer device is available (authored by graesslin).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN6f733c3bd0ad: Bind seat hasKeyboard capability to
alphanumeric keyboard availability (authored by graesslin).
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
volkov added a comment.
Unfortunately QTemporaryDir doesn't have filePath() method. But it's a good
idea to add it :)
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1675
EMAIL PREFERENCES
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/100/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 May 2016 09:18:20 +
Build duration: 19 min
CHANGE SET
Revision
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fakeinput.h:133
> + **/
> +void requestTouchMotion(quint32 id, const QSizeF );
> +/**
why a delta?
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.
Basically yes, but couldn't we use QRegExp syntax instead of coming up with a
DSL? Then we could also precompile the regexes when the rc file changes (if we
want to make the impl
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When the pointer device gets plugged off the cursor is hidden, when
a pointer device gets plugged in
Hi Thomas,
just wanted to give you a quick update. I have just merged the last patch of
our big kiosk fixes pile.
The following fixes will land in the next Plasma and/or kde frameworks release :
* Leave option in desktop toolbox honors kiosk restriction
* KRunner will be completely disabled
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE88d72a4121f8: Add ScrollArea to events view in
calendar (authored by drosca).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D1678?vs=3978=3983#toc
REPOSITORY
rPLASMAWORKSPACE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
---
(Updated May 25, 2016, 11:03 a.m.)
Status
--
This change has been
bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added a comment.
This revision is now accepted and ready to land.
Sane..
REPOSITORY
rKWIN KWin
BRANCH
bind-seat-keyboard-capability-to-alpha
REVISION DETAIL
https://phabricator.kde.org/D1681
EMAIL PREFERENCES
drosca added inline comments.
INLINE COMMENTS
> broulik wrote in CalendarView.qml:196
> Isn't this the default?
It's center aligned by default
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
calendar-scrollview (branched from master)
REVISION DETAIL
bdhruve updated this revision to Diff 3982.
bdhruve added a comment.
Fixed issues mentioned by @graesslin and @bshah
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1672?vs=3965=3982
BRANCH
fake-input-touch
REVISION DETAIL
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Just because we have a power button, doesn't mean we have a keyboard.
So let's bind the seat keyboard
broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.
Please put the wrapping/spacing stuff into a separate commit. Thanks!
INLINE COMMENTS
> CalendarView.qml:153
> }
> +
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Not needed as the dtor of the Resource ensures that the wl_resource
gets destroyed.
REPOSITORY
drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Also enable word wrap for long event titles.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDa370b0744ceb: [server] Prevent double delete of
callback resources in SurfaceInterface (authored by graesslin).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
66 matches
Mail list logo
