Re: porting the QtCurve kwin theme

On Thursday, June 16, 2016 11:15:22 PM CEST René J.V. Bertin wrote: > Hi, > > It was pointed out to me by an OpenSuse maintainer that the QtCurve Qt5 > implementation doesn't contain a (functional) window theme. > > I'm not exactly the most likely candidate to address this as I don't > currently

[Differential] [Updated] D1925: Improve window-on-screen intersection test.

hein added a reviewer: lbeltrame. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1925 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, luebking, lbeltrame Cc: plasma-devel, jensreuterberg, sebas

[Differential] [Updated] D1925: Improve window-on-screen intersection test.

hein added a reviewer: luebking. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1925 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, luebking Cc: plasma-devel, jensreuterberg, sebas

[Differential] [Request, 2 lines] D1925: Improve window-on-screen intersection test.

hein created this revision. hein added a reviewer: Plasma. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Changes the test from "client rect intersects with screen rect" to "screen rect contains center of frame (i.e. client plus deco)

Re: Review Request 128216: [QueryMatch] Add iconName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128216/#review96615 --- Ship it! Ship It! - David Edmundson On June 16, 2016,

[Differential] [Request, 4 lines] D1923: [Kicker RunnerMatchesModel] Use iconName() if possible

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Requires

[Differential] [Commented On] D1922: Use iconName in all runners

broulik added inline comments. INLINE COMMENTS > calculatorrunner.cpp:317 > > +void CalculatorRunner::run(const Plasma::RunnerContext&, const > Plasma::QueryMatch& match) > +{ and this > calculatorrunner.h:45 > protected Q_SLOTS: > +void run(const Plasma::RunnerContext , const

[Differential] [Updated] D1922: Use iconName in all runners

broulik edited reviewers, added: Plasma; removed: Plasma on Wayland. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1922 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel,

[Differential] [Request, 83 lines] D1922: Use iconName in all runners

broulik created this revision. broulik added a reviewer: Plasma on Wayland. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. TEST PLAN Requires

Review Request 128216: [QueryMatch] Add iconName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128216/ --- Review request for KDE Frameworks and Plasma. Repository: krunner

[Differential] [Request, 2 lines] D1921: Use data role that avoids unnecessary work by the source model.

hein created this revision. hein added reviewers: dfaure, davidedmundson. hein added a subscriber: plasma-devel. hein added a dependency: D1920: Add a LauncherUrlWithoutIcon data role as a speed optimization.. Restricted Application added a project: Plasma. REVISION SUMMARY Depends on

[Differential] [Updated] D1920: Add a LauncherUrlWithoutIcon data role as a speed optimization.

hein added a dependent revision: D1921: Use data role that avoids unnecessary work by the source model.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1920 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 75 lines] D1920: Add a LauncherUrlWithoutIcon data role as a speed optimization.

hein created this revision. hein added reviewers: dfaure, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Makes the API more complex, but it's worth it as it allows knowledgable users to opt into avoding costly work

Re: Please don't push to 5.7 branches.

​All fixed. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

porting the QtCurve kwin theme

Hi, It was pointed out to me by an OpenSuse maintainer that the QtCurve Qt5 implementation doesn't contain a (functional) window theme. I'm not exactly the most likely candidate to address this as I don't currently have a system running a Plasma5 desktop, but I do now have KWin5 installed in

Please don't push to 5.7 branches.

The release scripts are terrible and have broken 4 repos putting the branch in the wrong place. Namely: breeze discover breeze-plymouth breeze-gtk Fixing ASAP. David ___ Plasma-devel mailing list Plasma-devel@kde.org

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 190 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/190/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 19:34:22 + Build duration: 19 min CHANGE SET Revision

[Breeze] [Bug 364395] Icon indicating grouped windows is oddly large and off-center

https://bugs.kde.org/show_bug.cgi?id=364395 --- Comment #2 from Jason Tibbitts --- Sorry about that. I guess I should have mentioned that I'm using the Breeze theme, in case this is just a theme issue. The Fedora package is plasma-breeze-5.6.4-1.fc23.x86_64 -- You are

[Breeze] [Bug 364395] Icon indicating grouped windows is oddly large and off-center

https://bugs.kde.org/show_bug.cgi?id=364395 Eike Hein changed: What|Removed |Added Assignee|h...@kde.org|plasma-devel@kde.org

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 189 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/189/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 17:37:09 + Build duration: 50 min CHANGE SET Revision

[Differential] [Commented On] D1844: Add Appinfo metadata file

mak added inline comments. INLINE COMMENTS > org.kde.plasmashell.metainfo.xml:4 > + org.kde.plasmashell > + GPL-2.0+ > + KDE Plasma Desktop Btw, a "metadata_license" tag with a permissive license (CC0/MIT) needs to be added too, so we are sure that we can reuse the metadata downstream

[Differential] [Updated] D1844: Add Appinfo metadata file

ruphy edited reviewers, added: Visual Design Group; removed: WikiToLearn: Visual design and promo. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1844 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, mak,

[Differential] [Commented On] D1911: [Smart Launcher Backend] Use KSharedConfig::openConfig

hein added a comment. The Task Manager backend opens the same file. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1911 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc: davidedmundson,

[Breeze] [Bug 364390] New: Breeze windows style not applied

https://bugs.kde.org/show_bug.cgi?id=364390 Bug ID: 364390 Summary: Breeze windows style not applied Product: Breeze Version: 5.6.4 Platform: Chakra OS: Linux Status: UNCONFIRMED Severity: normal

[Differential] [Accepted] D1916: [Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1916 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, sitter, hein, #plasma Cc:

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 188 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/188/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 16:18:13 + Build duration: 19 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 187 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/187/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 16:04:50 + Build duration: 12 min CHANGE SET Revision

[Differential] [Closed] D1185: drkonqi mappings: Move baloo_file* to "frameworks-baloo|Baloo File Daemon"

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7ceccde2e0e2: drkonqi mappings: Move baloo_file* to "frameworks-baloo|Baloo File Daemon" (authored by aspotashev). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1185: drkonqi mappings: Move baloo_file* to "frameworks-baloo|Baloo File Daemon"

aspotashev added a comment. Moving bugs report into the product "frameworks-baloo" was not a problem for me during the last 3 months, thus I'll push this and will keep cleaning things up in the next months. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.6 REVISION DETAIL

[Differential] [Commented On] D1911: [Smart Launcher Backend] Use KSharedConfig::openConfig

davidedmundson added a comment. what does this achieve? SharedConfig ref counts; you unless there's someone else holding a reference, it'll still be reloading it every time. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1911 EMAIL

[Differential] [Commented On] D1916: [Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player

broulik added inline comments. INLINE COMMENTS > ToolTipDelegate.qml:82 > + > +if (data[sources[i]].DesktopEntry === desktopFileName) { > +return source that should probably be data[source] :) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 186 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/186/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 13:52:01 + Build duration: 45 min CHANGE SET Revision

[Differential] [Request, 19 lines] D1916: [Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The current approach of

[Differential] [Updated] D1916: [Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player

broulik added a reviewer: sitter. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1916 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein, sitter Cc: plasma-devel, jensreuterberg, sebas

[kio-extras] [Bug 364381] New: sftp/kio_sftp.cpp:1249]: (style) Suspicious condition

https://bugs.kde.org/show_bug.cgi?id=364381 Bug ID: 364381 Summary: sftp/kio_sftp.cpp:1249]: (style) Suspicious condition Product: kio-extras Version: 5.6.5 Platform: Other OS: Linux Status: UNCONFIRMED

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 9 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 14:01:37 + Build duration: 5 min 1 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 185 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/185/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 12:42:25 + Build duration: 46 min CHANGE SET Revision

[Differential] [Accepted] D1915: [FolderModel] Use mostLocalUrl() to properly resolve desktop:/ URLs

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1915 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc:

[Differential] [Request, 4 lines] D1915: [FolderModel] Use mostLocalUrl() to properly resolve desktop:/ URLs

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes dropping

[Differential] [Accepted] D1911: [Smart Launcher Backend] Use KSharedConfig::openConfig

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1911 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc:

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 8 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 12:37:15 + Build duration: 3 min 54 sec CHANGE SET Revision

[Differential] [Abandoned] D1855: relax lidswitch check for external monitor

sebas abandoned this revision. sebas added a comment. https://quickgit.kde.org/?p=powerdevil.git=commit=d3162725cfffb79da7bb8f276a31a915e3349dab does the same, it just never made it into master, only 5.5 and 5.6 branches. I'll merge it into master and 5.7 branches and will abandon this

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- (Updated June 16, 2016, 12:14 p.m.) Review request for Plasma.

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96581 --- Ship it! Ship It from i18n point of view - Burkhard Lück

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96580 --- applets/systemmonitor/common/contents/ui/DoublePlotter.qml

[Differential] [Closed] D1913: Cache the caption of ShellSurface in ShellClient

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN41a8f245b45f: Cache the caption of ShellSurface in ShellClient (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1913?vs=4548=4549 REVISION

[Differential] [Accepted] D1913: Cache the caption of ShellSurface in ShellClient

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH shell-client-cache-caption REVISION DETAIL https://phabricator.kde.org/D1913 EMAIL PREFERENCES

[Differential] [Request, 14 lines] D1913: Cache the caption of ShellSurface in ShellClient

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY If the ShellSurface gets destroyed while a decoration repaint is

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- (Updated June 16, 2016, 11:16 a.m.) Review request for Plasma. Changes

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 184 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/184/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 09:56:06 + Build duration: 17 min CHANGE SET Revision

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96573 --- applets/systemmonitor/common/contents/ui/DoublePlotter.qml

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 183 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/183/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 16 Jun 2016 09:41:35 + Build duration: 12 min CHANGE SET Revision

[Differential] [Request, 5 lines] D1911: [Smart Launcher Backend] Use KSharedConfig::openConfig

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMADESKTOP Plasma Desktop

[Differential] [Closed] D1898: [Kicker] Use KRun::runService instead of new KRun

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP6ff17e254669: [Kicker] Use KRun::runService instead of new KRun (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1898?vs=4517=4544#toc REPOSITORY

[Differential] [Closed] D1891: [Holiday Events] Handle holidays spanning multiple days

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7ab1f6d33b6a: [Holiday Events] Handle holidays spanning multiple days (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D1891: [Holiday Events] Handle holidays spanning multiple days

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1891 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mck182,

Re: Review Request 128136: alignement for systemmonitoring applets

> On June 15, 2016, 9:07 a.m., Marco Martin wrote: > > applets/systemmonitor/common/contents/ui/DoublePlotter.qml, line 84 > > > > > > this way if the text is too long, it will not wrap. > > > > if you

[Differential] [Closed] D1864: Handle ShellClient::windowShown in Workspace

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4560f8d25302: Handle ShellClient::windowShown in Workspace (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1864?vs=4449=4541 REVISION DETAIL

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- (Updated June 16, 2016, 9:12 a.m.) Review request for Plasma.

Re: Review Request 128136: alignement for systemmonitoring applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/ --- (Updated June 16, 2016, 9:13 a.m.) Review request for Plasma.

[Differential] [Updated, 125 lines] D1901: [PolicyAgent] Ignore "Keep screen on" request while screen is locked

broulik updated this revision to Diff 4539. broulik added a comment. - Add serviceOwnerWatcher to notice when screensaver service comes and goes - Put initialization from constructor into init() method like the rest is REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE

Re: Review Request 128131: biger output field

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128131/ --- (Updated June 16, 2016, 8:36 a.m.) Status -- This change has been

Re: Review Request 128203: Avoid lots of useless po/*/messages.mo files in released tarballs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128203/ --- (Updated June 16, 2016, 8:13 a.m.) Status -- This change has been

Re: Review Request 128136: alignement for systemmonitoring applets

> On June 15, 2016, 9:16 a.m., Burkhard Lück wrote: > > applets/systemmonitor/cpu/contents/ui/cpu.qml, line 43 > > > > > > please add context and explain what %1 and %2 are > > Andreas Kainz wrote: > I

Re: Review Request 128131: biger output field

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128131/#review96561 --- Ship it! Ship It! - David Edmundson On June 15, 2016,

Re: Review Request 128203: Avoid lots of useless po/*/messages.mo files in released tarballs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128203/#review96559 --- Ship it! Ship It! - Harald Sitter On June 16, 2016,