[Differential] [Commented On] D1939: [Calculator Runner] Add "Copy to clipboard" action

2016-06-18 Thread cfeck (Christoph Feck)
cfeck added a comment. The m_engine member is only available, when it uses the qalculate library instead of QScriptEngine. Please add the missing #ifdef ENABLE_QALCULATE REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL

[Powerdevil] [Bug 364478] New: Power settings concerning lid state are ignored / overridden

2016-06-18 Thread Bzzz via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364478 Bug ID: 364478 Summary: Power settings concerning lid state are ignored / overridden Product: Powerdevil Version: 5.6.4 Platform: Ubuntu Packages OS: Linux

[Differential] [Updated] D1949: Revert all login screen changes as per VDG request untilthey have a consistent design.

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik added a comment. You just added a ton of master-only commits to Plasma/5.7 branch, namely: https://phabricator.kde.org/rPLASMAWORKSPACE1b1b988a83bc8cd3f2230591efc86930668d937b, https://phabricator.kde.org/rPLASMAWORKSPACEc4b114b483f91c39d2d01d0dd84a58622c51f3f4,

[Differential] [Accepted] D1949: Revert all login screen changes as per VDG request untilthey have a consistent design.

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Ship it! Minus the system tray thing. Let's make it kick ass in 5.8 instead :) INLINE COMMENTS > main.qml:101 > -Connections { > -

[Differential] [Accepted] D1952: Don't set width and height in a layout

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. I just noticed I had an uncommited change which tried to solve the same thing: -width: units.iconSizes.smallMedium -

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 200 - Still Unstable!

2016-06-18 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/200/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Jun 2016 21:56:34 + Build duration: 17 min CHANGE SET Revision

[Differential] [Request, 78 lines] D1956: Create logging categories via CMake

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Also set a consistent naming structure and to be only Info+ by default. This may mean you

[Differential] [Request, 73 lines] D1954: Port KIO Remote to use ECM declare logging category

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1954 AFFECTED

[Differential] [Request, 13 lines] D1953: Fix XembedSNIProxy Logging Category Registration

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH logging_categories REVISION DETAIL

Re: Broken Builds

2016-06-18 Thread Ben Cooksley
On Sun, Jun 19, 2016 at 9:44 AM, Burkhard Lück wrote: > Am Sonntag, 19. Juni 2016, 09:38:07 CEST schrieb Ben Cooksley: > >> - Cervisia (latest-qt4): Likely outdated build metadata, it looks to >> be trying to build Frameworks/Qt 5 code in the Qt 4 environment > > Cervisia

Re: Broken Builds

2016-06-18 Thread Burkhard Lück
Am Sonntag, 19. Juni 2016, 09:38:07 CEST schrieb Ben Cooksley: > - Cervisia (latest-qt4): Likely outdated build metadata, it looks to > be trying to build Frameworks/Qt 5 code in the Qt 4 environment Cervisia master ist kf5 based since a few days -- Burkhard Lück

Broken Builds

2016-06-18 Thread Ben Cooksley
Hi all, On the CI system there are currently a number of broken builds which have occurred in recent times. It would be appreciated if folks could fix those. They are: - Cervisia (latest-qt4): Likely outdated build metadata, it looks to be trying to build Frameworks/Qt 5 code in the Qt 4

Re: New SDDM Theme

2016-06-18 Thread David Edmundson
All done here: https://phabricator.kde.org/D1949 just needs a review. I've double checked there's no i18n changes. ​ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D1952: Don't set width and height in a layout

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Layouts adjust the size of the children by changing the width and height replacing our

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 198 - Still Unstable!

2016-06-18 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/198/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Jun 2016 18:57:16 + Build duration: 40 min CHANGE SET Revision

[Differential] [Closed] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

2016-06-18 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE1d26ef82c74e: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext (authored by broulik). CHANGED PRIOR TO COMMIT

New maintainers wanted: KDE Telepathy, KAccounts, Plasma Notifications and others

2016-06-18 Thread Martin Klapetek
Hi, as I got a new job unrelated to KDE couple months ago, I'm finding myself having less and less time and motivation to keep up with my maintainer's duties. Therefore I think it's time to pass on some of the KDE things that have my name in the "maintainer" field. First off, there's the whole

[Differential] [Request, 2 lines] D1950: Match Prison version exactly

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Prison API changes between minor releases. find_package() was finding any version,

New SDDM Theme

2016-06-18 Thread Philipp Stefan
Hello everyone, as many of you surely have seen by now: the new SDDM theme in the Plasma 5.7 beta announcement has cause many very negative reactions. After a few hours of deliberation and weighting our options the VDG came to the conclusion that it is better to postpone the release of the

[Differential] [Closed] D1939: [Calculator Runner] Add "Copy to clipboard" action

2016-06-18 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE0abe3a6dfc24: [Calculator Runner] Add "Copy to clipboard" action (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1940 EMAIL PREFERENCES

[Differential] [Updated] D1949: Revert all login screen changes as per VDG request untilthey have a consistent design.

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson retitled this revision from "Revert all login screen changes as per VDG request until they have a consistent design. Revert "Restore last selected user"" to "Revert all login screen changes as per VDG request until they have a consistent design.". REPOSITORY rPLASMAWORKSPACE

[Differential] [Accepted] D1939: [Calculator Runner] Add "Copy to clipboard" action

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL PREFERENCES

[Differential] [Request, 1,186 lines] D1949: Revert all login screen changes as per VDG request untilthey have a consistent design.Revert "Restore last selected user"

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This reverts commit https://phabricator.kde.org/rPLASMAWORKSPACE4de1116e31f6268bb0676869493101653412d571. Revert "Fix i18n"

[Differential] [Commented On] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

2016-06-18 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D1940#35859, @broulik wrote: > If you drag it to an existing sticky note you'll paste the path to the file. I decided against pasting the file contents in this case back when I implemented this. This is in the notes applet and

[Differential] [Commented On] D1946: Expose WindowGeometry in TasksModel

2016-06-18 Thread hein (Eike Hein)
hein added a comment. WindowGeometry isn't being dataChanged() further up when the geometry change is caught. Add it after the << Screen on line 381. (Not sure I understand where this patch comes from when we had a planning meeting on Monday where Pager porting was basically assigned to

[Differential] [Updated] D1946: Expose WindowGeometry in TasksModel

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1946 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, jensreuterberg, sebas

[Differential] [Commented On] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik added a comment. If you drag it to an existing sticky note you'll paste the path to the file. I decided against pasting the file contents in this case back when I implemented this. This is in the notes applet and affects any drag and drop operation to it, not just for this runner.

[Differential] [Commented On] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

2016-06-18 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Great change, +1 to all the features! Just a question: What does dragging to a sticky note do? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1940 EMAIL PREFERENCES

[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik added a comment. In https://phabricator.kde.org/D1944#35827, @cfeck wrote: > In https://phabricator.kde.org/D1944#35824, @broulik wrote: > > > We already have a feature and dependency freeze in place. This should not have gone into the Plasma/5.7 branch! > > > This

[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread cfeck (Christoph Feck)
cfeck added a comment. In https://phabricator.kde.org/D1944#35824, @broulik wrote: > We already have a feature and dependency freeze in place. This should not have gone into the Plasma/5.7 branch! This patch does not add any dependencies (or raises their minimum version).

[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik added a comment. We already have a feature and dependency freeze in place. This should not have gone into the Plasma/5.7 branch! REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1944 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 197 - Still Unstable!

2016-06-18 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Jun 2016 13:21:57 + Build duration: 11 min CHANGE SET Revision

[Breeze] [Bug 364390] Breeze windows style not applied

2016-06-18 Thread Andrea Solima via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364390 Andrea Solima changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[Differential] [Closed] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL3257be562b2c: Make NetworkManagerQt and BluezQt optional (authored by heikobecker). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Fair enough. REPOSITORY rPOWERDEVIL Powerdevil BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1944 EMAIL PREFERENCES

[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread heikobecker (Heiko Becker)
heikobecker added a comment. > Yes. What dependencies are causing problems for you? NetworkManager and its dependencies mostly. If I compare the situation to kwin and kscreenlocker, for example, and its hard dependency on wayland there's an obvious benefit and wayland is rather small in

[Differential] [Request, 5 lines] D1946: Expose WindowGeometry in TasksModel

2016-06-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ready for Pager/ActivityPager to use and drop their own plugins. (proof of concept Pager seems to work) REPOSITORY

[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik added a comment. > That still would require said libraries and their dependencies, wouldn't it? Yes. What dependencies are causing problems for you? REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1944 EMAIL PREFERENCES

[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread heikobecker (Heiko Becker)
heikobecker added a comment. In https://phabricator.kde.org/D1944#35784, @broulik wrote: > We've been through the "make action optional" dance with DPMS in the past and it has been a maintenance nightmare. Sure, in the end you're the maintainer. > The action checks for

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 196 - Still Unstable!

2016-06-18 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/196/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 18 Jun 2016 10:36:23 + Build duration: 9 min 37 sec CHANGE SET Revision

Re: porting the QtCurve kwin theme

2016-06-18 Thread René J . V . Bertin
On Friday June 17 2016 21:55:15 Christoph Feck wrote: Thanks, I'll take a look. > Last year I created the "Skeleton" KWin 5 decoration to test KWin 5 > decorations: http://developer.kde.org/~cfeck/skeleton-0.1.tar.xz > > The documentation in the KDecoration2 header files is quite extensive. >

[Differential] [Updated] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread broulik (Kai Uwe Broulik)
broulik added a subscriber: jgrulich. broulik added a comment. We've been through the "make action optional" dance with DPMS in the past and it has been a maintenance nightmare. The action checks for whether you're allowed to enable/disable WiFi or else it won't show up. It seems it

[Differential] [Request, 61 lines] D1944: Make NetworkManagerQt and BluezQt optional

2016-06-18 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY While it is most certainly sensible and helpful on a system equipped with Bluetooth and