Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

2016-07-20 Thread Martin Gräßlin
> On July 21, 2016, 7:44 a.m., Martin Gräßlin wrote: > > How would one test this? I mean manual testing. If I pull in the patch, what do I need to do in ksysguard to actually see it in action? - Martin --- This is an automatically

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

2016-07-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128491/#review97686 --- How would one test this? ksysguardd/Linux/acpi.h (line 45)

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Martin Graesslin
On Thursday, July 21, 2016 12:03:26 AM CEST Michail Vοurlakos wrote: > > > > it means you couldn't use always visible mode, and you depend from > > > > having > > > > composite) > > > > > > - "Always visible" in that case I dont think is a necessity... But > > > playing > > > around with these

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Martin Graesslin
On Wednesday, July 20, 2016 8:53:03 PM CEST Marco Martin wrote: > On Wednesday 20 July 2016 21:15:33 Michail Vοurlakos wrote: > > Hello, > > > > I am trying to implement a plasmoid task manager that behaves > > like the Mac or the Plank one.. > > the code can be found here:

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

2016-07-20 Thread bshah (Bhushan Shah)
bshah added inline comments. INLINE COMMENTS > graesslin wrote in kwinqml.cpp:63 > don't use qDebug, please use categorized logging. I'd say just remove this and debug statement below, they can get noisy, because it will be triggered at every frame repaint. > kwinqml.cpp:112-113 > +n

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 52 - Still Failing!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 02:47:04 + Build duration: 2 min 24 sec CHANGE SET No changes

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 14 - Fixed!

2016-07-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/14/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 02:03:19 + Build duration: 1 min 30 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 14 - Fixed!

2016-07-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/14/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 02:03:19 + Build duration: 1 min 30 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 274 - Still unstable!

2016-07-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/274/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 01:35:56 + Build duration: 10 min CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 204 - Still Failing!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/204/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 01:35:45 + Build duration: 4 min 18 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 2 - Still Failing!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 01:34:33 + Build duration: 1 min 43 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 51 - Still Failing!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 01:09:04 + Build duration: 4 min 49 sec CHANGE SET No changes

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

2016-07-20 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128491/ --- (Updated July 21, 2016, 1:13 a.m.) Review request for Plasma and John

[Differential] [Request, 4 lines] D2240: Anchors in a layout item is always wrong

2016-07-20 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Opened it, looks the same REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Request, 2 lines] D2241: Remove dead code

2016-07-20 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Setting the layout height to be the height of one of the layout items is both pointless, it

[Differential] [Updated] D2239: Workaround searching lockup

2016-07-20 Thread davidedmundson (David Edmundson)
davidedmundson updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2239 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, jensreuterberg,

Re: Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

2016-07-20 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128491/ --- (Updated July 21, 2016, 12:13 a.m.) Review request for Plasma and John

Review Request 128491: Give more useful names to the acpi thermal zones and cooling devices

2016-07-20 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128491/ --- Review request for Plasma and John Tapsell. Repository: ksysguard

[Differential] [Request, 2 lines] D2239: Workaround searching lockup

2016-07-20 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QQC::ScrollView has an annoying bug where you can get it in a situation where if you have

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 50 - Still Failing!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 23:16:57 + Build duration: 5 min 7 sec CHANGE SET No changes

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Michail Vοurlakos
Στις Τετάρτη, 20 Ιουλίου 2016 10:34:01 Μ.Μ. EEST Marco Martin έγραψε: > On Wednesday 20 July 2016 15:39:36 Ken Vermette wrote: > > One thing that I (kind of) pitched during a sprint, I'll mention it here > > for discussion; > > > > What if we created a new class of widget called a "dock widget".

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Michail Vοurlakos
> > > > it means you couldn't use always visible mode, and you depend from > > > having > > > composite) > > > > - "Always visible" in that case I dont think is a necessity... But playing > > around with these docks, an option for panel to be just "Below Active" do > > you think that it would be

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Marco Martin
On Wednesday 20 July 2016 22:20:10 Michail Vοurlakos wrote: > > you would need to have a very big panel, mostly completely transparent > > (so > > - a very big panel in order for the height to make the animation right? yes > > it means you couldn't use always visible mode, and you depend from

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Marco Martin
On Wednesday 20 July 2016 15:39:36 Ken Vermette wrote: > One thing that I (kind of) pitched during a sprint, I'll mention it here > for discussion; > > What if we created a new class of widget called a "dock widget". yes we have them... they are called "panels", really :p you can write a widget

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 1 - Failure!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 20:20:28 + Build duration: 1 min 4 sec CHANGE SET No changes

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Ken Vermette
One thing that I (kind of) pitched during a sprint, I'll mention it here for discussion; What if we created a new class of widget called a "dock widget". Behaviourally, these widgets would be clamped to a screen edge, owning that edge in the same ways as a panel. Dock widgets could anchor and

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Michail Vοurlakos
Στις Τετάρτη, 20 Ιουλίου 2016 8:53:03 Μ.Μ. EEST Marco Martin έγραψε: > On Wednesday 20 July 2016 21:15:33 Michail Vοurlakos wrote: > > Hello, > > > > I am trying to implement a plasmoid task manager that behaves > > like the Mac or the Plank one.. > > the code can be found here:

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Marco Martin
On Wednesday 20 July 2016 21:15:33 Michail Vοurlakos wrote: > Hello, > > I am trying to implement a plasmoid task manager that behaves > like the Mac or the Plank one.. > the code can be found here: https://github.com/psifidotos/plasmaqmldock[1] > it is in a very early stage but the animation is

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Michail Vοurlakos
Στις Τετάρτη, 20 Ιουλίου 2016 3:22:27 Μ.Μ. EEST David Edmundson έγραψε: > No, that'd be trying to draw outside the window/openGL viewport, there's no > way that can happen. Sorry. > > The only possible solution is changing the panel to only draw half the > height of the view, but that's opening a

Re: Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread David Edmundson
No, that'd be trying to draw outside the window/openGL viewport, there's no way that can happen. Sorry. The only possible solution is changing the panel to only draw half the height of the view, but that's opening a whole mess that you probably don't want to get into. David

Is it possible for a plasmoid to overlap the panel?

2016-07-20 Thread Michail Vοurlakos
Hello, I am trying to implement a plasmoid task manager that behaves like the Mac or the Plank one.. the code can be found here: https://github.com/psifidotos/plasmaqmldock[1] it is in a very early stage but the animation is there and showing and hiding windows also... Adding the plasmoid to

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 203 - Failure!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 16:55:02 + Build duration: 1 min 21 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 34 - Still Failing!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 16:53:52 + Build duration: 1 min 21 sec CHANGE SET Revision

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

2016-07-20 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. When adding a new design can you describe the design in words. i.e what roles a class has It'd make things a lot easier. ScreenPool: It seems to have two jobs: - you've got the converting screen "names" to IDs. - "Tracking" DesktopViews

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 273 - Failure!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/273/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 15:04:01 + Build duration: 1 min 25 sec CHANGE SET Revision

[Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland

2016-07-20 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwinqml.cpp:63 > +[this] (ShellSurfaceInterface *shellSurface) { > +qDebug() << "Shell surface created"; > +m_surface =

[Differential] [Closed] D2156: improve output identification

2016-07-20 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN1bd8dc46e4cd: improve output identification (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2156?vs=5300=5361 REVISION DETAIL

[Differential] [Abandoned] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread ochurlaud (Olivier Churlaud)
ochurlaud abandoned this revision. ochurlaud added a comment. Screen too small, and would be a fix only for a niche type of users REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL PREFERENCES

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread drosca (David Rosca)
drosca added a comment. > But it takes more than half of my screen !!! Yes, because gridUnit sizing is broken. Here is how it looks on my system with patched plasma-framework: F189452: PDCLXFY.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

2016-07-20 Thread Sebastian Kügler
sebas added a comment. If @luebking is otherwise fine with it, why not merge it? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2164 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc:

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread ochurlaud (Olivier Churlaud)
ochurlaud added a comment. So just to show exactly my issue: F189465: comments.png Other applets are very fine! but look at the font size difference between the clock and the different parts of the calendar. I think on big screens it's good

[Differential] [Accepted] D2185: Handle restart of Compositor Scene correctly for Wayland client

2016-07-20 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > scene_qpainter_test.cpp:214 > + > +// now lets try to reinitialize the compositing scene > +auto oldScene =

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread Sebastian Kügler
sebas added a comment. @ochurlaud You're sure? The QGuiApplication::font() is the base for all sizing. Did you change the font, or the font size? (It could be that the fonts you've tried have similar metrics.) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread ochurlaud (Olivier Churlaud)
ochurlaud added a comment. In https://phabricator.kde.org/D2212#41485, @sebas wrote: > -1, the calendar is only going to look more cramped like this. > > Whitespace is useful and part of the visual language, don't just remove it. > > Also, the size of the calendar is oriented with

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread ochurlaud (Olivier Churlaud)
ochurlaud added a comment. @sebas: just for info, is here my panel config: [PlasmaViews][Panel 97][Horizontal1366] length=1164 thickness=24 the thickness is very small, and changing the font *does not* change the font in the calendar. REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2212#41489, @drosca wrote: > > But it takes more than half of my screen !!! > > Yes, because gridUnit sizing is broken. Here is how it looks on my system with patched plasma-framework: > F189452: PDCLXFY.png

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread drosca (David Rosca)
drosca added a comment. https://git.reviewboard.kde.org/r/125773/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma:_design, #plasma,

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread Sebastian Kügler
sebas added a comment. @drosca Which patch are you using? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma:_design, #plasma,

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread Sebastian Kügler
sebas added a comment. Well, it depends on font size plus whitespace. All the screens I've used are fine, btw, but for smaller screens, it may look a bit larger. Once it carries events, it will make better use of that space, anyway. REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread Sebastian Kügler
sebas added a comment. -1, the calendar is only going to look more cramped like this. Whitespace is useful and part of the visual language, don't just remove it. Also, the size of the calendar is oriented with the size of the systray popup, this change will make it inconsistent, and

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread ochurlaud (Olivier Churlaud)
ochurlaud added a comment. In https://phabricator.kde.org/D2212#41483, @mck182 wrote: > In https://phabricator.kde.org/D2212#41055, @drosca wrote: > > > The calendar popup size is fine for me (with patched plasma-framework), what I *still* think is broken is the gridSize scaling -

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread mck182 (Martin Klapetek)
mck182 added a comment. In https://phabricator.kde.org/D2212#41055, @drosca wrote: > The calendar popup size is fine for me (with patched plasma-framework), what I *still* think is broken is the gridSize scaling - see https://git.reviewboard.kde.org/r/125773/ > > You can also test

[Powerdevil] [Bug 353032] Add ability to set screen brightness for non-laptop displays so I can adjust to the room's lighting

2016-07-20 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=353032 Martin Gräßlin changed: What|Removed |Added Product|KScreen |Powerdevil

[Differential] [Closed] D2231: [plugins/qpa] Support SharingPlatformContext on the existing eglSurface and eglconfig

2016-07-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN44843f462f54: [plugins/qpa] Support SharingPlatformContext on the existing eglSurface and… (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2235: [platforms/x11] Properly reposition nested windows on resize events

2016-07-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN50645e8dbd49: [platforms/x11] Properly reposition nested windows on resize events (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2202: Support restarting the OpenGL compositor on Wayland

2016-07-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. graesslin marked an inline comment as done. Closed by commit rKWIN9d7ef58b2bd6: Support restarting the OpenGL compositor on Wayland (authored by graesslin). CHANGED PRIOR TO COMMIT

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 272 - Still Unstable!

2016-07-20 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/272/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 12:01:14 + Build duration: 9 min 40 sec CHANGE SET Revision

[Differential] [Accepted] D2202: Support restarting the OpenGL compositor on Wayland

2016-07-20 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2202 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Updated] D2202: Support restarting the OpenGL compositor on Wayland

2016-07-20 Thread Martin Gräßlin
graesslin marked an inline comment as done. graesslin added inline comments. INLINE COMMENTS > bshah wrote in scene_opengl_test.cpp:75-76 > ? Removed the KWIN_COMPOSE=Q line. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2202 EMAIL PREFERENCES

[Differential] [Accepted] D2235: [platforms/x11] Properly reposition nested windows on resize events

2016-07-20 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH platform-x11-properly-reposition REVISION DETAIL https://phabricator.kde.org/D2235 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 49 - Still Failing!

2016-07-20 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 20 Jul 2016 11:59:57 + Build duration: 2 min 44 sec CHANGE SET Revision

[Differential] [Accepted] D2233: Announce output changes to Wayland for platforms not handling outputs

2016-07-20 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. REPOSITORY rKWIN KWin BRANCH announce-output-changes-to-wayland REVISION DETAIL https://phabricator.kde.org/D2233 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Closed] D2233: Announce output changes to Wayland for platforms not handling outputs

2016-07-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINd0c488f4a283: Announce output changes to Wayland for platforms not handling outputs (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2233?vs=5347=5353#toc REPOSITORY

[Differential] [Closed] D2232: [plugins/hwcomposer] Use an RGBA_8888 format for rendering surface

2016-07-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINa95be71ec183: [plugins/hwcomposer] Use an RGBA_ format for rendering surface (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2200: Expose window geometry to PlasmaWindow

2016-07-20 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN8445008e85e8: Expose window geometry to PlasmaWindow (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2200?vs=5253=5352 REVISION DETAIL

[Differential] [Updated] D2233: Announce output changes to Wayland for platforms not handling outputs

2016-07-20 Thread Martin Gräßlin
graesslin marked an inline comment as done. REPOSITORY rKWIN KWin BRANCH announce-output-changes-to-wayland REVISION DETAIL https://phabricator.kde.org/D2233 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, sebas

[Differential] [Accepted] D2156: improve output identification

2016-07-20 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES

[Differential] [Request, 1 line] D2235: [platforms/x11] Properly reposition nested windows on resize events

2016-07-20 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The position of the output being resized was adjusted instead of

[Differential] [Accepted] D2233: Announce output changes to Wayland for platforms not handling outputs

2016-07-20 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKWIN KWin BRANCH announce-output-changes-to-wayland REVISION DETAIL https://phabricator.kde.org/D2233 EMAIL PREFERENCES

[Differential] [Request, 22 lines] D2234: [platforms/x11] Support output removal in nested setup

2016-07-20 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY When closing a nested window kwin_wayland only terminates if the

[Differential] [Updated] D2233: Announce output changes to Wayland for platforms not handling outputs

2016-07-20 Thread Martin Gräßlin
graesslin added a dependent revision: D2234: [platforms/x11] Support output removal in nested setup. REPOSITORY rKWIN KWin BRANCH announce-output-changes-to-wayland REVISION DETAIL https://phabricator.kde.org/D2233 EMAIL PREFERENCES

[Differential] [Updated] D2234: [platforms/x11] Support output removal in nested setup

2016-07-20 Thread Martin Gräßlin
graesslin added a dependency: D2233: Announce output changes to Wayland for platforms not handling outputs. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2234 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Changed Subscribers] D2202: Support restarting the OpenGL compositor on Wayland

2016-07-20 Thread bshah (Bhushan Shah)
bshah added inline comments. INLINE COMMENTS > scene_opengl_test.cpp:75-76 > +qputenv("XCURSOR_SIZE", QByteArrayLiteral("24")); > +qputenv("KWIN_COMPOSE", QByteArrayLiteral("Q")); > +qputenv("KWIN_COMPOSE", QByteArrayLiteral("O2")); > + ? REPOSITORY rKWIN KWin REVISION DETAIL

[Differential] [Commented On] D2156: improve output identification

2016-07-20 Thread Sebastian Kügler
sebas added a comment. @davidedmundson Did you also get to try it? REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: davidedmundson, graesslin, lbeltrame,

[Differential] [Changed Subscribers] D2233: Announce output changes to Wayland for platforms not handling outputs

2016-07-20 Thread bshah (Bhushan Shah)
bshah added inline comments. INLINE COMMENTS > screens_virtual.cpp:41 > [this] (const QVector ) { > // TODO: update Wayland Output > +const int oldCount = m_geometries.count(); Remove this comment? REPOSITORY rKWIN KWin REVISION DETAIL

[Differential] [Accepted] D2231: [plugins/qpa] Support SharingPlatformContext on the existing eglSurface and eglconfig

2016-07-20 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Tested and works... REPOSITORY rKWIN KWin BRANCH sharingplatform-hwcomposer REVISION DETAIL https://phabricator.kde.org/D2231 EMAIL PREFERENCES

Re: Review Request 128485: Reposition the krunner window if the width changes

2016-07-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128485/ --- (Updated July 20, 2016, 10:28 a.m.) Status -- This change has been

[Differential] [Request, 201 lines] D2233: Announce output changes to Wayland for platforms not handling outputs

2016-07-20 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Most platforms like the nested and virtual do not handle the

[Differential] [Closed] D2144: Fix warnings

2016-07-20 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI50b4b7b032a2: Fix warnings (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2144?vs=5345=5346 REVISION DETAIL

[Differential] [Accepted] D2144: Fix warnings

2016-07-20 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2144 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

[Differential] [Updated, 27 lines] D2144: Fix warnings

2016-07-20 Thread apol (Aleix Pol Gonzalez)
apol updated this revision to Diff 5345. apol added a comment. Fix morphing, proper testing REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2144?vs=5344=5345 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2144 AFFECTED FILES

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

2016-07-20 Thread Dimitar Petrovski via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365318 --- Comment #14 from Dimitar Petrovski --- Sorry for the slow response. As I have stated above, if I set the theme from Look & Feel to breeze dark, the problem is present, but it is fixed if I set also breeze dark to gtk2 setting.

[Differential] [Updated, 22 lines] D2144: Fix warnings

2016-07-20 Thread apol (Aleix Pol Gonzalez)
apol updated this revision to Diff 5344. apol added a comment. Address Marco's comment REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2144?vs=5096=5344 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2144 AFFECTED FILES

[Differential] [Commented On] D2144: Fix warnings

2016-07-20 Thread apol (Aleix Pol Gonzalez)
apol added a comment. > why adding check over mainFlickable.currentItem ? doesn't guard anything We don't want `mainFlickable.currentItem.width` to fail if `mainFlickable.currentItem` is null. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2144 EMAIL

[Differential] [Accepted] D2200: Expose window geometry to PlasmaWindow

2016-07-20 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH plasma-window-expose-geometry REVISION DETAIL https://phabricator.kde.org/D2200 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

Re: [kde-community] Usage of QNetworkAccessManager

2016-07-20 Thread Richard Moore
On 14 July 2016 at 17:38, Thiago Macieira wrote: > On quinta-feira, 14 de julho de 2016 18:33:37 PDT Ben Cooksley wrote: > > > Unfortunately, from it's first iteration in Qt 4 QNetworkAccessManager > > w > ​e ​ > as shipped with a severe and fundamental defect in that it does not

Re: The situation of KWallet, and what to do about it?

2016-07-20 Thread Valentin Rusu
* Thomas Pfeiffer [2016-07-13 11:41:14 +0200]: > > On Linux we could use GNOME Keyring, but if we don't want that, we'd of > course still have to implement our own backend. The advantage would be that > it would be much easier to replace that at any point without having

[sysadmin/ci-master-config] /: Change the versions of Qt 5 used on the CI system.

2016-07-20 Thread Ben Cooksley
Git commit 0b3511e4c66cce6206b04294c504cfbf93ae7056 by Ben Cooksley. Committed on 20/07/2016 at 07:58. Pushed by bcooksley into branch 'master'. Change the versions of Qt 5 used on the CI system. As Qt's compatibility between versions usually breaks on the CI, expect many things to break until

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

2016-07-20 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Pretty! Having the sub-categories shown by default and being able to navigate to them directly is a significant improvement over the old layout. The layout layout doesn't handle different font sizes very well, I run at 125 dpi with 1x device pixel ratio which

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

2016-07-20 Thread Ivan Čukić
ivan added a comment. > Is that different to how it was before? Before, we had the icon and the text - and the whole are was one-clickable thing. Having different sub-areas with bigger differences in behaviour, and not having them visually separated is a problem (the thing

[Differential] [Accepted] D2232: [plugins/hwcomposer] Use an RGBA_8888 format for rendering surface

2016-07-20 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH hwcomposer-format-rgba REVISION DETAIL https://phabricator.kde.org/D2232 EMAIL PREFERENCES