Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 295 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/295/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 03 Aug 2016 05:38:08 + Build duration: 7 min 34 sec CHANGE SET Revision

[Differential] [Closed] D2242: [ksplash] Better support for Wayland with multiple screens

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE156b9030d201: [ksplash] Better support for Wayland with multiple screens (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2242?vs=5381=5646#toc REPOSITORY

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 294 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/294/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 03 Aug 2016 05:19:22 + Build duration: 13 min CHANGE SET Revision

Review Request 128588: Make it possible to load metadata.json file from kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128588/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Review Request 128590: Let kpackagetool5 generate appstream information for kpackage components

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128590/ --- Review request for KDE Frameworks, Plasma, Matthias Klumpp, and Harald

[Differential] [Request, 3 lines] D2341: Lazy guard for KServiceGroup::root() being null.

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This will happen if KSycoca::ensureCacheValid fails. (which shouldn't ever happen).

Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98020 --- Works for me, thanks! - Andreas Sturmlechner On Aug. 2,

[Differential] [Requested A Review Of] D2330: [xrandr backend] fall back to preferred mode, fix crash

sebas requested a review of this revision. REPOSITORY rLIBKSCREEN KScreen Library REVISION DETAIL https://phabricator.kde.org/D2330 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, dvratil, graesslin Cc: graesslin, plasma-devel, #plasma,

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128573/ --- (Updated Aug. 2, 2016, 4:45 p.m.) Status -- This change has been

Review Request 128579: Use KPackage to install Plasma Packages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128579/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Selecting a Plasma logo

On 02.08.2016 16:31, Ken Vermette wrote: I don't mean to be "that guy", but he submitted his logo under the LGPLv3, signalling that everyone has the right to modify his work. I'm not saying this because I have a horse in this race, I'm saying it because, frankly, the idea that we "aren't

[Differential] [Updated] D2339: support plasmoid config restore on applet add

mart added reviewers: Plasma, hein. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2339 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, hein Cc: plasma-devel, ali-mohamed, jensreuterberg, abetts,

[Differential] [Request, 13 lines] D2339: support plasmoid config restore on applet add

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY if a configuration for applet geometries is already there, use it when an applet is added. this makes possible to do with desktop scripting:

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128573/#review98015 --- Ship it! Do you have commit access? - David Edmundson

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128573/ --- (Updated Aug. 2, 2016, 3:32 p.m.) Review request for Plasma and Eike

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

> On Aug. 2, 2016, 10:08 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 472 > > > > > > why loop if we're going to use m_overlay every time? > > Chinmoy Ranjan Pradhan wrote: >

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

> On Aug. 2, 2016, 10:08 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 472 > > > > > > why loop if we're going to use m_overlay every time? > > Chinmoy Ranjan Pradhan wrote: >

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

> On Aug. 2, 2016, 10:08 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 472 > > > > > > why loop if we're going to use m_overlay every time? > > Chinmoy Ranjan Pradhan wrote: >

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

> On Aug. 2, 2016, 10:08 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 472 > > > > > > why loop if we're going to use m_overlay every time? KIconloader::drawOverlays assumes

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128573/ --- (Updated Aug. 2, 2016, 3:08 p.m.) Review request for Plasma and Eike

Re: From Grub to Shutdown project update

On 25.07.2016 12:59, Marco Martin wrote: now, one thing i would like to happen is people taking up a piece of it, of the thing they are more versed into (being sddm, the lockscreen, whatever) signal here they are going to work on it, and have the pieces of the puzzle then merged in master asap

Re: Selecting a Plasma logo

Just for completeness - Andy's response: > Hey Ivan, thanks for asking. At this time, I want to keep that logo as is, > without drastic modifications. Maybe one can make the argument that > including more elements has a background and a reason. But at this > point, I want to keep this logo the

Re: Selecting a Plasma logo

Thomas: > The VDG is fine with his proposal as is, but the Plasma team did > not seem to 100% happy with it. As far as I'm concerned, 'not 100% happy' is an understatement. It has nice visuals, but it is not a brand, nor is it recognizable. Ken: > With all due respect to Anditosan, I think he

[Differential] [Request, 3 lines] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 created this revision. net147 added reviewers: broulik, Plasma. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 345741 TEST PLAN

[Differential] [Updated] D2338: [Kickoff] Fix start row for drag not always being correct

net147 added a reviewer: bshah. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, broulik, #plasma, bshah Cc: plasma-devel, ali-mohamed, jensreuterberg,

[Differential] [Updated] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 added a reviewer: bshah. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, broulik, #plasma, bshah Cc: plasma-devel, ali-mohamed, jensreuterberg,

[Differential] [Commented On] D2338: [Kickoff] Fix start row for drag not always being correct

net147 added a comment. This is a backport of https://phabricator.kde.org/D2322 fix for Plasma 5.7. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147,

Re: Selecting a Plasma logo

I don't mean to be "that guy", but he submitted his logo under the LGPLv3, signalling that everyone has the right to modify his work. I'm not saying this because I have a horse in this race, I'm saying it because, frankly, the idea that we "aren't allowed" to collaborate and remix artwork in an

[Differential] [Commented On] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

net147 added a comment. This is a backport of https://phabricator.kde.org/D2310 fix for Plasma 5.7. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147,

[Differential] [Request, 2 lines] D2338: [Kickoff] Fix start row for drag not always being correct

net147 created this revision. net147 added reviewers: broulik, Plasma. net147 set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The start row for the

Re: Cleaning up Old Synchrotron Resources

On Tue, Jun 28, 2016 at 2:14 PM, Marco Martin wrote: > > On Monday 27 June 2016, R.Harish Navnit wrote: > > > There are also a lot of resources for public transport providers (added > > > by Friedrich Karl Tilman Pülz), but I suppose that those are not Plasma > > > related? > >

Re: Selecting a Plasma logo

On 02.08.2016 16:08, Sebastian Kügler wrote: Why modify it after a contest? That would make the choice rather pointless, if it's going to be different aftwards anyway. Can you ask him to make the changes and send us the result, so we can judge based on that? Sure. So what changes would the

[Differential] [Requested Changes To] D2330: [xrandr backend] fall back to preferred mode, fix crash

graesslin requested changes to this revision. graesslin added a reviewer: graesslin. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > xrandrconfig.cpp:556-558 > +int modeId = modeId = xOutput->currentModeId().toInt(); > +if

Re: Selecting a Plasma logo

@Sebas We asked him whether he would allow changes to his proposal - mainly since we are here mostly considering Ken's modifications of Alex's and his work.* He seems not to like the idea of anyone altering his work - that he considered different modifications already, but stayed with the

Re: Selecting a Plasma logo

On dinsdag 2 augustus 2016 14:11:25 CEST Thomas Pfeiffer wrote: > On 01.08.2016 15:11, Thomas Pfeiffer wrote: > > So, it looks like there are two variants which people are quite fond of, > > Ken's modifications of Andy's logo (his fourth), and of Alex's logo (his > > second). > > > > The second

[Differential] [Closed] D2336: update CRTCs before enabling an output

This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREENc2e1becccec9: update CRTCs before enabling an output (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2336?vs=5639=5640

[Differential] [Accepted] D2336: update CRTCs before enabling an output

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. Looks good to me REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/crtcupdate REVISION DETAIL https://phabricator.kde.org/D2336 EMAIL

[Differential] [Request, 3 lines] D2336: update CRTCs before enabling an output

sebas created this revision. sebas added a reviewer: dvratil. sebas added a subscriber: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When connecting the docking station (Lenovo OneLink+), which has a VGA

[Differential] [Updated, 19 lines] D2330: [xrandr backend] fall back to preferred mode, fix crash

sebas updated this revision to Diff 5638. sebas added a comment. - address comments from mgraesslin and dvratil REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2330?vs=5621=5638 BRANCH sebas/modefallback REVISION DETAIL

[Differential] [Closed] D2334: Respect the bottomPadding for the bottom of the drawer

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI7f92f7f9a314: Respect the bottomPadding for the bottom of the drawer (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5636=5637

[Differential] [Accepted] D2334: Respect the bottomPadding for the bottom of the drawer

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol updated this revision to Diff 5636. apol added a comment. Use padding when necessary REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5635=5636 BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334 AFFECTED FILES

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol updated this revision to Diff 5635. apol added a comment. Use padding to place the top element as well REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5633=5635 BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334

[Differential] [Commented On] D2334: Respect the bottomPadding for the bottom of the drawer

mart added inline comments. INLINE COMMENTS > GlobalDrawer.qml:269 > Layout.alignment: Qt.AlignHCenter > -Layout.minimumWidth: parent.width - Units.smallSpacing*2 > -Layout.maximumWidth: Layout.minimumWidth > -

[Differential] [Closed] D2333: [Task Manager] Add back mnemonics for context menu

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP41064e33b965: [Task Manager] Add back mnemonics for context menu (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2333?vs=5628=5634#toc REPOSITORY

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol updated this revision to Diff 5633. apol added a comment. Update patch REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5630=5633 BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334 AFFECTED FILES

[Differential] [Closed] D2335: Respect the bottomPadding for the bottom of the drawer

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI2e8371f5bc69: Respect the bottomPadding for the bottom of the drawer (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2335?vs=5631=5632

Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/ --- Review request for KDE Frameworks and Plasma. Bugs: 362531

Re: Selecting a Plasma logo

On 01.08.2016 15:11, Thomas Pfeiffer wrote: So, it looks like there are two variants which people are quite fond of, Ken's modifications of Andy's logo (his fourth), and of Alex's logo (his second). The second has the advantage that it has elements of the KDE logo in it and can therefore be

[Differential] [Accepted] D2335: Respect the bottomPadding for the bottom of the drawer

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH bottom REVISION DETAIL https://phabricator.kde.org/D2335 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

[Differential] [Request, 2 lines] D2335: Respect the bottomPadding for the bottom of the drawer

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make it possible to not leave an empty space below the drawer REPOSITORY rKIRIGAMI Kirigami BRANCH

[Differential] [Abandoned] D2329: Let the drawer contents take the full width

apol abandoned this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2329 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel ___

Plasma 5.7.3 is out

With fixes for kactivitymanagerd https://www.kde.org/announcements/plasma-5.7.3.php Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2334: Respect the bottomPadding for the bottom of the drawer

mart added inline comments. INLINE COMMENTS > GlobalDrawer.qml:269 > Layout.alignment: Qt.AlignHCenter > -Layout.minimumWidth: parent.width - Units.smallSpacing*2 > -Layout.maximumWidth: Layout.minimumWidth > -

[Differential] [Request, 17 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use Layout attached property margins rather than trying to compute sizes REPOSITORY rKIRIGAMI Kirigami

[Differential] [Planned Changes To] D2330: [xrandr backend] fall back to preferred mode, fix crash

sebas planned changes to this revision. sebas added inline comments. INLINE COMMENTS > graesslin wrote in xrandrconfig.cpp:517-520 > it looks strange to me that you first access the currentModeId and afterwards > check whether there is a currentMode. > > What about a one liner? > > const

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128573/#review97995 --- src/declarativeimports/core/iconitem.h (line 127)

Re: Review Request 128571: Add Qt::Dialog to default flags to make QXcbWindow::isTransient() happy.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128571/ --- (Updated Aug. 2, 2016, 10:20 a.m.) Status -- This change has been

[Differential] [Accepted] D2333: [Task Manager] Add back mnemonics for context menu

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2333 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D2328: Speed up loading KCM with FileDialog lazy loading

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP60e970472a5e: Speed up loading KCM with FileDialog lazy loading (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Review Request 128573: Add overlay support to PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128573/#review97994 --- src/declarativeimports/core/iconitem.cpp (line 222)

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/ --- (Updated Aug. 2, 2016, 10:53 a.m.) Review request for KDE Frameworks,

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/#review97993 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 8:26

[Differential] [Request, 30 lines] D2333: [Task Manager] Add back mnemonics for context menu

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In the old

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/ --- (Updated Aug. 2, 2016, 10:26 a.m.) Review request for KDE Frameworks,

Review Request 128573: Add overlay support to PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128573/ --- Review request for Plasma and Eike Hein. Repository: plasma-framework

Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository:

[Differential] [Updated] D2330: [xrandr backend] fall back to preferred mode, fix crash

dvratil added a comment. I wonder how it happens that we try to enable an output without having the mode set. The KDED module should always pick the best resolution (or falling back to preferred mode) when it's enabling an output. While this fix makes sense in as a crash-guard, I'd also

[Differential] [Closed] D2322: [Kickoff] Fix start row for drag not always being correct

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP6b8b17897664: [Kickoff] Fix start row for drag not always being correct (authored by net147, committed by bshah). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2322: [Kickoff] Fix start row for drag not always being correct

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2322 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, broulik, #plasma Cc:

[Differential] [Closed] D2310: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPae319ac4fbe6: [Kickoff] Fix being unable to reorder entries in favorites menu after… (authored by net147, committed by bshah). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST