[Differential] [Request, 28 lines] D2525: RFC: Make Switch User option invoke the switch user UI in the lockscreen

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of having a separate switch user screen, we just invoke the lock screen with a

[Differential] [Request, 135 lines] D2524: New User Switcher

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY See Pholio mockup TEST PLAN Switched User... REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Request, 838 lines] D2523: New lockscreen

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY New lockscreen TEST PLAN Locked screen and unlocked Checked caps lock warning Checked

Re: Discussion about module-device-manager change to module-switch-on-connect

2016-08-21 Thread Mark Gaiser
On Sun, Aug 21, 2016 at 10:58 PM, David Edmundson < da...@davidedmundson.co.uk> wrote: > > > On Sun, Aug 21, 2016 at 8:33 PM, Mark Gaiser wrote: > >> On Sun, Aug 21, 2016 at 4:25 PM, David Rosca wrote: >> >>> Hi, >>> >>> On Sun, Aug 21, 2016 at 4:16 PM, Mark

Re: Discussion about module-device-manager change to module-switch-on-connect

2016-08-21 Thread David Edmundson
On Sun, Aug 21, 2016 at 8:33 PM, Mark Gaiser wrote: > On Sun, Aug 21, 2016 at 4:25 PM, David Rosca wrote: > >> Hi, >> >> On Sun, Aug 21, 2016 at 4:16 PM, Mark Gaiser wrote: >> > Hi, >> > >> >> > >> > What i'd like for this thread is to

[Breeze] [Bug 364849] Tooltip Text in several qt apps such as Amarok and Krusader is unreadable (white on white) with the Breeze/Breeze Dark color schemes

2016-08-21 Thread Sebastian Turzański via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364849 Sebastian Turzański changed: What|Removed |Added CC||dpba...@wp.pl --- Comment

Re: Review Request 128726: klipper shortcut for open clipboard at mouse point

2016-08-21 Thread Thomas Pfeiffer
> On Aug. 21, 2016, 7:08 a.m., Martin Gräßlin wrote: > > As the maintainer of both klipper and kglobalaccel I'm strictly against > > ading this shortcut by default! This was already stated by me in the bug > > report by setting it to wontfix. > > > > At the moment this would result in a

[Differential] [Closed] D2520: Add option for module-switch-on-connect

2016-08-21 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA008f6b32f5ff: Add option for module-switch-on-connect (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2520?vs=6121=6126#toc REPOSITORY rPLASMAPA Plasma

Re: Discussion about module-device-manager change to module-switch-on-connect

2016-08-21 Thread Mark Gaiser
On Sun, Aug 21, 2016 at 4:25 PM, David Rosca wrote: > Hi, > > On Sun, Aug 21, 2016 at 4:16 PM, Mark Gaiser wrote: > > Hi, > > > > > > > What i'd like for this thread is to consider loading > > module-switch-on-connect by default (changing the line in > >

Re: Review Request 128726: klipper shortcut for open clipboard at mouse point

2016-08-21 Thread Andreas Kainz
> On Aug. 21, 2016, 7:08 vorm., Martin Gräßlin wrote: > > As the maintainer of both klipper and kglobalaccel I'm strictly against > > ading this shortcut by default! This was already stated by me in the bug > > report by setting it to wontfix. > > > > At the moment this would result in a

Re: Review Request 128726: klipper shortcut for open clipboard at mouse point

2016-08-21 Thread Martin Gräßlin
> On Aug. 21, 2016, 9:08 a.m., Martin Gräßlin wrote: > > As the maintainer of both klipper and kglobalaccel I'm strictly against > > ading this shortcut by default! This was already stated by me in the bug > > report by setting it to wontfix. > > > > At the moment this would result in a

Re: Review Request 128728: Update plasma handbook

2016-08-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128728/ --- (Updated Aug. 21, 2016, 6:07 nachm.) Review request for Documentation

Re: Review Request 128728: Update plasma handbook

2016-08-21 Thread Yuri Chornoivan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128728/#review98531 --- doc/plasma-desktop/index.docbook (line 549)

Review Request 128728: Update plasma handbook

2016-08-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128728/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

[Differential] [Accepted] D2520: Add option for module-switch-on-connect

2016-08-21 Thread drosca (David Rosca)
drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D2520 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D2521: Only trigger keyboard layout OSD if KWin manages input

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH osd-only-with-libinput REVISION DETAIL https://phabricator.kde.org/D2521 EMAIL PREFERENCES

[Differential] [Request, 17 lines] D2521: Only trigger keyboard layout OSD if KWin manages input

2016-08-21 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY On platforms where KWin does not manage input, that is does not

[Differential] [Updated, 96 lines] D2520: Add option for module-switch-on-connect

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 6121. davidedmundson added a comment. Add Module Management methods in GConfItem subclass Fixed Droscas comment plus refactor to reduce code duplication REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

[Differential] [Requested Changes To] D2520: Add option for module-switch-on-connect

2016-08-21 Thread drosca (David Rosca)
drosca requested changes to this revision. drosca added a reviewer: drosca. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > modulemanager.cpp:74 > + > +if (switchOnConnect) { > +m_switchOnConnectConfig->set(QStringLiteral("name0"), >

[Differential] [Request, 42 lines] D2520: Add option for module-switch-on-connect

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add option to enable switch-on-connect. See

Re: Discussion about module-device-manager change to module-switch-on-connect

2016-08-21 Thread Kai Uwe Broulik
In my opinion the default usecase for the majority of users is "plug in TV and get sound there". I don't want to fiddle around with settings just because of that, especially because KScreen usually does the right thing in this case. But I see that the old behavior should be configurable but the

Re: Discussion about module-device-manager change to module-switch-on-connect

2016-08-21 Thread Martin Gräßlin
Am 2016-08-21 16:16, schrieb Mark Gaiser: Hi, Disclaimer: Specially on this list i tend to jump to conclusions or come across as rude at times. I'm trying to be constructive here with a "what would the user like best" point of view. The background for this topic started ~2 years ago. I tried

Re: Discussion about module-device-manager change to module-switch-on-connect

2016-08-21 Thread David Edmundson
On Sun, Aug 21, 2016 at 3:24 PM, Kai Uwe Broulik wrote: > Hi, > > David Edmundson had a look at this but it needs some gconf Foo to have > PulseAudio load it on startup as far as I understood. Dunno what the state > of that is, though. > > The gconf foo is all there and

Re: Discussion about module-device-manager change to module-switch-on-connect

2016-08-21 Thread David Rosca
Hi, On Sun, Aug 21, 2016 at 4:16 PM, Mark Gaiser wrote: > Hi, > > > What i'd like for this thread is to consider loading > module-switch-on-connect by default (changing the line in > start-pulseaudio-x11) and thus consider removing "module-device-manager". It > would most

Re: Discussion about module-device-manager change to module-switch-on-connect

2016-08-21 Thread Kai Uwe Broulik
Hi, David Edmundson had a look at this but it needs some gconf Foo to have PulseAudio load it on startup as far as I understood. Dunno what the state of that is, though. Cheers,  Kai Uwe

Discussion about module-device-manager change to module-switch-on-connect

2016-08-21 Thread Mark Gaiser
Hi, Disclaimer: Specially on this list i tend to jump to conclusions or come across as rude at times. I'm trying to be constructive here with a "what would the user like best" point of view. The background for this topic started ~2 years ago. I tried to get my USB headphone to work with

[Differential] [Request, 8 lines] D2517: Fix warning

2016-08-21 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Can't assign an edge to an anchor

[Differential] [Request, 92 lines] D2516: Nicer serialization of configuration options

2016-08-21 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The previous approach of having an array of object that hold information about the current config group and

[Differential] [Updated, 40 lines] D2515: Remove unused property

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 6113. davidedmundson added a comment. Fixing fixing fixing REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2515?vs=6112=6113 BRANCH master REVISION DETAIL

[Differential] [Closed] D2493: Set uniform icon sizes in UserManager gallery

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson closed this revision. davidedmundson added a comment. pushed as https://phabricator.kde.org/rUSERMANAGER820f6568d0d444e60b2cc017dd6de23051574296 REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D2493 EMAIL PREFERENCES

[Differential] [Updated, 40 lines] D2515: Remove unused property

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 6112. davidedmundson added a comment. fix property REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2515?vs=6111=6112 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2515

[Differential] [Commented On] D2515: Remove unused property

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. In https://phabricator.kde.org/D2515#47036, @broulik wrote: > Don't you need plasma core for units? I thought we didn't want to pull that in for startup time of the splash. That's why I dont' pull it in. There's a QFontMetrics item call unit.

[Differential] [Commented On] D2515: Remove unused property

2016-08-21 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Don't you need plasma core for units? I thought we didn't want to pull that in for startup time of the splash. INLINE COMMENTS > Splash.qml:46 > +property int gridUnit: boundingRect.height > +property int largeSpacing: units.largeSpacing > +

[Differential] [Updated, 40 lines] D2515: Remove unused property

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 6111. davidedmundson added a comment. Silly phab REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2515?vs=6110=6111 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2515

[Differential] [Request, 41 lines] D2515: Remove unused property

2016-08-21 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sync KSplash layout from SDDM mockup TEST PLAN ksplashqml --test REPOSITORY

Re: Review Request 128726: klipper shortcut for open clipboard at mouse point

2016-08-21 Thread Andreas Kainz
> On Aug. 21, 2016, 7:08 vorm., Martin Gräßlin wrote: > > As the maintainer of both klipper and kglobalaccel I'm strictly against > > ading this shortcut by default! This was already stated by me in the bug > > report by setting it to wontfix. > > > > At the moment this would result in a

Re: Review Request 128726: klipper shortcut for open clipboard at mouse point

2016-08-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128726/#review98523 --- As the maintainer of both klipper and kglobalaccel I'm