[Differential] [Commented On] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

bgupta added a comment. In https://phabricator.kde.org/D2983#55400, @markuss wrote: > This patch modifies an existing file. Removing the original copyright is illegal! If you want your new code to be under a different license (which is fine), you need to rework the header to state:

[Differential] [Accepted] D2985: Quicklaunch: Listen to external configuration changes

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2985 EMAIL PREFERENCES

[Differential] [Request, 6 lines] D2995: No-op SeachRunner if indexing is disabled

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We won't have any results anyway. TEST PLAN Disabled indexing and put a qDebug in the if

Re: Review Request 128956: Make KF5Baloo optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128956/#review99897 --- Ship it! Ship It! - David Edmundson On Sept. 20, 2016,

Re: Review Request 128956: Make KF5Baloo optional

> On Oct. 9, 2016, 5:46 p.m., Andreas Hartmetz wrote: > > Why not add logic to the runner to disable it automatically in the > > appropriate conditions? It doesn't have to be as simplistic as "there is no > > Baloo database at all". The other Andreas sort of suggested that and > > dismissed

Re: Review Request 128956: Make KF5Baloo optional

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. > > Andreas Sturmlechner wrote: > That's not quite true; even

[Differential] [Closed] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe26c52414600: Center the notification label on Breeze's lockscreen (authored by pritambaral, committed by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST

[Differential] [Commented On] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

pritambaral added a comment. Apparently, the Qt preferred way of aligning elements inside layouts is using the `Layout.` properties instead of anchors. So I'm just going to leave the revision as is for now, and attribute the wrong wrap trigger as a bug in Qt when the width of an element

[Differential] [Accepted] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pritambaral wrote in SessionManagementScreen.qml:89-90 > It isn't. `Layout.alignment` controls

[Differential] [Commented On] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

pritambaral added a comment. Oddly enough, setting `anchors` instead of `Layout` does fix one of the original issues; the one about word wrap wrongly triggering when there is room available on the first line. I guess the `Layout.alignment` line @davidedmundson pointed out is in fact the

[Differential] [Commented On] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

pritambaral added a comment. @davidedmundson No, I do not have commit access. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2984 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pritambaral, #plasma Cc:

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

https://bugs.kde.org/show_bug.cgi?id=362988 --- Comment #6 from Toralf Förster --- created bug #370370 -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Commented On] D2984: Center the notification label on Breeze's lockscreen and make it use the full width before wrapping

davidedmundson added a comment. Generally good, just needs some a bit of tidying up Also do you have commit access? INLINE COMMENTS > SessionManagementScreen.qml:89-90 > id: notificationsLabel > Layout.maximumWidth: units.gridUnit * 16 >

[Differential] [Accepted] D2986: Systray: Move all icon resolution to dataengine

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks ever so much. Looks good. Do you have commit access? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH

Re: Review Request 128956: Make KF5Baloo optional

> On Sept. 20, 2016, 12:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. > > Andreas Sturmlechner wrote: > That's not quite true; even

Re: Review Request 128956: Make KF5Baloo optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128956/#review99882 --- Why not add logic to the runner to disable it automatically

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

https://bugs.kde.org/show_bug.cgi?id=362988 --- Comment #5 from Emmanuel Pescosta --- (In reply to Toralf Förster from comment #4) > whilst https://git.reviewboard.kde.org/r/129134/diff/1#index_header solves a > big fraction of this issue there's still 1 thing

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

https://bugs.kde.org/show_bug.cgi?id=362988 Toralf Förster changed: What|Removed |Added CC||toralf.foers...@gmx.de

[Differential] [Commented On] D2991: Fix moving windows to a different activity.

mart added a comment. in the old one iirc it moved the window REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2991 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmundson,

[Differential] [Updated, 73 lines] D2986: Systray: Move all icon resolution to dataengine

roberts updated this revision to Diff 7230. roberts added a comment. Recreated diff with arc. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2986?vs=7215=7230 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2986

[Differential] [Accepted] D2991: Fix moving windows to a different activity.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2991 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Commented On] D2991: Fix moving windows to a different activity.

hein added a comment. Not sure. This is what the old implementation did, which got lost due to a copy and paste error. I could see arguments for both behaviors (additive vs. exclusive). I don't use this functionality enough to know what users want. I'll ask in the bug ticket. REPOSITORY

[Differential] [Commented On] D2986: Systray: Move all icon resolution to dataengine

davidedmundson added a comment. Absolutely +1 to the idea. been meaning to do this for a while. However the diff seems broken, can you try reuploading. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2986 EMAIL PREFERENCES

[Differential] [Accepted] D2990: Fix circular logic causing Pager to remain hidden

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2990 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Updated] D2991: Fix moving windows to a different activity.

davidedmundson added a comment. If a window is on activity A & B and a user drags a window from B to C should the activitity still be on A? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2991 EMAIL PREFERENCES

[Differential] [Updated, 9 lines] D2985: Quicklaunch: Listen to external configuration changes

drosca updated this revision to Diff 7226. drosca added a comment. Disconnect form urlsChanged while setting urls to model REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2985?vs=7212=7226 BRANCH Plasma/5.8 REVISION DETAIL

[Differential] [Request, 4 lines] D2991: Fix moving windows to a different activity.

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY BUG:370317 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL

[Differential] [Request, 18 lines] D2990: Fix circular logic causing Pager to remain hidden

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY The Pager applet would transition to HiddenStatus if PagerModel.count was smaller than 2, however hiding the root