Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 60 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 06:31:56 + Build duration: 8 min 19 sec CHANGE SET Revision

[Differential] [Accepted] D4533: Avoid a crash on Kwin decoration KCM teardown

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. Hero! BRANCH scaling_final REVISION DETAIL https://phabricator.kde.org/D4533 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 740 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/740/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 04:47:21 + Build duration: 6 min 35 sec CHANGE SET Revision

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

idekels added a comment. I could not tell, I've tried changing git's language/locale but apparently there is no easy way to do that. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D4540 EMAIL PREFERENCES

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

cfeck added a comment. One issue: The comments for the change that broke this state that 'sshaskpass' has no translations, so the prompt is the same in any locale. Could you verify if 'git' uses the same prompt in any language/locale? REPOSITORY R105 KDE SSH Password Dialog REVISION

[Differential] [Updated] D4540: fix bug with git after update to Plasma 5.9 in neon

cfeck added reviewers: whiting, mpyne. cfeck added a comment. Thanks, this looks good so far, but adding more eyes, because it touches privacy sensitive code. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D4540 EMAIL PREFERENCES

[Differential] [Request, 11 lines] D4540: fix bug with git after update to Plasma 5.9 in neon

idekels created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY After an update to Plasma 5.9 in KDE Neon, ksshaskpass stop working. After diging a little on the web, I found that this bug

[Differential] [Updated] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

jsalatas updated the summary for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #frameworks, #plasma Cc: plasma-devel, kwrite-devel, lesliezhai,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 739 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/739/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 22:17:01 + Build duration: 8 min 0 sec CHANGE SET Revision

[Differential] [Closed] D4489: [kioslave/remote] Use kf5 coding style

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e32b68ed614b: [kioslave/remote] Use kf5 coding style (authored by elvisangelaccio). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4489?vs=11036=11138

[Differential] [Request, 6 lines] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

jsalatas created this revision. jsalatas added reviewers: Frameworks, Plasma. jsalatas set the repository for this revision to R39 KTextEditor. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: kwrite-devel, plasma-devel. REVISION SUMMARY This

[Differential] [Commented On] D4533: Avoid a crash on Kwin decoration KCM teardown

cfeck added inline comments. INLINE COMMENTS > kcm.cpp:103 > m_quickView->rootContext()->setContextProperty("_borderSizesIndex", 3); > // 3 is normal > -m_quickView->rootContext()->setContextProperty("configurationModule", > this); > +

[Differential] [Commented On] D4533: Avoid a crash on Kwin decoration KCM teardown

cfeck added a comment. Be my hero! +1 REVISION DETAIL https://phabricator.kde.org/D4533 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 18:44:38 + Build duration: 7 min 56 sec CHANGE SET Revision

[Differential] [Closed] D4491: Let make taskmanager tooltip readable again

anthonyfieroni closed this revision. anthonyfieroni added a comment. https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9=4c7022b936da587aa081cddbd419e32597718954 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES

[Differential] [Closed] D4518: Ungrab mouse in taskmanager context menu

anthonyfieroni closed this revision. anthonyfieroni added a comment. https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9=5eb79cf68eb7883da4a4b8d132b70f032157d802 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4518 EMAIL PREFERENCES

[Differential] [Accepted] D4534: [Folder View] Don't show script execution prompt on desktop:/

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Oh I see. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4534 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4534: [Folder View] Don't show script execution prompt on desktop:/

broulik added a comment. The "untrusted non-executable desktop file" and "script execution prompt" are completely orthogonal (for some reason). With this patch I still get the security warning: - non-executable .desktop file on some random location: → "would you like to run or open

[Differential] [Commented On] D4534: [Folder View] Don't show script execution prompt on desktop:/

dfaure added a comment. The code that creates the application shortcuts that you mention, should make them executable. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4534 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Requested Changes To] D4534: [Folder View] Don't show script execution prompt on desktop:/

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This reintroduces the security bug that this whole thing was about in the first place. Download some file from the internet, save on desktop, click on it - boom. The Unix

[Differential] [Accepted] D4534: [Folder View] Don't show script execution prompt on desktop:/

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4534 EMAIL PREFERENCES

[Differential] [Updated, 6 lines] D4534: [Folder View] Don't show script execution prompt on desktop:/

broulik updated this revision to Diff 11130. broulik added a comment. - Check for the location of the URL we're trying to run instead of the main folder view url (indirectly through parseDesktopFile), this way when opening a subfolder in desktop:/ through cascading it will again ask for

[Differential] [Request, 40 lines] D4535: Fix crash in Screen Locker KCM on teardown

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As described in https://bugreports.qt.io/browse/QTBUG-57714 exposing a QWidget as a context

[Differential] [Request, 4 lines] D4534: [Folder View] Don't show script execution prompt on desktop:/

broulik created this revision. broulik added reviewers: Plasma, hein, fvogt, dfaure. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This utterly breaks

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 738 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/738/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 17:28:13 + Build duration: 13 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 59 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/59/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 17:28:12 + Build duration: 6 min 14 sec CHANGE SET Revision

[Differential] [Request, 33 lines] D4533: Avoid a crash on Kwin decoration KCM teardown

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As described in https://bugreports.qt.io/browse/QTBUG-57714 exposing a QWidget as a context

[Differential] [Request, 2 lines] D4532: fix discover desktopid in favorties

sitter created this revision. sitter added reviewers: hein, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4532 AFFECTED FILES

[Differential] [Request, 2 lines] D4531: add discover to the system application tab in kickoff

sitter created this revision. sitter added reviewers: hein, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4531 AFFECTED FILES

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 737 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/737/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 16:09:46 + Build duration: 13 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 606 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/606/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 16:06:31 + Build duration: 5 min 34 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 736 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/736/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 15:54:31 + Build duration: 14 min CHANGE SET Revision

[Differential] [Closed] D4523: [Containment Configuration] Hide containment type drop-down if there's only one containment to choose from

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f94e31e08ab2: [Containment Configuration] Hide containment type drop-down if there's only one… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4528: Fix wallpaper configuration for plasma mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1750080bdd95: Fix wallpaper configuration for plasma mobile (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4528?vs=6=11120

[Differential] [Accepted] D4528: Fix wallpaper configuration for plasma mobile

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH fix-wp-config-mobile REVISION DETAIL https://phabricator.kde.org/D4528 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah,

[Differential] [Request, 32 lines] D4530: WIP: Don't re-show auto-hidden client on geometry change if they're still at a screen edge

broulik created this revision. broulik added reviewers: Plasma, KWin. broulik set the repository for this revision to R131 Plasma Wallpapers. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When you have an applet whose

[Differential] [Closed] D4529: Port image wallpaper code to use qCDebug

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d6aad9eb7104: Port image wallpaper code to use qCDebug (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4529?vs=7=8 REVISION

[Differential] [Accepted] D4529: Port image wallpaper code to use qCDebug

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH imagewallpaper/qcdebug REVISION DETAIL https://phabricator.kde.org/D4529 EMAIL PREFERENCES

[Differential] [Request, 44 lines] D4529: Port image wallpaper code to use qCDebug

bshah created this revision. bshah added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY And remove some useless debug statements as well TEST PLAN no more useless debug statment REPOSITORY R120

[Differential] [Request, 5 lines] D4528: Fix wallpaper configuration for plasma mobile

bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY https://phabricator.kde.org/R120:f6ce91499a16cd9e8fa4b56fdadf254e3ab79bd1 replace the height/width

[Differential] [Closed] D4521: Activate minimise all plasmoid on mouse enter if the user is dragging mimedata

This revision was automatically updated to reflect the committed changes. Closed by commit R114:5fb9a2585d9f: Activate minimise all plasmoid on mouse enter if the user is dragging mimedata (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 14:43:03 + Build duration: 17 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 735 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/735/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 14:44:18 + Build duration: 5 min 44 sec CHANGE SET Revision

[Differential] [Updated] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni added a comment. This is needed 1. Enable highlight windows 2. Hover group item 3. Left click on effect is stopped 4. Move mouse over window list 5. Ugly highlight window effect So add a guard if (m_taskManagerItem) {

[Differential] [Request, 8 lines] D4526: Lazy QUrl::fromUserInput in web browser

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So typing bbc.co.uk loads http://bbc.co.uk not just appending /bbc.co.uk as a relative

[Differential] [Closed] D4524: rename wireless power saving to wireless

This revision was automatically updated to reflect the committed changes. Closed by commit R122:f211aabfaf24: rename wireless power saving to wireless (authored by sebas). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4524?vs=0=2 REVISION DETAIL

[Differential] [Request, 2 lines] D4525: Fix crash when invoking Present Windows with the group dialog open.

hein created this revision. hein added reviewers: Plasma, anthonyfieroni. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This fixes a regression from https://phabricator.kde.org/R119:aeec4ae8869b487fe516a920b49a1fde4ea48c06 which unsets

[Differential] [Accepted] D4523: [Containment Configuration] Hide containment type drop-down if there's only one containment to choose from

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Powerdevil] [Bug 376037] Plasma ignores screen lid action settings

https://bugs.kde.org/show_bug.cgi?id=376037 Christoph Feck changed: What|Removed |Added Assignee|k...@davidedmundson.co.uk|plasma-devel@kde.org Target

[Differential] [Accepted] D4524: rename wireless power saving to wireless

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R122 Powerdevil BRANCH sebas/wps REVISION DETAIL https://phabricator.kde.org/D4524 EMAIL PREFERENCES

[Differential] [Accepted] D4524: rename wireless power saving to wireless

broulik accepted this revision. broulik added a reviewer: broulik. REPOSITORY R122 Powerdevil BRANCH sebas/wps REVISION DETAIL https://phabricator.kde.org/D4524 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma, davidedmundson, broulik

[Differential] [Updated] D4524: rename wireless power saving to wireless

sebas updated the summary for this revision. sebas updated the test plan for this revision. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4524 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: plasma-devel,

[Differential] [Request, 2 lines] D4524: rename wireless power saving to wireless

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This option is too easily confused with Wireless power saving of 801.11x adapters, where you can turn the

[Differential] [Request, 1 line] D4523: [Containment Configuration] Hide containment type drop-down if there's only one containment to choose from

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN I still get the ComboBox but I dont get it if

[Differential] [Accepted] D4518: Ungrab mouse in taskmanager context menu

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4518 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, davidedmundson, broulik, hein

[Differential] [Accepted] D4521: Activate minimise all plasmoid on mouse enter if the user is dragging mimedata

anthonyfieroni accepted this revision. anthonyfieroni added a reviewer: anthonyfieroni. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4521 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 57 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 10:05:43 + Build duration: 25 min CHANGE SET Revision

[Differential] [Request, 12 lines] D4521: Activate minimise all plasmoid on mouse enter if the user is dragging mimedata

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows the user to easily drag a file from dolphin into a folderview on a desktop even

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 605 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/605/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 10:07:58 + Build duration: 5 min 42 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 57 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 09 Feb 2017 09:58:28 + Build duration: 9 min 26 sec CHANGE SET Revision

[Differential] [Closed] D4520: [Task Manager] Don't import QtQuick 2.7

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5bbedd2c9f61: [Task Manager] Don't import QtQuick 2.7 (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4520?vs=11101=11103#toc REPOSITORY R119 Plasma Desktop CHANGES

[Differential] [Closed] D4519: [Digital Clock] Don't import QtQuick 2.7

broulik closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4519 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, subdiff, #plasma, bshah Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Request, 6 lines] D4520: [Task Manager] Don't import QtQuick 2.7

broulik created this revision. broulik added reviewers: Plasma, subdiff. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We don't make use of any new

[Differential] [Updated, 2 lines] D4518: Ungrab mouse in taskmanager context menu

anthonyfieroni set the repository for this revision to R119 Plasma Desktop. anthonyfieroni updated this revision to Diff 11102. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4518?vs=11100=11102 REVISION DETAIL https://phabricator.kde.org/D4518

[Differential] [Updated, 2 lines] D4518: Ungrab mouse in taskmanager context menu

anthonyfieroni removed R119 Plasma Desktop as the repository for this revision. anthonyfieroni updated this revision to Diff 11100. anthonyfieroni added a comment. Remove call to ungrabMouse in show() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4518?vs=11097=11100 REVISION

[Differential] [Accepted] D4519: [Digital Clock] Don't import QtQuick 2.7

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4519 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Request, 2 lines] D4519: [Digital Clock] Don't import QtQuick 2.7

broulik created this revision. broulik added reviewers: Plasma, subdiff. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We don't make use of any new

[Differential] [Commented On] D4508: [WIP] Plasma controls based on QtQuickControls2

davidedmundson added a comment. I want to do another full review next week when I'm home; but I'd be happy with doing that after we merge it, as it'll only be small things, and nothing which will affect API. In general it all looks very good, I like that you split out ButtonShadow and

[Differential] [Updated] D4518: Ungrab mouse in taskmanager context menu

hein added a comment. Then maybe you can remove the call in show() ...? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4518 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, davidedmundson, broulik, hein

[Differential] [Accepted] D4491: Let make taskmanager tooltip readable again

hein accepted this revision. hein added a reviewer: hein. hein added a comment. This revision is now accepted and ready to land. Kai is correct here, we always want to (a) be consistent, (b) push flaws up into lib code so they can be addressed centrally. REPOSITORY R119 Plasma Desktop