[Powerdevil] [Bug 376601] "Leave" overlay does not respect Polkit rule

2017-02-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376601 patrickrif...@yandex.com changed: What|Removed |Added Summary|Plasma 5 "Leave" overlay|"Leave" overlay does not

[Powerdevil] [Bug 376601] New: Plasma 5 "Leave" overlay does not respect Polkit rule

2017-02-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=376601 Bug ID: 376601 Summary: Plasma 5 "Leave" overlay does not respect Polkit rule Product: Powerdevil Version: unspecified Platform: Archlinux Packages OS: Linux Status:

[Differential] [Closed] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-17 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R105:408c284f6a35: Fix git ssh password detection (authored by cfeck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4540?vs=11428=11475#toc REPOSITORY R105 KDE SSH Password Dialog CHANGES

[Differential] [Closed] D4653: Make the ItemViewHeader more similar to Discover's Header design

2017-02-17 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R169:4f25212d8342: Make the ItemViewHeader more similar to Discover's Header design (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4653?vs=11463=11472#toc REPOSITORY R169

[Differential] [Accepted] D4653: Make the ItemViewHeader more similar to Discover's Header design

2017-02-17 Thread Marco Martin
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ItemViewHeader.qml:66 > +id: rect > +color: page.isCurrentPage ? Kirigami.Theme.linkColor : > Kirigami.Theme.disabledTextColor > +

[Differential] [Closed] D4649: add a preview for the disk quota plasmoid

2017-02-17 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R266:27b145b15509: add a preview for the disk quota plasmoid (authored by mart). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4649?vs=11452=11468 REVISION

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 75 - Still Unstable!

2017-02-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/75/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Feb 2017 18:31:54 + Build duration: 19 min CHANGE SET Revision

[Differential] [Closed] D4654: Port to QMultiHash.

2017-02-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:5632f4c38943: Port to QMultiHash. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4654?vs=11466=11467 REVISION DETAIL

[Differential] [Accepted] D4654: Port to QMultiHash.

2017-02-17 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. If all cases of insert(key,value) are validated to behave correctly (same as insertMulti now!), this looks good to me. Easier to understand and fewer code lines! REPOSITORY R120

[Differential] [Request, 27 lines] D4654: Port to QMultiHash.

2017-02-17 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, fvogt, graesslin. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4654 AFFECTED FILES

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 74 - Still Unstable!

2017-02-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/74/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Feb 2017 18:05:13 + Build duration: 8 min 53 sec CHANGE SET Revision

[Differential] [Closed] D4652: Only remove + announce if leader change actually occured; exit loop early.

2017-02-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ee9f966dd55c: Only remove + announce if leader change actually occured, avoid excessive loop. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D4652: Only remove + announce if leader change actually occured; exit loop early.

2017-02-17 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4652 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin,

[Differential] [Updated, 19 lines] D4652: Only remove + announce if leader change actually occured; exit loop early.

2017-02-17 Thread Eike Hein
hein updated this revision to Diff 11464. hein added a comment. Use QMutableHashIterator::findNext; simplify code. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4652?vs=11462=11464 BRANCH Plasma/5.8 REVISION DETAIL

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 73 - Still Unstable!

2017-02-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/73/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Feb 2017 17:32:41 + Build duration: 20 min CHANGE SET Revision

[Differential] [Request, 49 lines] D4653: Make the ItemViewHeader more similar to Discover's Header design

2017-02-17 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way we make sure it's being used and we possibly ensure some uniformity on applications

[Differential] [Commented On] D4652: Only remove + announce if leader change actually occured; exit loop early.

2017-02-17 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > xwindowtasksmodel.cpp:311 > +const WId leader = info.transientFor(); > +WId oldLeader = 0; > QMutableHashIterator i(transientsDemandingAttention); XCB_WINDOW_NONE REPOSITORY R120 Plasma

[Differential] [Request, 10 lines] D4652: Only remove + announce if leader change actually occured; exit loop early.

2017-02-17 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, graesslin. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4652 AFFECTED FILES

[Differential] [Closed] D4651: Fix crash.

2017-02-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b82d364536fa: Fix crash. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4651?vs=11458=11460 REVISION DETAIL

[Differential] [Accepted] D4651: Fix crash.

2017-02-17 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4651 EMAIL PREFERENCES

[Differential] [Closed] D4650: [greeter] Clear clipboard on show

2017-02-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:cae1e82fc94f: [greeter] Clear clipboard on show (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4650?vs=11454=11459 REVISION DETAIL

[Differential] [Accepted] D4649: add a preview for the disk quota plasmoid

2017-02-17 Thread Andreas Kainz
andreaska accepted this revision. andreaska added a reviewer: andreaska. andreaska added a comment. This revision is now accepted and ready to land. thanks look good. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4649 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D4651: Fix crash.

2017-02-17 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY i.remove() makes i.key() crash. Duh. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL

[Differential] [Closed] D4568: cmake: Use ${KF5_MIN_VERSION} to search for prison

2017-02-17 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ab9c3bc68edf: cmake: Use ${KF5_MIN_VERSION} to search for prison (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D4568: cmake: Use ${KF5_MIN_VERSION} to search for prison

2017-02-17 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4568 EMAIL PREFERENCES

[Differential] [Accepted] D4650: [greeter] Clear clipboard on show

2017-02-17 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH greeter-clear-clipboard REVISION DETAIL https://phabricator.kde.org/D4650 EMAIL PREFERENCES

[Differential] [Commented On] D4650: [greeter] Clear clipboard on show

2017-02-17 Thread Kai Uwe Broulik
broulik added a comment. Works fine on X. So when I lock the screen and unlock again, my copied stuff will be gone… but then, if I lock the screen I'm probably away for an extended period of time anways. +1 REPOSITORY R133 KScreenLocker REVISION DETAIL

[Differential] [Request, 2 lines] D4650: [greeter] Clear clipboard on show

2017-02-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As we have a feature to show the password it would be possible for an unauthorized user to get access

[Differential] [Commented On] D4573: [kioslave/remote] Fix broken kded module

2017-02-17 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4573 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated] D4649: add a preview for the disk quota plasmoid

2017-02-17 Thread Marco Martin
mart added reviewers: VDG, andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4649 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #vdg, andreask Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed,

[Differential] [Request, 238 lines] D4649: add a preview for the disk quota plasmoid

2017-02-17 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY disk quota plasmoid is in the default set in kdeplasma-addons, should have a preview

[Differential] [Commented On] D4648: try harder to make the selected wallpaper visible

2017-02-17 Thread Eike Hein
hein added a comment. I've used multiple techniques to do similar "do stuff when positioning is complete". One is using PropertyChange in populate transitions to change a prop when populate is done. I think Qt 5.9 will actually have an onPositioningComplete (at least for Flow).

[Differential] [Accepted] D4640: Fix array allocation for non-continuous cpu numbers

2017-02-17 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D4640 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cfeck, #plasma, mart

[Differential] [Request, 3 lines] D4648: try harder to make the selected wallpaper visible

2017-02-17 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY qml gridview don't have an official way to ensure the current index is visible when the view is first

[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-17 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in baloofilepropertiesplugin.desktop:8 > where does this list come from? I went through all extractors in KFileMetaData and looked at what they support. Unfortunately KPropertiesDialog does not support wildcards. But then,

[Differential] [Closed] D4635: ItemViewHeader

2017-02-17 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R169:10c784afc8fd: ItemViewHeader (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4635?vs=11414=11449 REVISION DETAIL

[Differential] [Closed] D4644: Find minimum required Breeze version instead of current version

2017-02-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:cb481b492271: Find minimum required Breeze version instead of current version (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

Can't create an Activity via Scripting Console with plugin=org.kde.plasma.folder (aka folderview)

2017-02-17 Thread Bernard Gray
Hi all, I tried a question on #plasma but was recommended to try here due to timezone disconnect. I'm trying to build a custom plasma init script for my kde environment and I'm having a few issues. Namely, I want to create a default Activity with plugin = org.kde.plasma.folder" (aka folderview)

[Differential] [Accepted] D4644: Find minimum required Breeze version instead of current version

2017-02-17 Thread Bhushan Shah
bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R108 KWin BRANCH breeze-find-minimum-version REVISION DETAIL https://phabricator.kde.org/D4644 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 72 - Still Unstable!

2017-02-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Feb 2017 09:38:30 + Build duration: 24 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 75 - Still Unstable!

2017-02-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/75/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Feb 2017 09:32:10 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 624 - Still Unstable!

2017-02-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/624/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Feb 2017 09:33:25 + Build duration: 6 min 31 sec CHANGE SET Revision

[Differential] [Closed] D4632: [Notifications] Never manually hide() the NotificationPopup

2017-02-17 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6b833f1ca2bd: [Notifications] Never manually hide() the NotificationPopup (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4636: cmake: Actually search for KF >= 5.17.0

2017-02-17 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R845:4030ba24a69a: cmake: Actually search for KF >= 5.17.0 (authored by heikobecker). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4636?vs=11415=11437 REVISION