[Differential] [Request, 4 lines] D4853: Find correct version of kirigami

arojas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY look and feel explorer was ported to kirigami2 in https://phabricator.kde.org/R118:db66899283cf5dcbe133ee8786b7665361182955, make cmake search

Project: Better touch screen support in the Plasma workspace

Hello, I came across the Touch screen support Idea for KDEsoc and I am interested in contributing for the same. How should I go about for the same. I have basic knowledge of Qt and experienced in C++. Moreover I have been using plasma,KDE for quite some time now. Thanks.

[Powerdevil] [Bug 377046] New: smooth brightness switch

https://bugs.kde.org/show_bug.cgi?id=377046 Bug ID: 377046 Summary: smooth brightness switch Product: Powerdevil Version: 5.9.3 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Prio

[Differential] [Request, 22 lines] D4851: Implement FadingMaterial frag/vert shaders on core profile

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Like all the inbuilt shaders this now has a separate GLS source file which works with a newer version without re

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/ --- (Updated March 1, 2017, 2:33 a.m.) Status -- This change has been di

[Differential] [Updated] D4803: Basic keyboard support + fixes to QuickShare plasmoid

apol added a comment. The rest is fine, please fix this. INLINE COMMENTS > yuenlim wrote in AlternativesView.qml:101 > after discussion, should avoid using Plasma-specific components here (in > purpose) for now. To use Rectangle without custom radius instead. That doesn't make sense, this i

[Differential] [Updated, 56 lines] D4831: Add new component for the greyed out labels in Item Delegates.

davidedmundson updated this revision to Diff 11981. davidedmundson added a comment. Add @inherits REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4831?vs=11923&id=11981 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4831

[Differential] [Commented On] D4831: Add new component for the greyed out labels in Item Delegates.

davidedmundson added a comment. I'm going to merge after Marco merges the QQC2 stuff that way we can inherit directly from the newest label without having to worry about versioning this. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4831 EMAIL P

[Differential] [Request, 60 lines] D4848: Split frag and vert code of FadingNode into separate files

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This matches what Qt does internally, it's easier to read and gives us syntax highlighting on the shader files,

Re: [KDE4] what component does the screenlocking?

In data martedì 28 febbraio 2017 23:16:42 CET, René J.V. Bertin ha scritto: > 3) suppose something like this happens on a Plasma5 desktop, what backdoors > are there to unlock the session without killing it, from a virtual console? With the exception of "loginctl unlock-sessions" as root or "logi

Re: [KDE4] what component does the screenlocking?

Please allow me a few follow-up questions Given that apparently the KDE4 screensaving/locking mechanism is too old to work correctly with whatever component is now too new: 1) can I prevent locking entirely, including at suspend/wake? I thought I'd seen an option that controls this in systemset

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

https://bugs.kde.org/show_bug.cgi?id=349750 --- Comment #9 from Michael N --- Created attachment 104278 --> https://bugs.kde.org/attachment.cgi?id=104278&action=edit journal log showing list closed and open events with no suspension -- You are receiving this mail because: You are the assignee

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

https://bugs.kde.org/show_bug.cgi?id=349750 Michael N changed: What|Removed |Added CC||michael_nu...@hotmail.com --- Comment #8 from Micha

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

ivan added a comment. There are a few problems regarding the 'drop' placeholder needed for the Dashboard: - The placeholder is handled by the model which is a bit hackish, but this can mostly work for the new model as well by using the same offset-items-by-one trick used in the original

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

davidedmundson added a comment. @zren did you get that original problem in plasmashell as well as plasmoidviewer? The description doesn't make much sense because Plasmashell disables Qt's high DPI stuff. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added a comment. That's a good idea @broulik . Slider height for the Desktop themes I have installed (I used this script ): - air: 20px - Arctica: 24px - Arezzo: 24px - arquetype-dark: 24px - Bise: 24px - b

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. And if it's not an "Open" button? The action is provided by the application itself, after all. It might not add it (I actually want to get rid of it as we now have the preview area) or have it do something different than it does now. There could also be multiple. RE

[Differential] [Updated] D4845: Fix context menu button's icon size when on default DPI

broulik added a comment. What about making ToolButton's icon size a minimum of small icon size no matter what? I don't see a case where you ever want to have it smaller. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 EMAIL PREFERENCES http

Re: [KDE4] what component does the screenlocking?

Am 2017-02-28 19:47, schrieb René J.V. Bertin: On Tuesday February 28 2017 18:35:59 Martin Gräßlin wrote: Erm you count translations as commits? If not then trust the maintainer Please, I can read: commit 46f1055ffdcd2e068296576a7824012f42e9b9a8 Author: Wolfgang Bauer Date: Tue Aug 4 19:5

Re: [KDE4] what component does the screenlocking?

On Tuesday February 28 2017 18:35:59 Martin Gräßlin wrote: > Erm you count translations as commits? If not then trust the maintainer Please, I can read: > commit 46f1055ffdcd2e068296576a7824012f42e9b9a8 > Author: Wolfgang Bauer > Date: Tue Aug 4 19:51:05 2015 +0200 > > Fix input focus fo

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 87 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/87/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 17:37:24 + Build duration: 21 min CHANGE SET Revision b6d088d9e6e7239d503cfc9e

[Differential] [Updated] D4845: Fix context menu button's icon size when on default DPI

Zren marked 3 inline comments as done. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, subdiff, drosca, broulik Cc: plasma-devel, progwolff, lesliezhai, al

[Differential] [Updated, 10 lines] D4845: Fix context menu button's icon size when on default DPI

Zren updated this revision to Diff 11969. Zren added a comment. Remove `|| !parent.flat` REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4845?vs=11964&id=11969 REVISION DETAIL https://phabricator.kde.org/D4845 AFFECTED FILES applet/c

[Differential] [Accepted] D4845: Fix context menu button's icon size when on default DPI

subdiff accepted this revision. subdiff added a comment. This revision is now accepted and ready to land. Tested it and works well. You can omit the `!parent.flat` condition as @drosca said, since it's always false. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabr

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added inline comments. INLINE COMMENTS > Zren wrote in ListItemBase.qml:122 > Not really. Just wanted to have consistent code with ToolButtonStyle, but I > already had to change `control` => `parent` so might as well remove it. > ToolButton is basically a `flat: true` Button so that part w

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

Zren added inline comments. INLINE COMMENTS > drosca wrote in ListItemBase.qml:122 > Do we really need this (we certainly don't need the `parent.flat` part)? It > doesn't seem to change the icon at all. Not really. Just wanted to have consistent code with ToolButtonStyle, but I already had to

[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

drosca added inline comments. INLINE COMMENTS > ListItemBase.qml:122 > +active: parent.hovered > +colorGroup: parent.hovered || !parent.flat ? > PlasmaCore.Theme.ButtonColorGroup : PlasmaCore.ColorScope.colorGroup > +

[Differential] [Updated, 33 lines] D4830: Adjust plasma-desktop to the new fallback prefixes

davidedmundson updated this revision to Diff 11967. davidedmundson added a comment. Proper handling of TaskProgressOverlay REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4830?vs=11958&id=11967 BRANCH master REVISION DETAIL https://phabricator.k

[Differential] [Updated] D4845: Fix context menu button's icon size when on default DPI

Zren edited the summary of this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, subdiff, drosca, broulik Cc: plasma-devel, progwolff, lesliezhai,

[Differential] [Request, 10 lines] D4845: Fix context menu button's icon size when on default DPI

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ToolButton pads the contexts of the label+icon based on the desktop theme's svg margins. Causing the icon to only be 12px, which is scaled down a

[Differential] [Updated] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

yuenlim marked an inline comment as done. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D4805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: yuenlim, #plasma, apol, mart Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-m

[Differential] [Closed] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

This revision was automatically updated to reflect the committed changes. Closed by commit R114:8bab9c84ab9a: Basic keyboard support in QuickShare Plasmoid Fix Quickshare Paste action not… (authored by Lim Yuen Hoe ). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4805?vs=11840&id=11966#

[Differential] [Closed] D4840: Preview Centered wallpaper as PreserveAspectFit

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b6d088d9e6e7: Preview Centered wallpaper as PreserveAspectFit (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4840?vs=11954&id

Re: [KDE4] what component does the screenlocking?

Am 2017-02-28 18:08, schrieb René J.V. Bertin: On Tuesday February 28 2017 16:48:25 Martin Gräßlin wrote: As you should be aware of: kde4 has been unmaintained for years and is EOL. Yeah, I know that KDE no longer maintains most of KDE4. why in the name of Konqui are you asking questions ab

Re: Plasma 5.9.3

On Tue, Feb 28, 2017 at 04:03:59PM +, Jonathan Riddell wrote: > Plasma 5.9.3 is now released > https://www.kde.org/announcements/plasma-5.9.3.php > > Tars are at a temporary location due to a server upgrade > > http://weegie.edinburghlinux.co.uk/~jr/tmp/stable/plasma/5.9.3/ Now moved over t

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#91004, @broulik wrote: > > Just as well or as badly as a regular "Open" button. If in this scenario you hide the Open button because it has no valid target, then of course there would be no split Open button, either. > > S

Re: [KDE4] what component does the screenlocking?

In data martedì 28 febbraio 2017 18:08:40 CET, René J.V. Bertin ha scritto: > Yeah, I know that KDE no longer maintains most of KDE4. Fortunately some > distributions have a slightly different take on concepts like continuity I would like if you stopped doing such blanket statements. Plasma 4 *wa

[Differential] [Updated, 7 lines] D4803: Basic keyboard support + fixes to QuickShare plasmoid

yuenlim updated this revision to Diff 11963. yuenlim marked an inline comment as done. yuenlim added a comment. Added onEnterPressed and removed Radius on Rectangle highligh as requested REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4803?vs=11839&i

[Differential] [Updated] D4803: Basic keyboard support + fixes to QuickShare plasmoid

yuenlim marked an inline comment as done. yuenlim added inline comments. INLINE COMMENTS > mart wrote in AlternativesView.qml:101 > this should be a PlasmaComponents.Highlight instead after discussion, should avoid using Plasma-specific components here (in purpose) for now. To use Rectangle wit

Re: [KDE4] what component does the screenlocking?

On Tuesday February 28 2017 16:48:25 Martin Gräßlin wrote: >As you should be aware of: kde4 has been unmaintained for years and is >EOL. Yeah, I know that KDE no longer maintains most of KDE4. Fortunately some distributions have a slightly different take on concepts like continuity and long-te

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#91009, @subdiff wrote: > I thought of something like this: F2668672: Screenshot_20170228_114914.png > Is this in line with the HIG? That's the idea we've discussed above and yes

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

subdiff added a comment. I thought of something like this: F2668672: Screenshot_20170228_114914.png Is this in line with the HIG? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabr

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 643 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/643/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 14:52:43 + Build duration: 30 min CHANGE SET Revision 26b92df48a6a61acbe1a649167e9f03b159a

[Differential] [Abandoned] D4838: [Notifications] Add context menu for thumbnail

broulik abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #vdg Cc: subdiff, colomar, plasma-devel, progwolff, lesliezhai, ali-moha

[Differential] [Accepted] D4508: Plasma controls based on QtQuickControls2

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4508 REVISION DETAIL https://phabricator.kde.org/D4508 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 86 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 15:13:53 + Build duration: 5 min 37 sec CHANGE SET Revision 9343bc2bb835374997

Re: Merging strings

It would be nice if we had examples of these strings in Hungarian - if the only 'problem' is that an empty string looks strange, then we don't have a problem - it does not look strange as far as I'm concerned. If the problem is bigger, then putting everything into the spinbox might work, although

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. > Just as well or as badly as a regular "Open" button. If in this scenario you hide the Open button because it has no valid target, then of course there would be no split Open button, either. So, how can I access the menu options for the invidiaual files, here?

[Differential] [Updated] D4843: PulseObject: Also use "media.icon_name" for icon

drosca retitled this revision from "PulseObject: Also use "device.icon_name" for icon" to "PulseObject: Also use "media.icon_name" for icon". REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4843 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Request, 5 lines] D4843: PulseObject: Also use "device.icon_name" for icon

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Opened mpv from konsole which for some reason had application.icon_name="kded5" + media.icon_name="mpv" and it correctly shows mpv icon now REPOSITO

Plasma 5.9.3

Plasma 5.9.3 is now released https://www.kde.org/announcements/plasma-5.9.3.php Tars are at a temporary location due to a server upgrade http://weegie.edinburghlinux.co.uk/~jr/tmp/stable/plasma/5.9.3/ Jonathan

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#90994, @broulik wrote: > > A file manager has a menu bar, however, so the context menu is never the only means to execute an action. > > Dolphin does not by default. I don't see an "Open" or "Open With" action anywhere in

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in Label.qml:27 > It probably made sense when it was written, but your comments about layouts > is outdated. > > No manual changes are needed. > > try: > https://paste.kde.org/pgi2ui6e3 > > If it was a problem we'd be seeing i

Re: [KDE4] what component does the screenlocking?

Am 2017-02-28 10:20, schrieb René J.V. Bertin: What component(s) might be involved? Who's responsible for the screensaver and screen/session locking? Is there a way to get an on-screen keyboard in the session unlock screen? As you should be aware of: kde4 has been unmaintained for years and is

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. > A file manager has a menu bar, however, so the context menu is never the only means to execute an action. Dolphin does not by default. I don't see an "Open" or "Open With" action anywhere in its menus, neither the file actions (compress, activities, send to, e

[Differential] [Updated, 2,977 lines] D4508: Plasma controls based on QtQuickControls2

mart updated this revision to Diff 11960. mart added a comment. - remove custom height REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11948&id=11960 BRANCH arcpatch-D4508 REVISION DETAIL https://phabricator.kde.org/D4508 AF

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. > You don't have that in a file manager, either, and this thing represents a file. A file manager has a menu bar, however, so the context menu is never the only means to execute an action. I don't see how turning the Open button into a split button would "te

[Differential] [Accepted] D4840: Preview Centered wallpaper as PreserveAspectFit

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4840 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mar

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

broulik added a comment. Of course I meant the code in panel containment, but here it does expanded = false and that's what I wanted to listen to :) Plasmoid.onUserConfiguringChanged: { ... if (plasmoid.userConfiguring) { for (var i = 0; i < plasmoid.

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

mart added a comment. i don't think the panel controller does that, but would be easy to do so? (in the panel containment, when isuserconfiguring proeprty changes) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4842 EMAIL PREFERENCES https://phabricator.

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

broulik added a comment. Hold on, I didn't properly test this. It closes because of the controller window gaining focus, my idea was to also have it close when the pin is checked which this patch doesn't fix. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D

[Differential] [Request, 6 lines] D4842: [System Tray] Listen to external collapse

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When plasmoid.expanded = false is done, hide the popup. This is done by the panelcontroller to ensure we don't manipulate the panel with ope

[kio-extras] [Bug 376577] filenamesearch crashes when started from root folder

https://bugs.kde.org/show_bug.cgi?id=376577 --- Comment #8 from Alex --- Created attachment 104275 --> https://bugs.kde.org/attachment.cgi?id=104275&action=edit from console: KDE_SLABE_DEBUG_WAIT=dolphin kdeinit5 -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Commented On] D4830: Adjust plasma-desktop to the new fallback prefixes

broulik added inline comments. INLINE COMMENTS > TaskProgressOverlay.qml:46 > imagePath: "widgets/tasks" > -prefix: calculatePrefix() > -onRepaintNeeded: prefix = calculatePrefix() > - > -function calculatePrefix() { > -var prefix =

[Differential] [Updated] D4830: Adjust plasma-desktop to the new fallback prefixes

davidedmundson marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: broulik, plasma-devel, progwolff, lesliezhai, al

[Differential] [Updated, 33 lines] D4830: Adjust plasma-desktop to the new fallback prefixes

davidedmundson updated this revision to Diff 11958. davidedmundson added a comment. Fixed a stupid mistake REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4830?vs=11911&id=11958 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4830 AF

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 85 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 14:08:38 + Build duration: 5 min 37 sec CHANGE SET Revision ac097d487c58b8ca9b9e

[Differential] [Closed] D4833: Only activate kded Appmenu signals if menus are in the window decoration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:907296e8d30b: Only activate kded Appmenu signals if menus are in the window decoration (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Closed] D4832: Open the correct submenu in kwin menu when activating the Appmenu with a shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9343bc2bb835: Open the correct submenu in kwin menu when activating the Appmenu with a… (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

Jenkins-kde-ci: khotkeys Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 15 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 13:11:03 + Build duration: 8 min 13 sec CHANGE SET Revision 85d764e71e2201f70c0734109cf

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 642 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/642/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 13:07:14 + Build duration: 6 min 2 sec CHANGE SET Revision 04c922dac118f0c58d361f547511b48

[Differential] [Commented On] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

hein added a comment. Thanks, landed! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, davidedmundson, hein, broulik Cc: plasma-devel, progwolff, lesliezhai, ali

[Differential] [Changed Subscribers] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

broulik added inline comments. INLINE COMMENTS > ShareDialog.qml:54 > onClicked: view.createJob(index) > +Keys.onReturnPressed: view.createJob(index) > +Keys.onEscapePressed: window.hide() You should also do `Keys.onEnterPressed` (the Enter key on

[Differential] [Closed] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

This revision was automatically updated to reflect the committed changes. Closed by commit R119:26b92df48a6a: Task Manager: Make the icon size configurable for task buttons in a vertical… (authored by ppalaga, committed by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE http

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 85 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 12:35:16 + Build duration: 6 min 49 sec CHANGE SET Revision b4bba180bd0f84fd84

Jenkins-kde-ci: plasma-tests Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 6 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-tests%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 12:34:56 + Build duration: 59 sec CHANGE SET Revision 9d9813418092a1bfe6ab4fe869f1f

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 84 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 12:33:40 + Build duration: 6 min 8 sec CHANGE SET Revision c557ba5390b296072c7e4

[Differential] [Request, 2 lines] D4840: Preview Centered wallpaper as PreserveAspectFit

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently the we create previews with QPixmapItem from KDeclrarative and when a wallpaper is set to centered sets it to an enum value

[Differential] [Updated, 77 lines] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

ppalaga updated this revision to Diff 11952. ppalaga added a comment. > One more request, would you mind rebasing it against current master? (Doesn't apply cleanly currently.) I rebased and updated the diff, but I had no to time to run the rebased code. I hope that you or somebody else w

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in Label.qml:27 > the reason for the padding is that it makes it correctly vertically aligned > with other widgets both in a Row and a RowLayout. > without this default height, every label should be manually vertically > centere

[Differential] [Accepted] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D4805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: yuenlim, #plasma, apol, mart Cc: plasma-devel, p

[Differential] [Requested Changes] D4803: Basic keyboard support + fixes to QuickShare plasmoid

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. almost there INLINE COMMENTS > AlternativesView.qml:101 > delegate: stack.delegate > +highlight: Rectangle { > +radius: 5 this should be a Pl

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 641 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/641/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 11:59:41 + Build duration: 6 min 3 sec CHANGE SET Revision 4166bac3776cd1b92f39131cb7ce190

[Differential] [Commented On] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

hein added a comment. One more request, would you mind rebasing it against current master? (Doesn't apply cleanly currently.) REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, davidedmundson, hei

[Differential] [Commented On] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

ppalaga added a comment. > Patch looks good. Thanks for the review and for the assistance! > Do you have a developer account to commit it or should I do it for you? Yes, please do it for me. REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabric

[Differential] [Closed] D4707: move setImagePath logic into updateFrameData()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:2b3e8dfe866a: move setImagePath logic into updateFrameData() (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4707?vs=11632&id=11949#toc REPOSITORY R242 Plasma Framework (L

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:42 > It's easier to add something later than to remove it. > > I'd go with not installing for now, then revisit it. Maybe same for Menus. ok. what about the combobox? > davidedmundson wrote in Button.qml:28 >

[Differential] [Updated, 2,978 lines] D4508: Plasma controls based on QtQuickControls2

mart updated this revision to Diff 11948. mart marked 2 inline comments as done. mart added a comment. - don't install files that shouldn't REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11630&id=11948 BRANCH arcpatch-D4508 RE

[Differential] [Accepted] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Patch looks good. Do you have a developer account to commit it or should I do it for you? REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/se

[Differential] [Accepted] D4707: move setImagePath logic into updateFrameData()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4707 REVISION DETAIL https://phabricator.kde.org/D4707 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D4739: make sure the cancel action is last

This revision was automatically updated to reflect the committed changes. mart marked an inline comment as done. Closed by commit R241:cae36e0efc65: make sure the cancel action is last (authored by mart). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4739?vs=1194

[Differential] [Accepted] D4739: make sure the cancel action is last

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D4739 REVISION DETAIL https://phabricator.kde.org/D4739 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #frameworks, dfa

[Differential] [Updated] D4739: make sure the cancel action is last

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > dfaure wrote in dropjob.h:38 > Not a good enough reason to have it in the public header (which doesn't use > it anywhere), you can move that fwd decl to the .cpp file. done REPOSITORY R241 KIO REVISION DETA

[Differential] [Updated, 104 lines] D4739: make sure the cancel action is last

mart updated this revision to Diff 11942. mart added a comment. remove dropmenu declaration from public header REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4739?vs=11682&id=11942 BRANCH arcpatch-D4739 REVISION DETAIL https://phabricator.kde.org/D4739 A

[Differential] [Commented On] D4707: move setImagePath logic into updateFrameData()

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvg.cpp:804 > I don't understand this and the FrameData part of this change. > > q->imagePath() will still always be correct as before, you still set that in > setImagePath() regardless of whether we are blocking updates

[Differential] [Commented On] D4739: make sure the cancel action is last

dfaure added inline comments. INLINE COMMENTS > mart wrote in dropjob.h:38 > used for class KIO::DropMenu : public QMenu in dropjob.cpp, > doesn't compile otherwise Not a good enough reason to have it in the public header (which doesn't use it anywhere), you can move that fwd decl to the .cpp f

[Differential] [Requested Review] D4821: Implement manual focus on click

fvogt requested review of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, broulik, #plasma, graesslin Cc: plasma-devel, progwolff, lesliezhai, ali-moham

[Differential] [Updated, 29 lines] D4821: Implement manual focus on click

fvogt updated this revision to Diff 11941. fvogt added a comment. Newly created windows do not steal focus anymore Needs a quick test that it does not break wayland (e.g. no focus at all) REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4821?vs=119

[Differential] [Updated] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. > which makes sense to me because not every user will know about the possibility to do a right click. You don't have that in a file manager, either, and this thing represents a file. Even more so if there's multiple files, they'll show up as square items. I know

[Differential] [Commented On] D4837: Applet: Make volume indicator icon bigger

drosca added inline comments. INLINE COMMENTS > subdiff wrote in ListItemBase.qml:123 > Ok, ship it. To still easily distinguish the two icons we could place the > sound lines on the left side of the microphone and not on the right side like > for the speaker. @andreask, could you take a look a

  1   2   >