D4806: [greeter] Send the auth result through the server instead return value

graesslin added a comment. ping REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4806 To: graesslin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4780: [kcheckpass] Drop the conv_legacy support

graesslin added a comment. ping REVISION DETAIL https://phabricator.kde.org/D4780 To: graesslin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4773: [kcheckpass] Drop the caller command line option

graesslin added a comment. ping REVISION DETAIL https://phabricator.kde.org/D4773 To: graesslin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4768: Require PAM by default and provide an option to not require it

graesslin added a comment. ping REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4768 To: graesslin, #plasma, erichameleers Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4759: [kcheckpass] Drop command line option for username

graesslin added a comment. ping REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4759 To: graesslin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4718: support for auto-hidden windows to resize

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Could you please extend autotests/integration/screenedge_client_show_test.cpp with a test case for your change? REPOSITORY R108 KWin REVISION DETAIL

Re: Review Request 129995: Fix KillRunner Memory leak

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129995/ --- (Updated March 8, 2017, 2:43 a.m.) Status -- This change has been

Re: Review Request 129995: Fix KillRunner Memory leak

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129995/ --- (Updated 三月 8, 2017, 10:42 a.m.) Review request for Plasma, Aleix Pol

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

> On 三月 7, 2017, 7:45 p.m., Kai Uwe Broulik wrote: > > applets/appmenu/lib/appmenuapplet.cpp, line 167 > > > > > > Prefer !ctx instead of comparing with nullptr > > > > Also, could you move the check up

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/ --- (Updated 三月 8, 2017, 10:17 a.m.) Review request for Plasma, Kai Uwe

D4972: Start drag with press and hold on touch events

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This patch consists of two changes: - starting drags on press and hold - not starting drags when the event

D4918: [Folder View] Increase delegate action size to smallMedium in icon mode

broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4918 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Powerdevil] [Bug 377357] New: configurable timer setting to turn off the keyboard's backlight

https://bugs.kde.org/show_bug.cgi?id=377357 Bug ID: 377357 Summary: configurable timer setting to turn off the keyboard's backlight Product: Powerdevil Version: unspecified Platform: Mint (Ubuntu based) OS:

D4070: Changes to global menu applet

ltoscano added inline comments. INLINE COMMENTS > main.qml:55 > +checked: checkable > +iconSource: appletEnabled ? i18n("application-menu") : > i18n("emblem-warning") > onClicked: { A bit late to the party, but if this is the freedesktop name of an icon, then it

D3805: Per-activity favorites (Final?)

hein added a comment. ‎IRC log of review session: [05:37] ‎<‎Sho_‎>‎ ivan|home: currently compiling fav patch ‎[05:38] ‎<‎Sho_‎>‎ ivan|home: i may have one request ‎[05:38] ‎<‎ivan|home‎>‎ shoot ‎[05:39] ‎<‎Sho_‎>‎ ivan|home: we might have to renege on renaming favmodel to

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 91 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/91/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 20:22:54 + Build duration: 28 min CHANGE SET Revision

Re: drawing on the X11 root window with Qt5

Kai Uwe Broulik wrote: > Note that KWIN doesn't render the X11 root window when compositing is enabled > so this would be of little use. ‎ Who says this is for use when KWin is active too? :) Even with KWin 5.9.3 running applications like xscreensaver somehow manage to make the root window

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 817 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/817/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 20:48:04 + Build duration: 1 min 29 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 817 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/817/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 20:48:04 + Build duration: 1 min 29 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 659 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/659/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 20:39:24 + Build duration: 5 min 47 sec CHANGE SET Revision

D4929: DrKonqi : lldb support

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. So, plasma-workspace is usually way out of my comfort zone, I'm commenting anyway since RJVB urged me to do it. See my notes. INLINE COMMENTS > backtracegenerator.cpp:62 > +

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 816 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/816/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 20:31:24 + Build duration: 3 min 21 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 658 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/658/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 20:23:44 + Build duration: 6 min 55 sec CHANGE SET Revision

D4969: open applet handles when the toolbox is open

davidedmundson added a comment. Tried it out, expecting to find it difficult to use, acutally quite liked it. Surprisingly simple too. One problem: - have multiscreen - click toolbox on left - drag widget from left screen to right - handles disappear mid drag Maybe we can

D4918: [Folder View] Increase delegate action size to smallMedium in icon mode

hein added a comment. After trying it I still don't like smallMedium for icon mode :(. Just seems too huge (also rather dislike the icons, and the press color clashes with the selected frame state ...). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4918

D4939: Get rid of KDELibs4Support

denisshienkov added inline comments. INLINE COMMENTS > denisshienkov wrote in activitypage.cpp:76 > > Why don't make QWeakPointer -> QPointer > > > > 1. Then, I suggest do not use QPointer at all, as it is overhead for this > case. I suggest to use the pointers directly.. > > > commit first

D4970: Get rid of QWeakPointer

denisshienkov added a reviewer: ltoscano. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, volkov, afiestas, ltoscano Cc: plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4970: Get rid of QWeakPointer

denisshienkov added a reviewer: afiestas. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, volkov, afiestas Cc: plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4970: Get rid of QWeakPointer

denisshienkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As it is overhead to use QWeakPointer and QPointer in this simple code. Also, now we delete the ErrorOverlay objects directly instead

D4970: Get rid of QWeakPointer

denisshienkov added a reviewer: volkov. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, volkov Cc: plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4969: open applet handles when the toolbox is open

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this makes a mini "edit mode" when the toolbox is open, opening all the applet handles. It is coherent with the panel and partly solves the

D4939: Get rid of KDELibs4Support

denisshienkov added inline comments. INLINE COMMENTS > volkov wrote in powerdevilcore.cpp:102 > Yes, powermanagement.{h, cpp} from kscreenlocker is what you need. > The question is whether to create a library from it? > The question is whether to create a library from it? I don't know. It is

Re: drawing on the X11 root window with Qt5

Note that KWIN doesn't render the X11 root window when compositing is enabled so this would be of little use. ‎ ‎

D4963: Add scaling support into BlurEffect::doBlur

fredrik added a comment. The blur shader is not designed to blur and scale simultaneously. The sampled offsets are computed so that the shader samples between pixels, and the kernel weights are the sums of the gaussian function for the interpolated pixel values at each offset. This

D4967: Make difference between download and installed size

jgrulich marked an inline comment as done. jgrulich added a comment. In https://phabricator.kde.org/D4967#93376, @apol wrote: > All in all, +1. > Would you be interested in implementing it for PackageKit? It's probably more interesting and complex there, as we need to compute the

D4967: Make difference between download and installed size

apol added a comment. All in all, +1. Would you be interested in implementing it for PackageKit? It's probably more interesting and complex there, as we need to compute the dependencies. INLINE COMMENTS > FlatpakResource.cpp:124 > > -int FlatpakResource::downloadSize() const > +int

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 657 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/657/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 15:00:32 + Build duration: 15 min CHANGE SET Revision

D4962: [Folder View] Open context menu when pressing Menu key

This revision was automatically updated to reflect the committed changes. Closed by commit R119:895f617f0887: [Folder View] Open context menu when pressing Menu key (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D4962: [Folder View] Open context menu when pressing Menu key

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4962 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4956: [Folder View] Lower toolbox when an item is hovered

broulik added a subscriber: graesslin. broulik added a comment. @graesslin The issue @rikmills described happens when there's a screen corner configured in KWin. Could this magic window with the glow interfere in hover handling in some way? REPOSITORY R119 Plasma Desktop REVISION DETAIL

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 89 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 13:40:13 + Build duration: 22 min CHANGE SET Revision

D4967: Make difference between download and installed size

jgrulich added a reviewer: apol. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D4967 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4967: Make difference between download and installed size

jgrulich created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently in discover we show app size, but we don't make difference between download size and installed size which can be different (e.g.

D4939: Get rid of KDELibs4Support

volkov added inline comments. INLINE COMMENTS > denisshienkov wrote in CMakeLists.txt:111 > Where I need to take an appropriate XML files then? Copy them here. > denisshienkov wrote in powerdevilcore.cpp:102 > > It seems to be more reasonable to request supported methods from powerdevil > >

D4955: [QDBusMenuBar] Connect to popupRequested signal

This revision was automatically updated to reflect the committed changes. Closed by commit R135:aef74e97e2ed: [QDBusMenuBar] Connect to popupRequested signal (authored by broulik). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D4925: actually delete old theme caches

This revision was automatically updated to reflect the committed changes. mart marked 2 inline comments as done. Closed by commit R242:bbcb217b4812: actually delete old theme caches (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 656 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/656/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 12:44:34 + Build duration: 6 min 45 sec CHANGE SET Revision

D4925: actually delete old theme caches

davidedmundson added inline comments. INLINE COMMENTS > theme_p.cpp:271 > +for (const QFileInfo : cacheDir.entryInfoList()) { > +if (!file.absoluteFilePath().endsWith(svgElementsFileName)) { > +QFile::remove(file.absoluteFilePath()); do we not want if (!

D4955: [QDBusMenuBar] Connect to popupRequested signal

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested this with Qt 5.6.2 + backports, the signal gets triggered fine. So far it only seems to work with a few select apps (dolphin), some (e.g. konsole) do not assign shortcuts at all and

D4955: [QDBusMenuBar] Connect to popupRequested signal

broulik edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4955 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4925: actually delete old theme caches

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4925 REVISION DETAIL https://phabricator.kde.org/D4925 To: mart, #plasma, sitter Cc: sitter, apol, plasma-devel,

D4955: [QDBusMenuBar] Connect to popupRequested signal

broulik updated this revision to Diff 12263. broulik added a comment. - Rebase to 5.9 REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4955?vs=12228=12263 REVISION DETAIL https://phabricator.kde.org/D4955 AFFECTED FILES

D4925: actually delete old theme caches

mart updated this revision to Diff 12262. mart added a comment. use QFileInfo REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4925?vs=12133=12262 BRANCH arcpatch-D4925 REVISION DETAIL https://phabricator.kde.org/D4925 AFFECTED

D4939: Get rid of KDELibs4Support

denisshienkov added inline comments. INLINE COMMENTS > volkov wrote in CMakeLists.txt:111 > I guess it can be just removed. These kf5_org.* files were dropped from solid > three years ago. Where I need to take an appropriate XML files then? > volkov wrote in CMakeLists.txt:22 > Is it

D4956: [Folder View] Lower toolbox when an item is hovered

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d1e81740d372: [Folder View] Lower toolbox when an item is hovered (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4956?vs=12229=12261

D4965: Remove ifdef round qCDebugs

davidedmundson added a comment. In https://phabricator.kde.org/D4965#93205, @graesslin wrote: > The ifdefs are from kde4 times. There it was also not needed, but nevertheless there. When working on the qt5 port I kept that under the assumption that the previous maintainer had a good

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/#review102749 --- applets/appmenu/lib/appmenuapplet.cpp (line 167)

D4383: Fix memory leak

davidedmundson abandoned this revision. davidedmundson added a comment. someone else wrote just put the same thing on RB. May as well let them ship theirs. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4383 To: davidedmundson, #plasma Cc: apol,

Re: Review Request 129995: Fix KillRunner Memory leak

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129995/#review102746 --- Fix it, then Ship it! runners/kill/killrunner.cpp (line

drawing on the X11 root window with Qt5

Hello, May I ask a question not directly related to Plasma but that hopefully concerns a trick used in some Plasma component? Basically, is it still possible to get a QWidget corresponding to the X11 root window and draw on it as on any other QWidget, and if so, how does one do that? A few

D4956: [Folder View] Lower toolbox when an item is hovered

rikmills added a comment. > In https://phabricator.kde.org/D4956#93270, @broulik wrote: > In any way it is an improvement over the status quo. No doubt. Just annoying I can't replicate your result. > It might indeed be beneficial if we place the tool box at the top right corner

D4939: Get rid of KDELibs4Support

volkov added inline comments. INLINE COMMENTS > CMakeLists.txt:111 > +qt5_add_dbus_adaptor(powerdevil_SRCS > ${SOLID_DBUS_INTERFACES_DIR}/kf5_org.freedesktop.PowerManagement.xml > powerdevilfdoconnector.h PowerDevil::FdoConnector powermanagementfdoadaptor > PowerManagementFdoAdaptor) >

D4956: [Folder View] Lower toolbox when an item is hovered

rikmills added a comment. In https://phabricator.kde.org/D4956#93275, @broulik wrote: > Are you running plasma-desktop master? There have been many improvements in highlight handling as well as the icon grid layout itself. Just updated and re-applied the patch to make sure.

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik added a comment. > only a draft based on the old design with the new semantic. The graphic is missing some states (add-hover, add-pressed, open-normal, open-hovered, remove-hover, remove-pressed). Not a fan of having a blue remove icon. Also, I was told the arrow isn't a

T5412: Improve Plasma PA usability

davidk added a comment. >> When having many devices, the list quickly becomes longer than the available space and you need to scroll. Which is difficult, because you can't use the scrollwheel for that on most of the applet because of the sliders. > > That's an issue in systray and not

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 655 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/655/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Mar 2017 09:51:55 + Build duration: 6 min 48 sec CHANGE SET Revision

D4959: [Folder View] Turn heading into a "hyperlink" and reduce hit area

This revision was automatically updated to reflect the committed changes. Closed by commit R119:138184afe09a: [Folder View] Turn heading into a "hyperlink" and reduce hit area (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D4964: [Folder View] Remove local copy of PlasmaQuick/Dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:186f1386b6be: [Folder View] Remove local copy of PlasmaQuick/Dialog (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D4962: [Folder View] Open context menu when pressing Menu key

broulik updated this revision to Diff 12256. broulik edited the test plan for this revision. broulik added a comment. - Use GridView currentItem - Cannot reproduce placement problem, I might have forgotten to actually compile after changing it to use `currentItem.frame` :) The context menu

D4961: [Folder View] Allow querying currentItem

broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4961 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4956: [Folder View] Lower toolbox when an item is hovered

broulik added a comment. Are you running plasma-desktop master? There have been many improvements in highlight handling as well as the icon grid layout itself. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4956 To: broulik, #plasma, #vdg, hein, mart Cc:

D4956: [Folder View] Lower toolbox when an item is hovered

rikmills added a comment. No, not throwing my mouse cursor at it at all. Starting at: F2753737: c691ba2eef.png then very very very slowly edging towards the toolbox, it triggers about here: F2753741: 80fd4c7b7a.png

D4956: [Folder View] Lower toolbox when an item is hovered

broulik added a comment. > You are still unable to hover the mouse and move it to click the selection and folder preview buttons. The toolbox raises or activates and blocks you. I can't reproduce. Notice how I was able to interact with the controls despite the ToolBox being there.

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

broulik added a comment. Taking for example the context menu code in FolderView: It does `KFileItem = m_dirModel->itemForIndex(index);` `item.localPath()`: `""` `item.isLocalFile()`: `false` `item.mostLocalUrl()`: `QUrl("desktop:/foo")` `item.targetUrl():` `QUrl("desktop:/foo")`

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

dfaure added a comment. KFileItem::localPath() should not ever ever be a URL like desktop:/. That would be very wrong. It just returns what you set in UDS_LOCAL_PATH, so it's kio_desktop you should debug, not kio ;) Well except for KIO::ForwardingSlaveBase, called by kio_desktop -- note