D4893: Layout and animations on the on screen keyboard

graesslin added a comment. Just verified: reverting this change also fixes the issues mentioned for Wayland. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4893 To: mart, #plasma, broulik, graesslin Cc: plasma-devel, spstarr, progwolff, lesliezhai,

D4893: Layout and animations on the on screen keyboard

graesslin added a comment. In https://phabricator.kde.org/D4893#103687, @mart wrote: > In https://phabricator.kde.org/D4893#103663, @graesslin wrote: > > > In https://phabricator.kde.org/D4893#103472, @graesslin wrote: > > > > > I fear this change caused regressions. I now don't

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #2 from Christian --- Good to know it's not only me, thanks. I still have the problem that the picture isn't changing until I reboot or after more than 24 hours. But that may be a second unrelated bug. We'll see

D5490: Only follow mouse when moved (Fixes Bug #372635)

qi437103 added a comment. F3731117: moved.patch The patch implements what I mentioned. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni,

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 Duncan <1i5t5.dun...@cox.net> changed: What|Removed |Added CC||1i5t5.dun...@cox.net ---

D5490: Only follow mouse when moved (Fixes Bug #372635)

qi437103 added a comment. For reason I don't understand, `onPositionChanged` doesn't fire for me even with `hoverEnable` set to `true`. So the last point won't work. But otherwise it works well. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner,

D5490: Only follow mouse when moved (Fixes Bug #372635)

qi437103 added a comment. Sorry I should have been more specific. The difference between these two situation is whether the mouse position in global coordinate changed. Inside `onContainsMouseChanged`, if `containsMouse` - If `moved`, select current index - Else if global

D5528: Don't map screenedge approach window if edge is only used for touch

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Another regression from enabling touch support on X11. The approach window for pointer input gets unmapped as soon as the mouse

D4893: Layout and animations on the on screen keyboard

mart added a comment. In https://phabricator.kde.org/D4893#103663, @graesslin wrote: > In https://phabricator.kde.org/D4893#103472, @graesslin wrote: > > > I fear this change caused regressions. I now don't have the virtual keyboard button on the layout anymore (X11 and Wayland) and

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner added a comment. In https://phabricator.kde.org/D5490#103680, @qi437103 wrote: > what about set moved variable according to global mousre position instead? I know this is possible with QCursor, but not sure if it's possible at qml side, though. I haven't looked at the code

D5490: Only follow mouse when moved (Fixes Bug #372635)

qi437103 added a comment. what about set moved variable according to global mousre position instead? I know this is possible with QCursor, but not sure if it's possible at qml side, though. I haven't looked at the code yet, but if there's c++ component, we can add a qobject derived class

D5527: add resize handles on all corners/sides

mart added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5527 To: mart, #plasma, hein Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5527: add resize handles on all corners/sides

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY when the desktop is unlocked make plasmoids behave like windows allowing resize from all corners changing the mouse cursor shape accordingly

D4893: Layout and animations on the on screen keyboard

graesslin added a comment. In https://phabricator.kde.org/D4893#103472, @graesslin wrote: > I fear this change caused regressions. I now don't have the virtual keyboard button on the layout anymore (X11 and Wayland) and on Wayland it's impossible to unlock the screen. I just

D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer

This revision was automatically updated to reflect the committed changes. Closed by commit R108:c3ecf55bf8e0: Do not handle ScreenEdges::check for Edges which don't activate for Pointer (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D5462: [effects/slideback] Consider windows which do have painting disabled as not usable

This revision was automatically updated to reflect the committed changes. Closed by commit R108:919b497f9020: [effects/slideback] Consider windows which do have painting disabled as not… (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D5461: Don't update the focused pointer Surface if a button is pressed

This revision was automatically updated to reflect the committed changes. Closed by commit R108:9a13743c4988: Don't update the focused pointer Surface if a button is pressed (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D5520: [platforms/x11] Do not grab touch events

This revision was automatically updated to reflect the committed changes. Closed by commit R108:a5735e19b99d: [platforms/x11] Do not grab touch events (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5520?vs=13623=13647 REVISION DETAIL

[Plasma Workspace Wallpapers] [Bug 379003] New: Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

https://bugs.kde.org/show_bug.cgi?id=379003 Bug ID: 379003 Summary: Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all. Product: Plasma Workspace Wallpapers Version: 5.9.4

D5524: Use System Dictionary for Suggestions Model

Aiix added inline comments. INLINE COMMENTS > markg wrote in main.qml:66-67 > That's smart! > > But is the file on that location on every distribution (assuming it even has > the file). I did a manual look up of that folder and file in Fedora, Neon, Ubuntu, Debian and they seem to have this

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner added a comment. In https://phabricator.kde.org/D5490#103642, @davidedmundson wrote: > If I have the mouse outside the window, and then deliberately move the mouse in to select something, by design, this won't update the index the first time. > > It'll fix your bug,

D5490: Only follow mouse when moved (Fixes Bug #372635)

davidedmundson added a comment. If I have the mouse outside the window, and then deliberately move the mouse in to select something, by design, this won't update the index the first time. It'll fix your bug, sure - but we're knowingly introducing a different bug. What we need to do

D5524: Use System Dictionary for Suggestions Model

markg added inline comments. INLINE COMMENTS > main.qml:66-67 > var baseLocation = > '/usr/share/plasma/plasmoids/org.kde.plasma.mycroftplasmoid/contents/ui/suggestion/'; > -var path = baseLocation + 'words1.txt'; > +var diclocation = '/usr/share/dict/' > +var

D5490: Only follow mouse when moved (Fixes Bug #372635)

lfurmetz added a comment. This works for me, thanks! REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,

D5411: restore the "current" color scheme concept

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in colorscm.cpp:134 > What is this about? > blocking signals is a sign of something else being seriously wrong. this is just copied from the old revision before the current entry was removed... it can be safely removed as i

D5411: restore the "current" color scheme concept

mart updated this revision to Diff 13640. mart added a comment. adress issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5411?vs=13352=13640 BRANCH arcpatch-D5411 REVISION DETAIL https://phabricator.kde.org/D5411 AFFECTED FILES

D5524: Use System Dictionary for Suggestions Model

Aiix created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ref https://phabricator.kde.org/T5918 https://phabricator.kde.org/T5892 Removed Word List and moved Suggestions Model to use default dict

D5411: restore the "current" color scheme concept

davidedmundson added inline comments. INLINE COMMENTS > colorscm.cpp:134 > +schemeList->insertItem(0, currentitem); > +schemeList->blockSignals(true); // don't emit changed signals > +schemeList->setCurrentItem(currentitem); What is this about? blocking signals is a sign of

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 865 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/865/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 11:30:31 + Build duration: 14 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 722 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/722/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 11:04:38 + Build duration: 15 min CHANGE SET Revision

D5504: Introduce a HasLauncher data role.

hein added a comment. > Can't your just connect to "this" for the dataChanged No, because then I'd also get dataChanged for rows from launcherTasksModel and would have to loop over all indices in the range to ignore them. It's kind of ugly either way. The applet code will currently

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 864 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/864/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 11:02:13 + Build duration: 6 min 2 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 115 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/115/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 10:56:58 + Build duration: 6 min 34 sec CHANGE SET Revision

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3739b4216c58: Keep startup notifications launcher-sized when inserting at launcher position. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D5504: Introduce a HasLauncher data role.

davidedmundson added inline comments. INLINE COMMENTS > tasksmodel.cpp:213 > +if (roles.contains(AbstractTasksModel::AppId) || > roles.contains(AbstractTasksModel::LauncherUrlWithoutIcon)) { > +q->dataChanged(q->index(0, 0), q->index(q->rowCount() - 1, > 0), > +

D5504: Introduce a HasLauncher data role.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3546de221549: Introduce a HasLauncher data role. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5504?vs=13631=13632 REVISION DETAIL

D5504: Introduce a HasLauncher data role.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5504 To: hein, #plasma, davidedmundson Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,

D5504: Introduce a HasLauncher data role.

hein updated this revision to Diff 13631. hein added a comment. Update HasLauncher when windows or startups update roles evaluated by appsMatch. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5504?vs=13590=13631 BRANCH master REVISION DETAIL

D5422: Don't remove other applets in SystemTray::cleanupTask

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4421cc3041b9: Don't remove other applets in SystemTray::cleanupTask (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D5515: Update the ungrabMouse hack for Qt 5.8

mart added a comment. do you know off hand a list of places where this is needed? i think kicker,taskmanager,systray... anything else? REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D5515 To:

D5487: Set xrdb XFT.DPI value as integer

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D5487 To: davidedmundson, #plasma, mart Cc: hetzenecker, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,

D5522: Introduce a concept of runtime executables that can be ignored.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This introduces a TryIgnoreRuntimes key in taskmanagerrulesrc's Settings group that can be used to list known runtime executables that can be ignored when trying to identify the application owning a

D5510: Improve how we set up the flatpak backend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:32cbc50cb819: Improve how we set up the flatpak backend (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5510?vs=13600=13627#toc REPOSITORY R134 Discover Software Store

D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH screenedge-touch-check REVISION DETAIL https://phabricator.kde.org/D5421 To: graesslin, #plasma, #kwin, mart Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed,

D5422: Don't remove other applets in SystemTray::cleanupTask

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5422 To: davidedmundson, #plasma, mart Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5488: Improve the escape key handling for breaking constrained pointers

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH pointer-constraints-escape REVISION DETAIL https://phabricator.kde.org/D5488 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed,

D5510: Improve how we set up the flatpak backend

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. If we cannot realy on id or display name for flatpak installation then we can stick with installation path :) REPOSITORY R134 Discover Software Store BRANCH flatpak-installations

D5462: [effects/slideback] Consider windows which do have painting disabled as not usable

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH slideback-painting-disabled-not-usable REVISION DETAIL https://phabricator.kde.org/D5462 To: graesslin, #plasma, #kwin, mart Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai,

D5520: [platforms/x11] Do not grab touch events

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH no-touch-grab REVISION DETAIL https://phabricator.kde.org/D5520 To: graesslin, #plasma, #kwin, mart Cc: plasma-devel, kwin, spstarr, progwolff, lesliezhai, ali-mohamed, hardening,

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

broulik accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5505 To: hein, #plasma, davidedmundson, lukas, broulik Cc: broulik, lukas, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

hein updated this revision to Diff 13626. hein added a comment. Add readonly. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5505?vs=13625=13626 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5505 AFFECTED FILES

Re: Make xdg-desktop-portal-kde part of Plasma release

On středa 19. dubna 2017 14:32:46 CEST Jonathan Riddell wrote: > On 19 April 2017 at 13:08, Jan Grulich wrote: > > I would like to request/discuss inclusion of xdg-desktop-portal-kde [1] > > into Plasma to have it released with Plasma 5.10 and so on. > > > > What is

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

broulik accepted this revision. broulik added inline comments. INLINE COMMENTS > main.qml:91 > > +property int logicalLauncherCount: { > +if (plasmoid.configuration.separateLaunchers) { `readonly` REPOSITORY R119 Plasma Desktop REVISION DETAIL

D5505: Keep startup notifications launcher-sized when inserting at launcher position.

hein updated this revision to Diff 13625. hein added a comment. Fix typo. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5505?vs=13591=13625 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5505 AFFECTED FILES

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 863 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/863/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 09:10:50 + Build duration: 12 min CHANGE SET Revision

D5262: Animate quick tiling outline

fabianr added a comment. +1, I like the new animation. It adds information without introducing any new "clutter" or slow down REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5262 To: broulik, #vdg, #plasma, #kwin Cc: fabianr, graesslin, plasma-devel, kwin, spstarr,

D5510: Improve how we set up the flatpak backend

jgrulich added a comment. Overall looks good to me, I also now understand why you don't use appScope as part of the unique id, hovewer I've been suggested by Alex to use flatpak_installation_get_display_name() or flatpak_installation_get_id(), which would result into a more readable unique

D4712: Ungrab mouse on menu close

anthonyfieroni added a comment. Why QTimer is better solution? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4712 To: anthonyfieroni, #plasma, mart, broulik Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,