D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down

2017-04-25 Thread Thomas Lübking
luebking added a comment. If the child survives the parent that normally means it's forked at some point and the fork will clear the flag - anyway: Kai says the process knocks out gdb - is it a zombie process (indicated by "D", cannot be stopped or killed, let alone being terminated) and/or

D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down

2017-04-25 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Normally the xclipboardsyncer should terminate because the socket becomes unusable. But we have reports of it not really going down and

D5588: Also list wayland sessions in autostart list

2017-04-25 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5588 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai,

D5588: Also list wayland sessions in autostart list

2017-04-25 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 379223 TEST PLAN Opened KCM Saw new entry REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL

D5582: [Media Controller] Support CanPlay/CanPause

2017-04-25 Thread Mark Gaiser
markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks good to me. Nice :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5582 To: broulik, #plasma, markg Cc: markg, plasma-devel, spstarr, progwolff, Zren

D5583: [Lock Screen] Show Previous/Next buttons only if supported

2017-04-25 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5583 To: broulik, #plasma, #vdg, graesslin Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, ab

D5583: [Lock Screen] Show Previous/Next buttons only if supported

2017-04-25 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If the user can neither go back nor forward, hide those controls for a cleaner look. TEST PLAN If one action (e.g. only "Next" is supported

D5573: Don't accept hover events in the DragArea

2017-04-25 Thread Albert Astals Cid
aacid added a comment. What about in the FolderView side? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D5573 To: davidedmundson, #plasma Cc: aacid, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

Plasma 5.9.5

2017-04-25 Thread Jonathan Riddell
https://www.kde.org/announcements/plasma-5.9.5.php Plasma bugfix out now, highlights include: - Plastik window decoration now supports global menu. Commit. See bug #375862. Phabricator Code review D5131 - Media Controller can now properly handle and seek long tracks (> 30 minutes). Commit. Fixes

D5582: [Media Controller] Support CanPlay/CanPause

2017-04-25 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way we disable the play/pause button and context menu entry if player claims it cannot. TEST PLAN Cleared my playlist, Play button was

D5573: Don't accept hover events in the DragArea

2017-04-25 Thread David Edmundson
davidedmundson added a comment. In https://phabricator.kde.org/D5573#104619, @aacid wrote: > "Setting it enabled broke FolderView nested in a grouping Plasmoid" is this worth adding an auto test somewhere? Maybe, but it'd be testing that an item doesn't do what it had no reason to

D5573: Don't accept hover events in the DragArea

2017-04-25 Thread Albert Astals Cid
aacid added a comment. "Setting it enabled broke FolderView nested in a grouping Plasmoid" is this worth adding an auto test somewhere? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D5573 To: davidedmundson, #plasma Cc: aacid, plasma-devel, #frameworks, spstar

D5581: [TaskGroupingProxyModel] Use LauncherUrlWithoutIcon

2017-04-25 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5581 To: broulik, #plasma, hein Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5581: [TaskGroupingProxyModel] Use LauncherUrlWithoutIcon

2017-04-25 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We manually remove the query anyway, so the icon can never be a part of the URL. TEST PLAN Forcing grouping/ungrouping still works, it also

D5262: Animate quick tiling outline

2017-04-25 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R108:eaf41cb6c516: Animate quick tiling outline (authored by broulik). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5262?vs=13729&id=13787 REVISION DETAIL https://phab

D5297: [TextFieldStyle] Fix textField is not defined error

2017-04-25 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:884f89b9b038: [TextFieldStyle] Fix textField is not defined error (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D52

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 125 - Still Unstable!

2017-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/125/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Apr 2017 12:28:32 + Build duration: 20 min CHANGE SET Revision 2ad36bf12016901dec9a2bc2e

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 727 - Still Unstable!

2017-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/727/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Apr 2017 12:42:00 + Build duration: 8 min 29 sec CHANGE SET Revision a40b2dc0bdae869164ea99058a9dd2

D5579: Introduce QQuickItem to nest kwin_wayland

2017-04-25 Thread Bhavisha Dhruve
bdhruve added a comment. This patch is follow-up of https://phabricator.kde.org/D1989. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5579 To: bdhruve, #plasma_on_wayland, #kwin Cc: plasma-devel, kwin, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, hardening, jens

D5579: Introduce QQuickItem to nest kwin_wayland

2017-04-25 Thread Bhavisha Dhruve
bdhruve created this revision. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This starts Wayland server with some basic interfaces - shm - compositor - seat - shell - output And sta

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

2017-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Apr 2017 12:05:13 + Build duration: 12 min CHANGE SET Revision f68f15de070cbfe00397067

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 124 - Still Unstable!

2017-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/124/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Apr 2017 11:55:46 + Build duration: 19 min CHANGE SET Revision 03006fd66ac1c79421a51751f

Jenkins-kde-ci: plasma-tests Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Unstable!

2017-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-tests%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Apr 2017 12:01:57 + Build duration: 1 min 2 sec CHANGE SET Revision bf393665445c130878b2dcf6

D1989: Introduce QQuickItem to nest kwin_wayland

2017-04-25 Thread Bhavisha Dhruve
bdhruve abandoned this revision. bdhruve added a comment. This revision was started last year which had lot of discussions. Had a few of unfinished issues to be fixed as well. So creating a new one which has fixed the last few issues addressed by @graesslin and @davidedmundson. And i am ex

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 868 - Still Unstable!

2017-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/868/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Apr 2017 11:08:12 + Build duration: 8 min 1 sec CHANGE SET Revision 4421cc3041b9d172378ba5774241f

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

2017-04-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/117/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Apr 2017 11:07:07 + Build duration: 8 min 5 sec CHANGE SET Revision 75eeae6b42ccf9d553

D5490: Only follow mouse when moved (Fixes Bug #372635)

2017-04-25 Thread David Edmundson
davidedmundson added a comment. Cool, seems like a solid approach. Just nitpicks left. INLINE COMMENTS > mousehelper.h:41-42 > + > +Q_INVOKABLE QPointF globalMousePosition() const; > +Q_INVOKABLE void setGlobalMousePosition(const QPointF &pos); > +}; You don't need these to be i

D5490: Only follow mouse when moved (Fixes Bug #372635)

2017-04-25 Thread Leszek Lesner
leszeklesner updated this revision to Diff 13771. leszeklesner added a comment. Updated to solution by qi437103 which implements a mousehelper to get the global mouse position so we can distinguish between mouse being inside the resultslistview or outside REPOSITORY R112 Milou CHANGES SIN