D5670: Avoid deep copy of image data when getting pixmaps in SNIs

2017-04-30 Thread Mark Gaiser
markg accepted this revision. markg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > statusnotifieritemsource.cpp:393-399 > if (QSysInfo::ByteOrder == QSysInfo::LittleEndian) { > uint *uintBuf = (uint *) image.data.data(); > for (uin

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-30 Thread Mark Gaiser
markg accepted this revision. markg added a comment. Ship it :) REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-04-30 Thread Eugene Shalygin
eshalygin added a comment. Any news? REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg Cc: broulik, markg, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5670: Avoid deep copy of image data when getting pixmaps in SNIs

2017-04-30 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We get the data as a QByteArray we can just ref the original data, rather than doing a deep copy of the data. Might save a few cy

D5569: thumbnail ioslave: Port away from KDELibs4Support

2017-04-30 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Easy one ;-) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5569 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jen

D5490: Only follow mouse when moved (Fixes Bug #372635)

2017-04-30 Thread Aetf
This revision was automatically updated to reflect the committed changes. Closed by commit R112:a41a850a3943: Only follow mouse when moved (Fixes Bug #372635) (authored by qi437103). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5490?vs=13900&id=14038 REVISION

[kio-extras] [Bug 366638] [16.04] sftp stuck operations. Can operate only if reopening Dolphin

2017-04-30 Thread Germano Massullo
https://bugs.kde.org/show_bug.cgi?id=366638 --- Comment #6 from Germano Massullo --- Confirming on kio-extras 16.12.3 -- You are receiving this mail because: You are the assignee for the bug.

D5568: SFTP ioslave: Port away from KDELibs4Support

2017-04-30 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5568 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5568: SFTP ioslave: Port away from KDELibs4Support

2017-04-30 Thread Jonathan Marten
marten updated this revision to Diff 14036. marten added a comment. There seems to be only one place where the result from the openPasswordDialog is actually propagated to the outside. I've changed this one; the point of changing the others was to port away from the old deprecated function.

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 737 - Still Unstable!

2017-04-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/737/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Apr 2017 14:54:29 + Build duration: 5 min 56 sec CHANGE SET Revision d601eb794a052b2b61f4d05941aae0

D5568: SFTP ioslave: Port away from KDELibs4Support

2017-04-30 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kio_sftp.cpp:836 > // Handle user canceled or dialog failed to open... > -if (!openPasswordDialog(info, errMsg)) { > +if (openPassword

D5567: Settings ioslave: Port away from KDELibs4Support

2017-04-30 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5567 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 873 - Still Unstable!

2017-04-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/873/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Apr 2017 14:00:58 + Build duration: 17 min CHANGE SET Revision 039bff026c83ee389a90ab5786f7b1ffbf

D5446: Implement support for selected mime type filters

2017-04-30 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R135:0a6be721e4e3: Implement support for selected mime type filters (authored by elvisangelaccio). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricato

D5566: recentdocuments ioslave: Port away from KDELibs4Support

2017-04-30 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5566 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5665: VolumeObject: Make channelVolumes readable from QML

2017-04-30 Thread David Rosca
This revision was automatically updated to reflect the committed changes. Closed by commit R115:b84ed90c50cd: VolumeObject: Make channelVolumes readable from QML (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5665?vs=14

D5665: VolumeObject: Make channelVolumes readable from QML

2017-04-30 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D5665 To: drosca, #plasma, davidedmundson Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-moha

D5562: Fish ioslave: Port away from KDELibs4Support

2017-04-30 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nice work. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5562 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensr

D5561: Filter ioslave: Port away from KDELibs4Support

2017-04-30 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5561 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreut

D5560: Archive ioslave: Port away from KDELibs4Support

2017-04-30 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5560 To: marten, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5665: VolumeObject: Make channelVolumes readable from QML

2017-04-30 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use QList instead of QList which is not supported by QML. TEST PLAN Can now be read from QML REPOSITORY R115 Plasma Audio Volume Applet B

D5446: Implement support for selected mime type filters

2017-04-30 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D5446 To: elvisangelaccio, #plasma, dfaure Cc: anthonyfieroni, plasma-devel, spstarr, progwol