graesslin requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, pro
graesslin added a comment.
In https://phabricator.kde.org/D5757#108115, @mart wrote:
> In https://phabricator.kde.org/D5757#108070, @graesslin wrote:
>
> > Please also extend the test in
autotests/client/test_wayland_windowmanagement.cpp
>
>
> isn't it covered by
no, tha
https://bugs.kde.org/show_bug.cgi?id=379643
Bug ID: 379643
Summary: When I turn on my notebook, after the full startup of
KDE Plasma 5, I verify that the battery monitor is
disabled, as if the battery was not present.
Produc
hein added a comment.
Nevermind, I got the scheduling wrong.
It's been a pretty crazy 36 hours.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5756
To: hein, #plasma, sebas, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, spstarr, progwolff, les
hein added a comment.
We rescheduled the frameworks release to match Plasma and have almost a week
until 5.10 freezes, so why are you holding this back? I'd at least like some
explanation for the embargo.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/
apol added a comment.
Let's wait until Kirigami 2.2
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5768
To: leinir, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5769
To: leinir, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apo
mart updated this revision to Diff 14320.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- since 5.35
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5757?vs=14276&id=14320
BRANCH
phab/abovebelow
R
leinir added a comment.
In https://phabricator.kde.org/D5767#108234, @apol wrote:
> It could make sense to move this to the KNSBackend, any appstream-based
backends don't have such a problem.
Good point indeed - while it isn't really kns specific, we don't have any
other backends
apol added a comment.
It could make sense to move this to the KNSBackend, any appstream-based
backends don't have such a problem.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5767
To: leinir, apol
Cc: markg, plasma-devel, ZrenBot, spstarr, progwol
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R128 User Manager
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D5779
To: elvisangelaccio, #plasma, jriddell, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, le
elvisangelaccio created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The KIO job needs to be run synchronously, otherwise the KCM might be
deleted before the job finished. This happens when closing the
bshah created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- It looks if we are on FreeBSD, then it sets the USE_SYSCTL
- If USE_SYSCTL is set, it will try to use acpi_video interface to set
the br
mart updated this revision to Diff 14311.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
apply workaround when we have only parentItem
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e3293e9c05b5: Add support for remote image sources to
DesktopIcon (authored by leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5764?vs=14282&id=14309#toc
REPOSITORY
R169 Kirigami
CH
mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> desktopicon.cpp:366
> }
> +} else if(iconSource.startsWith("http://";) ||
> iconSource.startsWith("https://";)) {
> +if(!m_loadedImage.isNull()) {
cod
mart added a comment.
In https://phabricator.kde.org/D5757#108070, @graesslin wrote:
> Please also extend the test in
autotests/client/test_wayland_windowmanagement.cpp
isn't it covered by
QTest::newRow("keepAbove") << &PlasmaWindowInterface::keepAboveRequested <<
int(ORG_KDE_
davidedmundson added a comment.
looks sensible.
Is this only needed for a specific version of Qt? In either case can you
check on the Qt 5.7 machine.
INLINE COMMENTS
> qmenu.cpp:112
> +
> +QQuickItem *item = qobject_cast(m_visualParent.data());
> +if (item) {
there's a code
mart added a reviewer: Plasma on Wayland.
REPOSITORY
R120 Plasma Workspace
BRANCH
phab/abovebelow
REVISION DETAIL
https://phabricator.kde.org/D5758
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, je
mart added reviewers: Plasma, Plasma on Wayland.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5748
To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts
mart added a reviewer: Plasma on Wayland.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5745
To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, a
mart added a reviewer: Plasma on Wayland.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, a
mart added a reviewer: Plasma on Wayland.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5773
To: mart, #plasma, #plasma_on_wayland
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, ap
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
this ensure two things:
- submenus have the main menu as transientParent
- the visualParent window() is used as trans
https://bugs.kde.org/show_bug.cgi?id=379265
Kai Uwe Broulik changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/pow
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:c57301685cc6: Re-trigger lid action when lid is closed
and external monitor is disconnected (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5606?vs=13846&id=14298#toc
REP
leinir added a comment.
In https://phabricator.kde.org/D5767#108088, @markg wrote:
> I don't think adding a (rather massive) delay is the real fix here. It only
masks the actual issue.
>
> What really happens (just opened the discover store for the first time
ever) is that entries ca
rthomas added a comment.
I couldn't find a reasonable way to set the timezone from the returned
country, so I think it's best to avoid it for now.
I don't have commit access, David. This is the first time I'm working on the
kdeplasma-addons repository. Please commit it on my behalf.
REP
markg added a comment.
I don't think adding a (rather massive) delay is the real fix here. It only
masks the actual issue.
What really happens (just opened the discover store for the first time ever)
is that entries can flow in at any point, that might be an issue.
Every batch can cont
graesslin accepted this revision.
graesslin added a comment.
As it depends on newer frameworks: commit embargo till 5.10 is branched.
REPOSITORY
R120 Plasma Workspace
BRANCH
phab/abovebelow
REVISION DETAIL
https://phabricator.kde.org/D5758
To: mart, #plasma, hein, graesslin
Cc: graess
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Obviously commit embargo till 5.10 is branched is still in place.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5755
To: hein, #p
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please also extend the test in
autotests/client/test_wayland_windowmanagement.cpp
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart,
graesslin accepted this revision.
graesslin added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kwaylandintegration.cpp:157
> +
> +#include "kwaylandintegration.moc"
Just wondering: why is the moc file needed now?
REPOSITORY
R135 Integration for Qt applic
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
There's also the option of doing dt.setTimezone()
but then we'd have to remove the current code doing the timezone adjustments,
as we'd end up adjusting it twice.
Do
leinir added a comment.
In https://phabricator.kde.org/D5769#108014, @apol wrote:
> This will add a dependency to Kirigami 2.2, is it something we can have?
I did consider adding a loader-based fallback system to this, but that would
put a loader inside the listviews, and i'm not
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130006/
---
(Updated May 8, 2017, 3:09 p.m.)
Status
--
This change has been disc
rthomas added reviewers: davidedmundson, broulik.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D5770
To: rthomas, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
rthomas created this revision.
rthomas added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Krunner is suffixing the local timezone when asked for the time of other
regions. QLocale doesn't provide a way to set the locale based only on the
country
leinir added a comment.
In https://phabricator.kde.org/D5764#108019, @apol wrote:
> Don't we also have to add support for when DesktopIcon::m_source is a QIcon?
That's already covered in DesktopIcon::updatePaintNode's big switch
statement, where it checks for what type is actually
apol added a comment.
Don't we also have to add support for when DesktopIcon::m_source is a QIcon?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D5764
To: leinir, mart, apol
Cc: plasma-devel, apol
leinir updated this revision to Diff 14291.
leinir added a comment.
Have a slightly more useful fallback icon than just nothing (that is, if
there is no first thumbnail, use the one it used previously)
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.
apol added a comment.
This will add a dependency to Kirigami 2.2, is it something we can have?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5769
To: leinir, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterber
leinir created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As we are a Kirigami application, this makes use of the Kirigami icon item,
which in turn allows us to use more types of icons, and not just QI
graesslin added a comment.
Why was this change pushed although it had a "This has commit embargo till
5.10 is branched." comment? Yes I accepted it, but obviously the embargo still
holds. Even more the commit builds up on changes in KWayland which are not
pushed.
May I ask why it takes
leinir created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Rather than using the same icon for all KNS based resources, this will return
the URL for the first screenshot item.
REPOSITORY
R134 Discove
leinir created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We currently postpone searches 200ms, but as this causes a great deal of
online traffic, and no small amount of visual clutter (a whole lot of
leinir created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This adds support for images hosted on http(s) remotes to the DesktopIcon
item. It uses the qnam from the qqmlengine the item is associated w
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/743/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 10:21:08 +
Build duration: 31 min
CHANGE SET
Revision af113da8c5500df85b48f1f5f6966539116b
mart updated this revision to Diff 14276.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
autotest
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5757?vs=14273&id=14276
BRANCH
phab/abovebelow
REVIS
marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This CMake module used to be provided by KDELibs4Support. Since the removal
of that dependency from kio-extras, the module is not found and th
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/881/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 08 May 2017 10:17:53 +
Build duration: 6 min 41 sec
CHANGE SET
Revision 5f73bbc527505e59487e624470b7
This revision was automatically updated to reflect the committed changes.
Closed by commit R526:919f19b63388: install preview image (authored by
jriddell).
REPOSITORY
R526 Breeze theme for Plymouth
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5760?vs=14270&id=14275
REVISION DETAIL
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5756
To: hein, #plasma, sebas, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed,
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.
You also still need to extend PlasmaWindowModel and the unit tests.
Everywhere in the kwayland codebase requestToggleMinimized pops up should also
have a codepath for these new ones.
mart updated this revision to Diff 14273.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- since 5.35
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5757?vs=14263&id=14273
BRANCH
phab/abovebelow
R
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
phab/abovebelow
REVISION DETAIL
https://phabricator.kde.org/D5758
To: mart, #plasma, hein
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreut
hein requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein
Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterber
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R526 Breeze theme for Plymouth
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5760
To: jriddell, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterber
hein added inline comments.
INLINE COMMENTS
> plasmawindowmanagement.h:407
> +
> +/**
> + * Requests the window at this model row index have its keep above state
> toggled.
All these need @since
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart,
hein updated this revision to Diff 14272.
hein added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Document the limitations of the AppPid data role better.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5755?vs=1426
davidedmundson updated this revision to Diff 14271.
davidedmundson added a comment.
Remove leftover code
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5746?vs=14245&id=14271
BRANCH
testing
REVISION DETAIL
https://pha
jriddell added a reviewer: mart.
REPOSITORY
R526 Breeze theme for Plymouth
REVISION DETAIL
https://phabricator.kde.org/D5760
To: jriddell, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
jriddell created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
install preview image
TEST PLAN
used kcm_plymouth
REPOSITORY
R526 Breeze theme for Plymouth
BRANCH
master
REVISION DETAIL
https://
hein updated this revision to Diff 14268.
hein added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Put code working with the client connection into ShellClient.
Fix commit subject.
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde
hein added a comment.
Argh, the lack of sleep ... I updated the wrong Phab. Give me a few mins ;)
INLINE COMMENTS
> graesslin wrote in waylandtasksmodel.cpp:340
> You are aware that pid is not always correct? Any process started by KWin
> shares KWin pid. Given that one need to be careful ou
hein updated this revision to Diff 14267.
hein added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Restricted Application added subscribers: KWin, kwin.
Put code working with the client connection into ShellClient.
Fix commit subject.
REPOSITORY
R108 KWi
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
cobbect requestToggleKeepAbove and below with libtaskmanager
TEST PLAN
setting keep above from taskbar works
REPOSITORY
R120 Plasma Workspac
hein added a comment.
Sorry, I was sleep-walking while coding on this, see the timestamp :) I'll
un-fuck this ...
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5756
To: hein, #plasma, sebas, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, spstarr, progwolff, leslie
mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
client requests to toggle those states, to be used by libtaskmanager
TEST PLAN
setting keep above from the tas
69 matches
Mail list logo
