El divendres, 9 de juny de 2017, a les 13:59:20 CEST, David Edmundson va
escriure:
> >StaticMessages.sh
>
> Didn't know about that, thanks.
> I've implemented it, but can only test so much. Can you send me scripty
> logs if it fails.
Seems to be working-ish?
Do you know if you can me it be a
Zren updated this revision to Diff 15400.
Zren added a comment.
Semicolons... (I should install a linter)
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6188?vs=15398=15400
REVISION DETAIL
https://phabricator.kde.org/D6188
AFFECTED FILES
Zren updated this revision to Diff 15398.
Zren added a comment.
We don't really need to wait for folderViewLayer.ready before setting the
bottom/right anchors anymore.
Don't add extra spacing if we're not a containment (the desktop).
Remove comment that's no longer applicable.
REPOSITORY
hein added a comment.
The widget should keep using the old behavior, grid-fitting is pretty awkward
there (and I can already hear "my icons don't line up across widgets"
complaints). This is really a desktop-specific special case motivated by people
trying to put icons into opposing screen
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6186
To: Kanedias, graesslin, davidedmundson
Cc: plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed,
Kanedias marked an inline comment as done.
Kanedias added a comment.
I'm still unsure about cursor damage region (digging through cursor-related
signals now)
Cursor itself works fine, tested on kms Mesa 17.1.2 amdgpu (and in KRfb
session)
INLINE COMMENTS
> davidedmundson wrote in
hein added a comment.
The comment is mostly about the fact that this means you can no longer drop
icons there then. Keep in mind that when the view is in columnar mode,
horizontal overflow is (currently) the expected and correct behavior - if the
folder is fuller than the screen can fill,
Kanedias updated this revision to Diff 15397.
Kanedias added a comment.
Whoops... :)
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6186?vs=15396=15397
REVISION DETAIL
https://phabricator.kde.org/D6186
AFFECTED FILES
scene_opengl.cpp
scene_opengl.h
Zren added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in FolderView.qml:538
> Why it used (6 * units.smallSpacing) it makes more space at bottom? It should
> be same as iconwidth calculation, about me. I see you not change it, but it
> should.
Fairly certain was `smallSpacing *
Zren added a comment.
In https://phabricator.kde.org/D6188#115982, @hein wrote:
> You didn't change the comment above the code you modified. Did you test
that this is no longer an issue? If not, the comment needs adjusting.
Ah, yeah, I should remove that comment. Beforehand, you
Kanedias updated this revision to Diff 15396.
Kanedias added a comment.
- Made cursor texture local var with lazy-init
- Made changes to support cursor shape update
- Added cursor hotspot handling
- Removed redundant vbo calls
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.
This most likely breaks the text position in the rename editor matching the
label position.
The rectangle selection code also tests for intersection with the icon and
label
Zren created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Is there a reason we need to have the label to be implicitWidth?
Right now, we get a binding loop on `width: Math.min(label.implicitWidth +
hein added a comment.
In https://phabricator.kde.org/D6188#115977, @Zren wrote:
> Remove check for if we're already overflowing, using rtl layout, or if it's
"arrange in columns/rows", since the ScrollView shouldn't be covered by panels.
You didn't change the comment above the
Zren marked 2 inline comments as done.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6188
To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Zren updated this revision to Diff 15393.
Zren added a comment.
+readonly. +semicolons.
Remove check for if we're already overflowing, using rtl layout, or if it's
"arrange in columns/rows", since the ScrollView shouldn't be covered by panels.
REPOSITORY
R119 Plasma Desktop
CHANGES
Zren added a comment.
Oh now I remember why I used `scrollView.viewport`. We don't want to count
the scrollbars as "extra" space. Notice in this screenshot it would perfectly
fit another row, but the scrollbar made the area shorter.
F3782025: 2017-06-12___13-17-47.png
Zren added a comment.
So removing the following two conditionals fixes it. I'm not sure why they
are there. Right now it only stops at the panels if we're already overflowing.
in `rightMargin`: `(folderViewLayer.view.overflowing ||
folderViewLayer.view.flow == GridView.FlowLeftToRight ||
Zren added a comment.
In https://phabricator.kde.org/D6188#115778, @broulik wrote:
> About panels covering the contents, perhaps you want to take into account
`plasmoid.availableScreenRect` but `root` already has a `margin` based on this,
so maybe just use the `ScrollView`'s size
apol added a comment.
Can you maybe extend the knsbackendtest to make sure we won't regress this?
Thanks a lot!!!
INLINE COMMENTS
> KNSBackend.cpp:109
> m_engine->init(m_name);
> +/// FIXME Set knscore's engine page size to 100 when we can depend on a
> new enough frameworks
>
bschiffner added a comment.
Thanks for the feedback.
It was integrated to my best understanding and works for me.
Why "^[0-9:]"? Sometimes it is just fun using the biggest sledgehammer. But
in all respect: it is even gender neutral to be smashed this way!
(I tried something to do it
bschiffner updated this revision to Diff 15381.
bschiffner added a comment.
Upating https://phabricator.kde.org/D6183: [Digital Clock] Allow copying
current date and time to clipboard
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
mart added inline comments.
INLINE COMMENTS
> notificationshelper.cpp:154
> +
> +popup->show();
> +});
at this point it still thinks the size is 0,0
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3209
To: broulik, #plasma, mck182, mart
Cc: mart,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b0e8ea29fab4: Set Containments to have focus within the
view (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik added a comment.
BUG: 381124
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6192
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6192
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
anthonyfieroni added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in FolderView.qml:538
> Why it used (6 * units.smallSpacing) it makes more space at bottom? It should
> be same as iconwidth calculation, about me. I see you not change it, but it
> should.
You can use padding (or
anthonyfieroni added inline comments.
INLINE COMMENTS
> FolderView.qml:538
>
> +property int iconHeight: (iconSize +
> (theme.mSize(theme.defaultFont).height * plasmoid.configuration.textLines) +
> (6 * units.smallSpacing))
> +property real extraHeight:
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Now that applets are their own focus scope (which makes sense) we've
also made containments their own focus
leinir created this revision.
leinir added a project: Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This code removes the custom pagination in KNSBackend in favour of using the
internal
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.
Looks pretty good to me. It needs some polish as marked, but we should test
it in master soon.
INLINE COMMENTS
> FolderView.qml:526
> +}
> +
jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This adds support for Fortigate SSL VPN which has been added recently to NM
[1]. There is also a
bug 355079 opened for missing support.
The minutes of today's meeting!
--
sebas
http://www.kde.org | http://vizZzion.orgPresent: notmart, Sho, d_ed, romangg, kbroulik, bshah, sebas
notmart:
* some triaging
* breeze shadows work on wayland [pushed]
* kirigami gallery release on google play
* fix in extra-cmake-modules for deployment
Hi,
is there any reason why you guys need to use 4.3.5? It's over
seven years old ...
Cheers,
Eike
On 06/11/2017 08:25 PM, Shitrit, Shahaf wrote:
> Hey,
> I’m using the very useful pager widget on kde 4.3.5 .
> Unlike in previos kde version, there is a problem to see in which
> desktop I am
mart added a comment.
I like the approach david has taken in https://phabricator.kde.org/D6164
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6141
To: mart, #plasma, #kwin, graesslin
Cc: luebking, mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr,
mart added a comment.
+1
INLINE COMMENTS
> scene_opengl.cpp:2358
>
> -const int width = qMax(topLeft.width(), bottomLeft.width()) +
> +const int width = qMax3(topLeft.width(), left.width(),
> bottomLeft.width()) +
>qMax(top.width(), bottom.width()) +
oh, i
Hey,
I'm using the very useful pager widget on kde 4.3.5 .
Unlike in previos kde version, there is a problem to see in which desktop I am
at.
Please take a look:
Previos version - can clearly see in which desktop I am:
New version - impossible to see the current desktop:
Is there any way to
broulik abandoned this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1350
To: broulik, #plasma:_design, #plasma, davidedmundson
Cc: bschiffner, colomar, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
broulik added a comment.
About panels covering the contents, perhaps you want to take into account
`plasmoid.availableScreenRect` but `root` already has a `margin` based on this,
so maybe just use the `ScrollView`'s size instead of `viewport`.
REPOSITORY
R119 Plasma Desktop
REVISION
davidedmundson added a comment.
It's a bit of a shame that we're mixing two data sources in the same applet,
but I guess we're limited by whatever works.
INLINE COMMENTS
> clipboardmenu.cpp:83
> +s = time.toString(Qt::SystemLocaleLongDate);
> +s.replace(rx, "");
> +a
broulik added a comment.
Thanks a lot for picking this up!
I have some minor nitpicks below, otherwise looking very good. You don't need
to mention "Fixes https://bugs.kde.org/show_bug.cgi?id=355190; in the commit
message, the "BUG: 355190" already does this, also causes Bugzilla to
This revision was automatically updated to reflect the committed changes.
Closed by commit R838:45843db8d63a: Massively simplify the class DesktopPortal
(authored by davidedmundson).
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
CHANGES SINCE LAST UPDATE
davidedmundson added a comment.
> Is this the correct way of doing such stuff?
Pretty much.
Seems a sensible patch, screen recording aside we could be using a GL on a
different backend that can't do planes.
The obvious optimisation is that we don't need to make the new cursor
jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.
Awesome!! I've tested all portals and they do work. Thanks a lot.
Btw. next time if you would like to test portals you can use my test
application
44 matches
Mail list logo
