D6459: Fix the National Geographic PoTD dataengine

2017-07-04 Thread Rohan Garg
garg added a comment. Can this also go into the next 5.10 release? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D6459 To: garg, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D6498: Don't list plasmashell in menus

2017-07-04 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6498 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6487: Applet: Rename MediaPlayer to MediaPlayerItem

2017-07-04 Thread David Rosca
This revision was automatically updated to reflect the committed changes. Closed by commit R97:94ff9f296b6e: Applet: Rename MediaPlayer to MediaPlayerItem (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6487?vs=16141=16165#toc REPOSITORY R97 Bluedevil CHANGES

Minutes Monday Plasma Hangout

2017-07-04 Thread Sebastian Kügler
Here we go! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 20-30-2017 Present: kbroulik, Sho, notmart, d_ed, bshah, sebas kbroulik: * Implemented a couple of wishlist entries in plasmashell ("Open containing folder" button for image selector in wallpaper; "show apps by

D3805: Per-activity favorites (Final, again?)

2017-07-04 Thread Eike Hein
hein added a comment. After the crash, the re-added Appdash seems to have the same favorites as the old Appdash instance had, which is still not the superset of the pre-migration favorites or anything, nor the same favorites as the Kickoff. REVISION DETAIL

D3805: Per-activity favorites (Final, again?)

2017-07-04 Thread Eike Hein
hein added a comment. I get the crash also when removing and re-adding Appdash: Thread 1 (Thread 0x7f6573ed8dc0 (LWP 3060)): [KCrash Handler] #6 0x034d3d70 in () #7 0x7f64c813bb0c in KAStatsFavoritesModel::Private::data(QModelIndex const&, int) const (role=266,

D3805: Per-activity favorites (Final, again?)

2017-07-04 Thread Eike Hein
hein added a comment. Another full test write up. Ivan informed in an email that for a clean slate test, in addition to the SQL deletion and deleting kactivitymanager-statsrc, also favoritesPortedToKAstats=true needs to be removed from all places in appletsrc, so I did another test

D6495: Don't list KF5::WindowSystem in public libraries

2017-07-04 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f8de13c67421: Don't list KF5::WindowSystem in public libraries (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D3805: Per-activity favorites (Final, again?)

2017-07-04 Thread Eike Hein
hein added a comment. Another crash, this time a while after running with migrated favourites: Thread 1 (Thread 0x7f8ef082cdc0 (LWP 8048)): [KCrash Handler] #6 0x7f8e44c0dcf8 in KAStatsFavoritesModel::Private::removeOldCachedEntries() const (this=0x40fc41c800) at

D6472: Fix plasmashell.desktop hidden=true

2017-07-04 Thread David Edmundson
davidedmundson abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6472 To: davidedmundson, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6498: Don't list plasmashell in menus

2017-07-04 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Actually read autostart code this time. It's unaffected. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL