D6707: Move browser detection to the extension

This revision was automatically updated to reflect the committed changes. Closed by commit R856:f01e3f0b98c0: Move browser detection to the extension (authored by fvogt). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6707?vs=16724=16726#toc REPOSITORY R856 Plasma Browser Integration

D6707: Move browser detection to the extension

fvogt marked an inline comment as done. REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D6707 To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D6707: Move browser detection to the extension

broulik added inline comments. INLINE COMMENTS > extension.js:55 > +// Try to match the most derived first > +if (ua.match(/vivaldi/i)) > +browser = "vivaldi"; Please use braces also for one line statements REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION

D6707: Move browser detection to the extension

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Very nice! REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D6707 To: fvogt, #plasma, broulik, davidedmundson Cc:

D6707: Move browser detection to the extension

fvogt added a comment. I noticed that the correct dir for the firefox native messaging host is not `/usr/lib/mozilla/native-messaging-hosts/org.kde.plasma.browser_integration.json`, but rather `/usr/lib64/mozilla/native-messaging-hosts/org.kde.plasma.browser_integration.json`. I'm not 100%

D6707: Move browser detection to the extension

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY It's much easier to detect the browser there, so let the extension write a message with the browser name (mapped to Settings::Environment) to the native host. Also add support for Vivaldi. TEST

D6704: Fix tabsrunner DBus reply parsing

This revision was automatically updated to reflect the committed changes. Closed by commit R856:cfc45b00fb30: Fix tabsrunner DBus reply parsing (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6704?vs=16717=16722

D6704: Fix tabsrunner DBus reply parsing

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D6704 To: fvogt, #plasma, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D6705: Actually filter the tab properties sent to the host

broulik added a comment. Ah, ok, I only looked at Chrome documentation. Might come in handy for Task Manager thumbnails at some point :) REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D6705 To: fvogt, #plasma, broulik, davidedmundson Cc:

D6705: Actually filter the tab properties sent to the host

This revision was automatically updated to reflect the committed changes. Closed by commit R856:6d10d359a1c2: Actually filter the tab properties sent to the host (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D6705: Actually filter the tab properties sent to the host

fvogt added a comment. In https://phabricator.kde.org/D6705#125503, @broulik wrote: > Where did you see a JPEG-encoded screenshot? Could perhaps be the favicon. In extData["thumbnail"], much larger than a favicon should ever be. Didn't get sent by opera 40, vivaldi 1.10 added

D6705: Actually filter the tab properties sent to the host

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Where did you see a JPEG-encoded screenshot? Could perhaps be the favicon. REPOSITORY R856 Plasma Browser Integration BRANCH tabfix (branched from master) REVISION DETAIL

D6705: Actually filter the tab properties sent to the host

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Previously it sent all information about a tab that it had, including a base64 encoded JPG screenshot, causing quite a lot of traffic. TEST PLAN dbus-monitor shows a lot less traffic, krunner

D6704: Fix tabsrunner DBus reply parsing

fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The TODO comment in the code turned out to have fixed itself, so the code needed adjustment. As QList (which is actually a QList>) is apparently not a demarshall target,

D6673: [Notifications] Manually remove remote images

davidedmundson added a comment. hypothetically (and this would still require a Qt change) if we could override loadResource would that be enough for doing what this is doing? INLINE COMMENTS > textsanitizer.cpp:41 > + > +QScopedPointer newDocument(new QTextDocument()); > +

D5705: AppMenu: Don't call AboutToShow on LayoutUpdated

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. If something is worth deleting, it's worth deleting properly. Kill the whole method. We can always revert it. REPOSITORY R120 Plasma Workspace BRANCH

D5705: AppMenu: Don't call AboutToShow on LayoutUpdated

drosca added a comment. Any comments on this? It is still broken. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5705 To: drosca, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6673: [Notifications] Manually remove remote images

davidedmundson added a comment. Addressing the text first: > The network access manager factory we install is ineffective as Plasma uses a shared engine nowadays and whenever a new QmlObject shared engine is created, its setupBindings will re-install the KIO access factory. There

D6673: [Notifications] Manually remove remote images

broulik updated this revision to Diff 16692. broulik added a comment. - Iterate all blocks REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6673?vs=16691=16692 REVISION DETAIL https://phabricator.kde.org/D6673 AFFECTED FILES

D6673: [Notifications] Manually remove remote images

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > textsanitizer.cpp:45 > +for (int i = 0; i < newDocument->blockCount(); ++i) { > +QTextBlock block = newDocument->findBlock(i); > + (Already noted

D6673: [Notifications] Manually remove remote images

broulik updated this revision to Diff 16691. broulik added a comment. Use while loop to avoid off-by-one error when starting over REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6673?vs=16631=16691 REVISION DETAIL

D6628: Fix and normalize license in .desktop files

This revision was automatically updated to reflect the committed changes. Closed by commit R119:782cb4d27e7b: Fix and normalize license in .desktop files (authored by sebas). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6628?vs=16513=16690 REVISION

D6697: Allow to change toolbar font separately again

rkflx added a subscriber: jensreuterberg. rkflx added a comment. Screenshots for Plasma 5 with toolbar font sizes 8pt, 9pt (former broken default), 10pt (new default, same as menu bar): | F3810800: plasma5-08pt.png | F3810802: plasma5-09pt.png

D6697: Allow to change toolbar font separately again

rkflx added a comment. Some screenshots of applications with QToolButtons and other elements looking out of place with a tiny toolbar font size: | F3810790: kdevelop+kate.png | | Toolviews in KDevelop

D6697: Allow to change toolbar font separately again

rkflx edited the summary of this revision. rkflx edited the test plan for this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D6697 To: rkflx, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6698: Keep default toolbar font in fonts KCM in sync with plasma-integration

rkflx created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Depends on https://phabricator.kde.org/D6697 TEST PLAN "Defaults" button changes "Toolbar" font size to 10 instead of 9. REPOSITORY R119

D6697: Allow to change toolbar font separately again

rkflx added a dependent revision: D6698: Keep default toolbar font in fonts KCM in sync with plasma-integration. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D6697 To: rkflx, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D6697: Allow to change toolbar font separately again

rkflx created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The fonts KCM supports changing the toolbar font, but with the port to QPA/Plasma 5 in