graesslin added a comment.
In https://phabricator.kde.org/D7096#137461, @davidedmundson wrote:
> under X, any other process can change _net_active_window
No! Other processes are not allowed to change _net_active_window, see
https://specifications.freedesktop.org/wm-spec/wm-spec-la
hpereiradacosta closed this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7355
To: hpereiradacosta, ngraham, graesslin
Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Now that I think about it, this is fine as-is. You actually //can// resize a
tiled window (unlike a maximized window), so the cursor is giving you accurate
information. If you click, the
ngraham created this revision.
ngraham added a project: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This diff will //very slightly// increase the text contrast in the default
Breeze color scheme, while leaving
abondrov updated this revision to Diff 18417.
abondrov added a comment.
Re-create diff against Plasma/5.10 branch.
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5093?vs=18416&id=18417
REVISION DETAIL
https://phabricator
davidedmundson added a comment.
That diff seems messed up, can you double check it please.
The green lines look good though :)
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5093
To: abondrov, jriddell, broulik, davidedmundson
abondrov updated this revision to Diff 18416.
abondrov added a comment.
Use QStandardPaths wtih GenericDataLocation to include ~/.local/share/icons
if it exists.
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5093?vs=12578
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:403b7348e168: notifications: Correctly display the file
in jobs (authored by xuetianweng).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4879?vs=18412&id=
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4879
To: xuetianweng, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
xuetianweng updated this revision to Diff 18412.
xuetianweng added a comment.
update based on david's comments.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4879?vs=12041&id=18412
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
I agree we should be including $XDG_DATA_HOME/icons
We shouldn't be hardcoding that though.
Porting to QStandardPaths wtih GenericDataLocation should solve
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:778b7d037f63: Forward showing desktop only to rootInfo if
it changed (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7097?vs=17633&id=18396
RE
fvogt added a comment.
Looks good to me as well (+ the other patch), I just added two comments.
INLINE COMMENTS
> fonts_global_toolbar.pl:12
> +{
> +chomp;
> +$generalFont = $1 if ($_ =~ /font=(.*)/);
Not sure, but maybe the script should only read/change the `[General]` section?
>
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
showing-desktop-root-info-on-change
REVISION DETAIL
https://phabricator.kde.org/D7097
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolf
rkflx requested review of this revision.
rkflx added a subscriber: fvogt.
rkflx added a comment.
This revision is now accepted and ready to land.
No worries and thanks for the review :)
I'll setup my recently granted commit access and commit to master (even
though originally intended for
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
under X, any other process can change _net_active_window
If that happens we need our m_activeWindow to reflect that, otherwise kwin
can be out of sync and not
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5932
To: subdiff, #plasma, davidedmundson
Cc: Zren, lueck, mart, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4861
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed
davidedmundson added a comment.
Sorry, for the delayed response.
> Are we talking about do the file name parsing in dataengine, and has a
separate data field, called labelFileNameN, and keep it update with labelN?
Yes, that way any other notification implementation gets this fix too.
davidedmundson accepted this revision.
davidedmundson added a comment.
Hey, sorry about the lack of review.
I think the default being the current default makes the most sense.
Patch absolutely makes sense. I like how you even added an update script.
Lets merge this as-is, and then d
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Let's leave it that way
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7404
To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-d
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in baloosearchrunner.cpp:51
> Won't we end up restarting this service over and over again whilst typing
> when Baloo is dlsabled? Not sure how bad that is, though.
If baloo is disabled, but the runner is enabled, yes.
Not a
rkflx planned changes to this revision.
rkflx added a comment.
No review in over a month. On the positive side, I got more ideas in the
meantime.
Let's see if I can find another way to change the toolbar font without
affecting single QToolButtons. Things to try (maybe even both, dependin
broulik added inline comments.
INLINE COMMENTS
> baloosearchrunner.cpp:51
> +if (!config.fileIndexingEnabled()) {
> +return -1;
> +}
Won't we end up restarting this service over and over again whilst typing when
Baloo is dlsabled? Not sure how bad that is, though.
REPOSITORY
davidedmundson updated this revision to Diff 18389.
davidedmundson added a comment.
Kai's comments
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7404?vs=18370&id=18389
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7404
AFFECTED
graesslin added a comment.
Did you see that build.kde.org is not very happy with the new tests?
REPOSITORY
R527 Integration tests for Plasma
REVISION DETAIL
https://phabricator.kde.org/D6134
To: davidedmundson, #plasma, mart
Cc: graesslin, apol, plasma-devel, ZrenBot, progwolff, lesliezh
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:70bc9524d95b: Send QKeyEvent with Qt::Key as expected by
Qt to internal windows (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6828?vs=17014&id=18383#toc
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:f88c322a3b83: [platforms/x11] Use a
GlxContextAttributeBuilder (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6411?vs=16830&id=18382
REVISION
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> abstractrunner.cpp:204
> {
> -Q_UNUSED(match)
> -return nullptr;
> +if (match.urls().isEmpty()) {
> +return nullptr;
Weird indentation
REPOS
broulik added a comment.
Cool!
INLINE COMMENTS
> baloosearchrunner.cpp:49
> {
> +QApplication app(argc, argv); //KRun needs widgets for some reason..
> +app.setQuitOnLastWindowClosed(false);
`KRun` may spawn `QMessageBox` and the like (which makes me wonder if we really
should make
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This change splits out the X11 specific event filtering into a dedicated
X11EventFilter. It is created in the x11 standalone platform pl
graesslin added a dependency: D7395: [tabBox] Move X11 specific event filtering
into a dedicated event filter.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7406
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,
graesslin added a dependent revision: D7406: Move X11 specific event filtering
for ScreenEdges into x11 standalone platform.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7395
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-moham
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:36a318986316: Create a dedicated X11EventFilter for
recognizing first user interaction (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7371?vs=
34 matches
Mail list logo