D7447: Move screen inversion through XRandr into X11 standalone platform

2017-08-20 Thread Martin Flöser
graesslin added a dependency: D7444: Move the X11 Decoration Renderer into the X11 standalone platform. REVISION DETAIL https://phabricator.kde.org/D7447 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, luk

D7444: Move the X11 Decoration Renderer into the X11 standalone platform

2017-08-20 Thread Martin Flöser
graesslin added a dependent revision: D7447: Move screen inversion through XRandr into X11 standalone platform. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7444 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening

D7447: Move screen inversion through XRandr into X11 standalone platform

2017-08-20 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY By moving the functionality into the Platform API we can also implement support on other platforms which support this in general (e.g. DRM

D7436: kimpanel: change highlight color

2017-08-20 Thread Xuetian Weng
xuetianweng added a comment. Can you try to make use of PlasmaComponents.Highlight instead of custom highlight like this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: guoyunhe, #plasma Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-08-20 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-08-20 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed

[Breeze] [Bug 381288] Breeze could use higher-contrast text by default (tweaked color scheme attached)

2017-08-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=381288 --- Comment #8 from Nate Graham --- I've submitted a patch for this: https://phabricator.kde.org/D7424 IMHO increasing the contrast in the manner I've indicated makes it easier to read and easier on the eyes, not harder. Black text on a light gray back

D7424: Very slightly increase text contrast for the default Breeze color scheme

2017-08-20 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7424 To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lu

D7444: Move the X11 Decoration Renderer into the X11 standalone platform

2017-08-20 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Not needed except for X11/non-composited usage, so should be in the plugin instead of core. Platform API is extended to create a de

D7096: Only send active window changes to X11 root window if the X11 window changed

2017-08-20 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:0455fa9ef989: Only send active window changes to X11 root window if the X11 window changed (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7096

D6764: Add font size setting to the digital clock plasmoid

2017-08-20 Thread Nathaniel Graham
ngraham added a comment. Any reasons not to land this or https://phabricator.kde.org/D6813? REVISION DETAIL https://phabricator.kde.org/D6764 To: januz, #plasma, #vdg Cc: ngraham, Zren, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lu

D6813: Use customized font size for Digital Clock applet

2017-08-20 Thread Nathaniel Graham
ngraham added a comment. Any reasons not to land this or https://phabricator.kde.org/D6764? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6813 To: guoyunhe, #plasma_workspaces Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-

D7436: kimpanel: change highlight color

2017-08-20 Thread Yunhe Guo
guoyunhe edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: guoyunhe, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

2017-08-20 Thread Yunhe Guo
guoyunhe added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: guoyunhe, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

2017-08-20 Thread Yunhe Guo
guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Before: Highlighted candidate uses theme.highlightColor for text, but this color should only be used in background color, not text color

D5524: Use System Dictionary for Suggestions Model

2017-08-20 Thread Aditya Mehra
This revision was automatically updated to reflect the committed changes. Closed by commit R846:9018da923006: Use System Dictionary for Suggestions Model (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5524?vs=13636&id=184

D6698: Keep default toolbar font in fonts KCM in sync with plasma-integration

2017-08-20 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R119:bc16cc405966: Keep default toolbar font in fonts KCM in sync with plasma-integration (authored by rkflx). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6698?vs=16689&id=18444#toc REPOSITORY

D7096: Only send active window changes to X11 root window if the X11 window changed

2017-08-20 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. @luebking right, thanks for clarifying that. REPOSITORY R108 KWin BRANCH root-info-only-on-change REVISION DETAIL https://phabricator.kde.org/D7096 To: graesslin, #k

D6697: Allow to change toolbar font separately again

2017-08-20 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R135:86be8d49d898: Allow to change toolbar font separately again (authored by rkflx). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D66

D7343: auto generate desktop file for url handling

2017-08-20 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D7343#136271, @sitter wrote: > @ltoscano is this file name change compatible from an i18n POV? *.desktop.cmake files are processed like .desktop files also elsewhere, so this should work. REPOSITORY R134 Discover Software

D7096: Only send active window changes to X11 root window if the X11 window changed

2017-08-20 Thread Thomas Lübking
luebking added a comment. Unless things changed for the worse, clients (through this function) still send a client message (on _NET_ACTIVE_WINDOW) - the difference between the regular call and the force version is the source indication being "2" ("i'm a pager/taskbar and know what i'm doing

D7096: Only send active window changes to X11 root window if the X11 window changed

2017-08-20 Thread David Edmundson
davidedmundson added a comment. So am I wrong in thinking on X, our favourite method KWindowSystem::forceActiveWindow changes _net_active_window on the root window? My concern is: - Typing in client A - Client B does KWindowSystem::forceWindowActive() - User ignores it and select

D6697: Allow to change toolbar font separately again

2017-08-20 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. Latest changes look good to me as well. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D6697 To: rkflx, #plasma, davidedmundson, fvogt Cc: fvogt, davidedmundson, j

D6697: Allow to change toolbar font separately again

2017-08-20 Thread Henrik Fehlauer
rkflx edited the summary of this revision. rkflx edited the test plan for this revision. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D6697 To: rkflx, #plasma, davidedmundson Cc: fvogt, davidedmundson, jensreuterberg,

D6697: Allow to change toolbar font separately again

2017-08-20 Thread Henrik Fehlauer
rkflx updated this revision to Diff 18431. rkflx marked 2 inline comments as done. rkflx added a comment. - add FIXED-IN - rebase on Fabian's changes - take care of Fabian's comments (extend upd, remove pl) REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPD

D6697: Allow to change toolbar font separately again

2017-08-20 Thread Henrik Fehlauer
rkflx marked 2 inline comments as done. rkflx added inline comments. INLINE COMMENTS > fvogt wrote in fonts_global_toolbar.pl:12 > Not sure, but maybe the script should only read/change the `[General]` > section? Not done in the other update scripts either and not strictly necessary, but you a

D6698: Keep default toolbar font in fonts KCM in sync with plasma-integration

2017-08-20 Thread Henrik Fehlauer
rkflx added a subscriber: fvogt. rkflx added a comment. Approved by @fvogt in https://phabricator.kde.org/D6697#137474 – thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6698 To: rkflx, #plasma Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, al

D7096: Only send active window changes to X11 root window if the X11 window changed

2017-08-20 Thread Thomas Lübking
luebking added a comment. There's no technical advantage in a local static, only a design one. You prevent it from future mis-use beyond its limited purpose, because m_activeWindow isn't actually a "property" of RootInfo. If you however at some point need several instances, that's no longer

D6494: Drop unused dependencies KF5WindowSystem and KF5XmlGui

2017-08-20 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D6494 To: asturmlechner, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7426: Make AbstractClient::caption no longer a virtual method

2017-08-20 Thread Martin Flöser
graesslin added a dependent revision: D7427: Drop boolean parameter from AbstractClient::caption. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7426 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterb

D7427: Drop boolean parameter from AbstractClient::caption

2017-08-20 Thread Martin Flöser
graesslin added a dependency: D7426: Make AbstractClient::caption no longer a virtual method. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7427 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg,

D7427: Drop boolean parameter from AbstractClient::caption

2017-08-20 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY With the latest refactoring AbstractClient::captionNormal is the same as AbstractClient::caption(false) used to be. As there were only t

D7096: Only send active window changes to X11 root window if the X11 window changed

2017-08-20 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D7096#137647, @luebking wrote: > David has some point though - m_activeWindow *can* get out of sync (server error, mal... stupid client - and will be temporarily due to the async setup) and must not be used directly to query the a

D7425: Add to Wayland captions if the caption is the same

2017-08-20 Thread Martin Flöser
graesslin added a dependent revision: D7426: Make AbstractClient::caption no longer a virtual method. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7425 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreu

D7426: Make AbstractClient::caption no longer a virtual method

2017-08-20 Thread Martin Flöser
graesslin added a dependency: D7425: Add to Wayland captions if the caption is the same. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7426 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abe

D7426: Make AbstractClient::caption no longer a virtual method

2017-08-20 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The implementation can now be shared, it doesn't differ anymore between X11 (Client) and Wayland (ShellClient). So instead of code dupli

D7096: Only send active window changes to X11 root window if the X11 window changed

2017-08-20 Thread Thomas Lübking
luebking added a comment. David has some point though - m_activeWindow *can* get out of sync (server error, mal... stupid client - and will be temporarily due to the async setup) and must not be used directly to query the active window. Since there should be only one root per process, ma

D7425: Add to Wayland captions if the caption is the same

2017-08-20 Thread Martin Flöser
graesslin added a comment. F3869757: Screenshot_20170820_090311.png the numbering works for same caption for windows on X11 and Wayland. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7425 To: graesslin, #kwin, #plasma Cc: p

D7425: Add to Wayland captions if the caption is the same

2017-08-20 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Bringing another caption feature from X11 to Wayland. If we have multiple windows with the same caption, starting from the second window