januz added a comment.
> I think this explains why you haven't had a review, this existing code is
already sketchy as-is :/
> But we should be trying to fix that not just all of us ignoring it. Sorry
about that.
No problem, I can understand the dread of piling stuff on code that
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:a88cad3bc72c: Header as one ToolButton for Back action
(authored by subdiff).
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7749?vs=19338=19384
REVISION
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in blur.cpp:76
> I was expecting you to do what you for the present windows effect with
> calling your local lambda announceSupportProperties.
>
> IMHO it's neater than duplicating - but this is fine too.
I didn't go for
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> blur.cpp:76
> connect(effects, SIGNAL(screenGeometryChanged(QSize)), this,
> SLOT(slotScreenGeometryChanged()));
> +connect(effects,
graesslin updated this revision to Diff 19381.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Addressed David's comments
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7761?vs=19367=19381
BRANCH
mart updated this revision to Diff 19372.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Temporary popup stuff
- Update to signal rename
- skip taskbar/pager/windowmanagement for xdgpopups
- send configure on popup resize
- Merge branch
mart commandeered this revision.
mart edited reviewers, added: davidedmundson; removed: mart.
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D6591
To: mart, #plasma, graesslin, davidedmundson
Cc: mart,
bshah added a comment.
In https://phabricator.kde.org/D7740#144077, @graesslin wrote:
> @bshah could you please try this patch on hwcomposer platform? I tried to
get all required changes into it, but I currently don't have a compiler to
verify.
Can you commit them in one branch?
mart added inline comments.
INLINE COMMENTS
> graesslin wrote in shell_client.cpp:608-609
> That logic I don't understand: why do we ping to close? Why a roundtrip to
> the app, when all we want to do is close it? Just send it a close?
i copied from the x11 client, where on client::CloseWindow
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
xrandr-event-filter
REVISION DETAIL
https://phabricator.kde.org/D7654
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff,
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> contrast.cpp:63
> +[this] {
> +net_wm_contrast_region =
> effects->announceSupportProperty(s_contrastAtomName, this);
> +
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:8522ef17eea0: Do not hard runtime depend on X11 in
RuleBook (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7653?vs=19083=19369
REVISION
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Several effects announce a support property atom on the root window. This
change forwards the KWin::Application's signal that the
tcberner added a comment.
I could not find anything similar. So that's probably the way to go.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7757
To: graesslin, #kwin, #plasma
Cc: tcberner, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Only needed for kwin_x11 variant (required for the non-composited
Outline). As that's nowadays in the x11 platform, we can move the
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:3a4cd88c7f27: Improved Suggestions Model (authored by
Aiix).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5497?vs=13576=19360#toc
REPOSITORY
R846 Mycroft Plasma integration
CHANGES SINCE
graesslin added a comment.
In https://phabricator.kde.org/D7757#144415, @tcberner wrote:
>^
> /home/Tobias/git/kwin/main_wayland.cpp:452:38: error: use of undeclared
identifier 'SCHED_RESET_ON_FORK'
> sched_setscheduler(0, SCHED_RR | SCHED_RESET_ON_FORK,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
rulebook-no-x11
REVISION DETAIL
https://phabricator.kde.org/D7653
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff,
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7654
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7653
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:ffc2a64d1f97: Don't enter test subdirectories if
BUILD_TESTING=OFF (authored by asturmlechner).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7756
To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
tcberner added a comment.
^
/home/Tobias/git/kwin/main_wayland.cpp:452:38: error: use of undeclared
identifier 'SCHED_RESET_ON_FORK'
sched_setscheduler(0, SCHED_RR | SCHED_RESET_ON_FORK, );
^
Yes,
graesslin added a subscriber: tcberner.
graesslin added a comment.
@tcberner could you please try to compile this change on FreeBSD? I just want
to be sure that it doesn't introduce a linux-ism. The most prominent dangerous
part could be SCHED_RESET_ON_FORK where I'm not sure whether it is
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The base idea behind this change is to keep the system responsive no
matter what other processes do. All input and rendering needs to
asturmlechner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Qt5Test is an optional dependency but not followed in some subdirs.
REPOSITORY
R320 KIO Extras
BRANCH
master
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:940adc7e6e69: [Plasma Components 3] Fix RTL in some
widgets. (authored by safaalfulaij).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7733
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
28 matches
Mail list logo
